[INFO] fetching crate esp-01 0.1.1... [INFO] checking esp-01-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate esp-01 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate esp-01 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate esp-01 0.1.1 [INFO] finished tweaking crates.io crate esp-01 0.1.1 [INFO] tweaked toml for crates.io crate esp-01 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1bebfb3e8b3a2a20c5d48695f677c2a2db4e9c911e038bac4094333c72464ac5 [INFO] running `Command { std: "docker" "start" "-a" "1bebfb3e8b3a2a20c5d48695f677c2a2db4e9c911e038bac4094333c72464ac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1bebfb3e8b3a2a20c5d48695f677c2a2db4e9c911e038bac4094333c72464ac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1bebfb3e8b3a2a20c5d48695f677c2a2db4e9c911e038bac4094333c72464ac5", kill_on_drop: false }` [INFO] [stdout] 1bebfb3e8b3a2a20c5d48695f677c2a2db4e9c911e038bac4094333c72464ac5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70241bb74703116af7b20599b4811c75b029556d72431461757caf9a09b54f13 [INFO] running `Command { std: "docker" "start" "-a" "70241bb74703116af7b20599b4811c75b029556d72431461757caf9a09b54f13", kill_on_drop: false }` [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking esp-01 v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/serial.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | Err(nb::Error::Other(_e)) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/serial.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | Err(nb::Error::Other(_e)) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `step` and `cause` are never read [INFO] [stdout] --> src/lib.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 83 | pub struct TransmissionError { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 84 | step: TransmissionStep, [INFO] [stdout] | ^^^^ [INFO] [stdout] 85 | cause: Error [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransmissionError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:62 [INFO] [stdout] | [INFO] [stdout] 184 | let tcp_start_result = self.start_tcp_connection(connection_type, address, port); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | TransmissionError::try_step(TransmissionStep::Close, self.close_connection()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esp-01` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `step` and `cause` are never read [INFO] [stdout] --> src/lib.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 83 | pub struct TransmissionError { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 84 | step: TransmissionStep, [INFO] [stdout] | ^^^^ [INFO] [stdout] 85 | cause: Error [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransmissionError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:62 [INFO] [stdout] | [INFO] [stdout] 184 | let tcp_start_result = self.start_tcp_connection(connection_type, address, port); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | TransmissionError::try_step(TransmissionStep::Close, self.close_connection()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esp-01` (lib) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "70241bb74703116af7b20599b4811c75b029556d72431461757caf9a09b54f13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70241bb74703116af7b20599b4811c75b029556d72431461757caf9a09b54f13", kill_on_drop: false }` [INFO] [stdout] 70241bb74703116af7b20599b4811c75b029556d72431461757caf9a09b54f13