[INFO] fetching crate esexpr-derive 0.1.14... [INFO] checking esexpr-derive-0.1.14 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate esexpr-derive 0.1.14 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate esexpr-derive 0.1.14 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate esexpr-derive 0.1.14 [INFO] finished tweaking crates.io crate esexpr-derive 0.1.14 [INFO] tweaked toml for crates.io crate esexpr-derive 0.1.14 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c10ba0bf177484a8a3bb5780edf9efbd844fb638d85f3880fada360ff08e736 [INFO] running `Command { std: "docker" "start" "-a" "5c10ba0bf177484a8a3bb5780edf9efbd844fb638d85f3880fada360ff08e736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c10ba0bf177484a8a3bb5780edf9efbd844fb638d85f3880fada360ff08e736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c10ba0bf177484a8a3bb5780edf9efbd844fb638d85f3880fada360ff08e736", kill_on_drop: false }` [INFO] [stdout] 5c10ba0bf177484a8a3bb5780edf9efbd844fb638d85f3880fada360ff08e736 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f96c5e3fd6f6e0660df4e58d7dc042836a0c3bca07d18fd973e4c5e31fd5bc1 [INFO] running `Command { std: "docker" "start" "-a" "5f96c5e3fd6f6e0660df4e58d7dc042836a0c3bca07d18fd973e4c5e31fd5bc1", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking esexpr-derive v0.1.14 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn derive_esexpr_codec(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | TokenStream::from(derive_esexpr_codec_impl(proc_macro2::TokenStream::from(input))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:403:13 [INFO] [stdout] | [INFO] [stdout] 399 | let field_expr = make_field_expr(field.ident.as_ref(), i); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | / if let Some(keyword_attr) = keyword_attribute(&field.attrs)? { [INFO] [stdout] 404 | | if has_dict_field { [INFO] [stdout] 405 | | Err(quote! { compile_error!("Keyword arguments must preceed dict arguments"); })?; [INFO] [stdout] 406 | | } [INFO] [stdout] ... | [INFO] [stdout] 480 | | } [INFO] [stdout] 481 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:605:8 [INFO] [stdout] | [INFO] [stdout] 603 | fn make_decode_fields(fields: &Fields, constructor_name: &Expr, constructor: proc_macro2::TokenStream) -> TokenRes { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | let mut arg_index = 0; [INFO] [stdout] 605 | Ok(match fields { [INFO] [stdout] | ________^ [INFO] [stdout] 606 | | Fields::Named(fields) => { [INFO] [stdout] 607 | | let field_init: proc_macro2::TokenStream = fields.named.iter().map(|field| -> TokenRes { [INFO] [stdout] 608 | | let field_name = field.ident.as_ref().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 623 | | Fields::Unit => constructor, [INFO] [stdout] 624 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:860:5 [INFO] [stdout] | [INFO] [stdout] 860 | / syn::parse_str::(&expr_str) [INFO] [stdout] 861 | | .map(Some) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn derive_esexpr_codec(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | TokenStream::from(derive_esexpr_codec_impl(proc_macro2::TokenStream::from(input))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:403:13 [INFO] [stdout] | [INFO] [stdout] 399 | let field_expr = make_field_expr(field.ident.as_ref(), i); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | / if let Some(keyword_attr) = keyword_attribute(&field.attrs)? { [INFO] [stdout] 404 | | if has_dict_field { [INFO] [stdout] 405 | | Err(quote! { compile_error!("Keyword arguments must preceed dict arguments"); })?; [INFO] [stdout] 406 | | } [INFO] [stdout] ... | [INFO] [stdout] 480 | | } [INFO] [stdout] 481 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:605:8 [INFO] [stdout] | [INFO] [stdout] 603 | fn make_decode_fields(fields: &Fields, constructor_name: &Expr, constructor: proc_macro2::TokenStream) -> TokenRes { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | let mut arg_index = 0; [INFO] [stdout] 605 | Ok(match fields { [INFO] [stdout] | ________^ [INFO] [stdout] 606 | | Fields::Named(fields) => { [INFO] [stdout] 607 | | let field_init: proc_macro2::TokenStream = fields.named.iter().map(|field| -> TokenRes { [INFO] [stdout] 608 | | let field_name = field.ident.as_ref().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 623 | | Fields::Unit => constructor, [INFO] [stdout] 624 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:860:5 [INFO] [stdout] | [INFO] [stdout] 860 | / syn::parse_str::(&expr_str) [INFO] [stdout] 861 | | .map(Some) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esexpr-derive` (lib) due to 5 previous errors [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `esexpr-derive` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5f96c5e3fd6f6e0660df4e58d7dc042836a0c3bca07d18fd973e4c5e31fd5bc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f96c5e3fd6f6e0660df4e58d7dc042836a0c3bca07d18fd973e4c5e31fd5bc1", kill_on_drop: false }` [INFO] [stdout] 5f96c5e3fd6f6e0660df4e58d7dc042836a0c3bca07d18fd973e4c5e31fd5bc1