[INFO] fetching crate error-stack 0.5.0... [INFO] checking error-stack-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate error-stack 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate error-stack 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate error-stack 0.5.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate error-stack 0.5.0 [INFO] tweaked toml for crates.io crate error-stack 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate error-stack 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c0d09ff2011e547bdbf2547cdd969dba01b8eea025282a2917167f09a06cf162 [INFO] running `Command { std: "docker" "start" "-a" "c0d09ff2011e547bdbf2547cdd969dba01b8eea025282a2917167f09a06cf162", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c0d09ff2011e547bdbf2547cdd969dba01b8eea025282a2917167f09a06cf162", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0d09ff2011e547bdbf2547cdd969dba01b8eea025282a2917167f09a06cf162", kill_on_drop: false }` [INFO] [stdout] c0d09ff2011e547bdbf2547cdd969dba01b8eea025282a2917167f09a06cf162 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ed2c514804bff23787c5f391ee36cfb15a5d9df9630b3da46a907892390eab9 [INFO] running `Command { std: "docker" "start" "-a" "5ed2c514804bff23787c5f391ee36cfb15a5d9df9630b3da46a907892390eab9", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling trybuild v1.0.97 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Compiling error-stack v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 237 | fn attach(self, attachment: A) -> FutureWithAttachment [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | inner: Some(attachment), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 248 | fn attach_lazy(self, attachment: F) -> FutureWithLazyAttachment [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | inner: Some(attachment), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:266:20 [INFO] [stdout] | [INFO] [stdout] 260 | fn attach_printable(self, attachment: A) -> FutureWithPrintableAttachment [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | inner: Some(attachment), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:281:20 [INFO] [stdout] | [INFO] [stdout] 272 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | attachment: F, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | inner: Some(attachment), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:292:20 [INFO] [stdout] | [INFO] [stdout] 286 | fn change_context(self, context: C) -> FutureWithContext [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | inner: Some(context), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:304:20 [INFO] [stdout] | [INFO] [stdout] 297 | fn change_context_lazy(self, context: F) -> FutureWithLazyContext [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | inner: Some(context), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame/frame_impl.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 210 | pub(crate) fn from_context(context: C, sources: Box<[Self]>) -> Self [INFO] [stdout] | ---------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | frame: Box::new(ContextFrame { context }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame/frame_impl.rs:226:20 [INFO] [stdout] | [INFO] [stdout] 221 | pub(crate) fn from_attachment(attachment: A, sources: Box<[Self]>) -> Self [INFO] [stdout] | ------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | frame: Box::new(AttachmentFrame { attachment }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame/frame_impl.rs:240:20 [INFO] [stdout] | [INFO] [stdout] 235 | pub(crate) fn from_printable_attachment(attachment: A, sources: Box<[Self]>) -> Self [INFO] [stdout] | ------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | frame: Box::new(PrintableAttachmentFrame { attachment }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:294:26 [INFO] [stdout] | [INFO] [stdout] 267 | pub fn new(context: C) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Self::from_frame(Frame::from_context(context, Box::new([]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:682:18 [INFO] [stdout] | [INFO] [stdout] 681 | fn from(report: Report) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 682 | Box::new(report.into_error()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:689:18 [INFO] [stdout] | [INFO] [stdout] 688 | fn from(report: Report) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 689 | Box::new(report.into_error()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:696:18 [INFO] [stdout] | [INFO] [stdout] 695 | fn from(report: Report) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 696 | Box::new(report.into_error()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:703:18 [INFO] [stdout] | [INFO] [stdout] 702 | fn from(report: Report) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 703 | Box::new(report.into_error()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/mod.rs:724:14 [INFO] [stdout] | [INFO] [stdout] 723 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 724 | Self(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hook/context.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn insert(&mut self, value: U) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | / self.storage_mut() [INFO] [stdout] 212 | | .entry(TypeId::of::()) [INFO] [stdout] 213 | | .or_default() [INFO] [stdout] 214 | | .insert(TypeId::of::(), Box::new(value))? [INFO] [stdout] 215 | | .downcast() [INFO] [stdout] 216 | | .map(|boxed| *boxed) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/fmt/hook.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | / crate::hook::context::impl_hook_context! { [INFO] [stdout] 47 | | /// Carrier for contextual information used across hook invocations. [INFO] [stdout] 48 | | /// [INFO] [stdout] 49 | | /// `HookContext` has two fundamental use-cases: [INFO] [stdout] ... | [INFO] [stdout] 226 | | pub struct HookContext { .. } [INFO] [stdout] 227 | | } [INFO] [stdout] | |__- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::hook::context::impl_hook_context` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/hook.rs:379:14 [INFO] [stdout] | [INFO] [stdout] 377 | hook: impl Fn(&T, &mut HookContext) + Send + Sync + 'static, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 378 | ) -> BoxedHook { [INFO] [stdout] 379 | Box::new(move |frame: &Frame, context: &mut HookContext| { [INFO] [stdout] | ______________^ [INFO] [stdout] 380 | | #[cfg(nightly)] [INFO] [stdout] 381 | | { [INFO] [stdout] 382 | | frame [INFO] [stdout] ... | [INFO] [stdout] 401 | | .is_some() [INFO] [stdout] 402 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hook/context.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(extra: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Self { [INFO] [stdout] 39 | storage: Storage::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `error-stack` (lib) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5ed2c514804bff23787c5f391ee36cfb15a5d9df9630b3da46a907892390eab9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ed2c514804bff23787c5f391ee36cfb15a5d9df9630b3da46a907892390eab9", kill_on_drop: false }` [INFO] [stdout] 5ed2c514804bff23787c5f391ee36cfb15a5d9df9630b3da46a907892390eab9