[INFO] fetching crate ergo-pin 0.1.0... [INFO] checking ergo-pin-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ergo-pin 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ergo-pin 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ergo-pin 0.1.0 [INFO] finished tweaking crates.io crate ergo-pin 0.1.0 [INFO] tweaked toml for crates.io crate ergo-pin 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c77f5497bbdd586674dbfec7502e8b1c777b8633823527dd8f0a65b17816a366 [INFO] running `Command { std: "docker" "start" "-a" "c77f5497bbdd586674dbfec7502e8b1c777b8633823527dd8f0a65b17816a366", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c77f5497bbdd586674dbfec7502e8b1c777b8633823527dd8f0a65b17816a366", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c77f5497bbdd586674dbfec7502e8b1c777b8633823527dd8f0a65b17816a366", kill_on_drop: false }` [INFO] [stdout] c77f5497bbdd586674dbfec7502e8b1c777b8633823527dd8f0a65b17816a366 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e74c98d04efc4a83c6961d893409e53bdd8db60d1eb8d245ebcfbfb74de1e81a [INFO] running `Command { std: "docker" "start" "-a" "e74c98d04efc4a83c6961d893409e53bdd8db60d1eb8d245ebcfbfb74de1e81a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking ergo-pin v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 151 | fn fold_block(&mut self, block: syn::Block) -> syn::Block { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | stmts: block [INFO] [stdout] | ____________________^ [INFO] [stdout] 155 | | .stmts [INFO] [stdout] 156 | | .into_iter() [INFO] [stdout] 157 | | .flat_map(|stmt| { [INFO] [stdout] ... | [INFO] [stdout] 176 | | }) [INFO] [stdout] 177 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:21 [INFO] [stdout] | [INFO] [stdout] 157 | .flat_map(|stmt| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let prior = std::mem::replace(&mut self.pinned, vec![]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let stmt = self.fold_stmt(stmt); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | / std::mem::replace(&mut self.pinned, prior) [INFO] [stdout] 161 | | .into_iter() [INFO] [stdout] 162 | | .flat_map(|(ident, expr)| { [INFO] [stdout] 163 | | syn::parse::( [INFO] [stdout] ... | [INFO] [stdout] 173 | | .stmts [INFO] [stdout] 174 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:32 [INFO] [stdout] | [INFO] [stdout] 157 | .flat_map(|stmt| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let prior = std::mem::replace(&mut self.pinned, vec![]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let stmt = self.fold_stmt(stmt); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | .chain(std::iter::once(stmt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:29 [INFO] [stdout] | [INFO] [stdout] 162 | .flat_map(|(ident, expr)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | / syn::parse::( [INFO] [stdout] 164 | | quote!({ [INFO] [stdout] 165 | | let mut #ident = #expr; [INFO] [stdout] 166 | | let #ident = unsafe { [INFO] [stdout] ... | [INFO] [stdout] 171 | | ) [INFO] [stdout] 172 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:206:19 [INFO] [stdout] | [INFO] [stdout] 201 | fn fold_expr_while(&mut self, expr: syn::ExprWhile) -> syn::ExprWhile { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | cond: Box::new(if let syn::Expr::Let(cond) = *expr.cond { [INFO] [stdout] | ___________________^ [INFO] [stdout] 207 | | syn::Expr::Let(syn::ExprLet { [INFO] [stdout] 208 | | expr: Box::new(syn::Expr::Block(syn::ExprBlock { [INFO] [stdout] 209 | | attrs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 230 | | }) [INFO] [stdout] 231 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:19 [INFO] [stdout] | [INFO] [stdout] 201 | fn fold_expr_while(&mut self, expr: syn::ExprWhile) -> syn::ExprWhile { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | body: self.fold_block(expr.body), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 151 | fn fold_block(&mut self, block: syn::Block) -> syn::Block { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | stmts: block [INFO] [stdout] | ____________________^ [INFO] [stdout] 155 | | .stmts [INFO] [stdout] 156 | | .into_iter() [INFO] [stdout] 157 | | .flat_map(|stmt| { [INFO] [stdout] ... | [INFO] [stdout] 176 | | }) [INFO] [stdout] 177 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:21 [INFO] [stdout] | [INFO] [stdout] 157 | .flat_map(|stmt| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let prior = std::mem::replace(&mut self.pinned, vec![]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let stmt = self.fold_stmt(stmt); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | / std::mem::replace(&mut self.pinned, prior) [INFO] [stdout] 161 | | .into_iter() [INFO] [stdout] 162 | | .flat_map(|(ident, expr)| { [INFO] [stdout] 163 | | syn::parse::( [INFO] [stdout] ... | [INFO] [stdout] 173 | | .stmts [INFO] [stdout] 174 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:32 [INFO] [stdout] | [INFO] [stdout] 157 | .flat_map(|stmt| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let prior = std::mem::replace(&mut self.pinned, vec![]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let stmt = self.fold_stmt(stmt); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | .chain(std::iter::once(stmt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:29 [INFO] [stdout] | [INFO] [stdout] 162 | .flat_map(|(ident, expr)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | / syn::parse::( [INFO] [stdout] 164 | | quote!({ [INFO] [stdout] 165 | | let mut #ident = #expr; [INFO] [stdout] 166 | | let #ident = unsafe { [INFO] [stdout] ... | [INFO] [stdout] 171 | | ) [INFO] [stdout] 172 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:206:19 [INFO] [stdout] | [INFO] [stdout] 201 | fn fold_expr_while(&mut self, expr: syn::ExprWhile) -> syn::ExprWhile { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | cond: Box::new(if let syn::Expr::Let(cond) = *expr.cond { [INFO] [stdout] | ___________________^ [INFO] [stdout] 207 | | syn::Expr::Let(syn::ExprLet { [INFO] [stdout] 208 | | expr: Box::new(syn::Expr::Block(syn::ExprBlock { [INFO] [stdout] 209 | | attrs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 230 | | }) [INFO] [stdout] 231 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:19 [INFO] [stdout] | [INFO] [stdout] 201 | fn fold_expr_while(&mut self, expr: syn::ExprWhile) -> syn::ExprWhile { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | body: self.fold_block(expr.body), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ergo-pin` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ergo-pin` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "e74c98d04efc4a83c6961d893409e53bdd8db60d1eb8d245ebcfbfb74de1e81a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e74c98d04efc4a83c6961d893409e53bdd8db60d1eb8d245ebcfbfb74de1e81a", kill_on_drop: false }` [INFO] [stdout] e74c98d04efc4a83c6961d893409e53bdd8db60d1eb8d245ebcfbfb74de1e81a