[INFO] fetching crate erebus-sdk-rust 1.4.0... [INFO] checking erebus-sdk-rust-1.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate erebus-sdk-rust 1.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate erebus-sdk-rust 1.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate erebus-sdk-rust 1.4.0 [INFO] finished tweaking crates.io crate erebus-sdk-rust 1.4.0 [INFO] tweaked toml for crates.io crate erebus-sdk-rust 1.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate erebus-sdk-rust 1.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a34bf4d73a3f8e08cc7615ebb99706b97a695f94942a1a49d21d723dc3c482c0 [INFO] running `Command { std: "docker" "start" "-a" "a34bf4d73a3f8e08cc7615ebb99706b97a695f94942a1a49d21d723dc3c482c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a34bf4d73a3f8e08cc7615ebb99706b97a695f94942a1a49d21d723dc3c482c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a34bf4d73a3f8e08cc7615ebb99706b97a695f94942a1a49d21d723dc3c482c0", kill_on_drop: false }` [INFO] [stdout] a34bf4d73a3f8e08cc7615ebb99706b97a695f94942a1a49d21d723dc3c482c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b40a28492c092c3759b045ce9d550bf109ba702d154c86dea2eaf106c8b2bff8 [INFO] running `Command { std: "docker" "start" "-a" "b40a28492c092c3759b045ce9d550bf109ba702d154c86dea2eaf106c8b2bff8", kill_on_drop: false }` [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling aws-lc-rs v1.8.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling aws-lc-sys v0.20.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking tokio-tungstenite v0.23.1 [INFO] [stderr] Checking erebus-sdk-rust v1.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `SinkExt` and `StreamExt` [INFO] [stdout] --> src/lib.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | use futures_util::{SinkExt, StreamExt}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deserialize` [INFO] [stdout] --> src/lib.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SinkExt` and `StreamExt` [INFO] [stdout] --> src/lib.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | use futures_util::{SinkExt, StreamExt}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deserialize` [INFO] [stdout] --> src/lib.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `close` is never used [INFO] [stdout] --> src/client.rs:146:14 [INFO] [stdout] | [INFO] [stdout] 17 | impl ErebusWebSocketClient { [INFO] [stdout] | -------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 146 | async fn close(mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new(size: usize, initializer: impl Fn() -> T) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Pool { [INFO] [stdout] 10 | instances: (0..size) [INFO] [stdout] | ________________________^ [INFO] [stdout] 11 | | .map(|_| Mutex::new(initializer())) [INFO] [stdout] 12 | | .collect::>(), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | .map(|_| Mutex::new(initializer())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:70:35 [INFO] [stdout] | [INFO] [stdout] 70 | body: body.map(|body| serde_json::to_string(&body).unwrap()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:79:33 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|body| serde_json::from_str(&body).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `close` is never used [INFO] [stdout] --> src/client.rs:146:14 [INFO] [stdout] | [INFO] [stdout] 17 | impl ErebusWebSocketClient { [INFO] [stdout] | -------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 146 | async fn close(mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new(size: usize, initializer: impl Fn() -> T) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Pool { [INFO] [stdout] 10 | instances: (0..size) [INFO] [stdout] | ________________________^ [INFO] [stdout] 11 | | .map(|_| Mutex::new(initializer())) [INFO] [stdout] 12 | | .collect::>(), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | .map(|_| Mutex::new(initializer())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:70:35 [INFO] [stdout] | [INFO] [stdout] 70 | body: body.map(|body| serde_json::to_string(&body).unwrap()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:79:33 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|body| serde_json::from_str(&body).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `erebus-sdk-rust` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `erebus-sdk-rust` (lib) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b40a28492c092c3759b045ce9d550bf109ba702d154c86dea2eaf106c8b2bff8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b40a28492c092c3759b045ce9d550bf109ba702d154c86dea2eaf106c8b2bff8", kill_on_drop: false }` [INFO] [stdout] b40a28492c092c3759b045ce9d550bf109ba702d154c86dea2eaf106c8b2bff8