[INFO] fetching crate envy 0.4.2... [INFO] checking envy-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate envy 0.4.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate envy 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate envy 0.4.2 [INFO] finished tweaking crates.io crate envy 0.4.2 [INFO] tweaked toml for crates.io crate envy 0.4.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate envy 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 67d1ad03d00a055f970ca2166bd1f8f9710c63a5502eced8366c366bab73da95 [INFO] running `Command { std: "docker" "start" "-a" "67d1ad03d00a055f970ca2166bd1f8f9710c63a5502eced8366c366bab73da95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "67d1ad03d00a055f970ca2166bd1f8f9710c63a5502eced8366c366bab73da95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67d1ad03d00a055f970ca2166bd1f8f9710c63a5502eced8366c366bab73da95", kill_on_drop: false }` [INFO] [stdout] 67d1ad03d00a055f970ca2166bd1f8f9710c63a5502eced8366c366bab73da95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4591a5117eef7da4a62989b34d9af643a25538e7cf0a2d91d7331f5495a5e4f9 [INFO] running `Command { std: "docker" "start" "-a" "4591a5117eef7da4a62989b34d9af643a25538e7cf0a2d91d7331f5495a5e4f9", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.57 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking envy v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:254:20 [INFO] [stdout] | [INFO] [stdout] 252 | fn new(vars: Iter) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | Deserializer { [INFO] [stdout] 254 | inner: MapDeserializer::new(Vars(vars)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 301 | pub fn from_iter(iter: Iter) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | T::deserialize(Deserializer::new(iter.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:26 [INFO] [stdout] | [INFO] [stdout] 326 | iter: Iter, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | crate::from_iter(iter.into_iter().filter_map(|(k, v)| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 333 | | if k.starts_with(self.0.as_ref()) { [INFO] [stdout] 334 | | Some((k.trim_start_matches(self.0.as_ref()).to_owned(), v)) [INFO] [stdout] 335 | | } else { [INFO] [stdout] 336 | | None [INFO] [stdout] 337 | | } [INFO] [stdout] 338 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `envy` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:254:20 [INFO] [stdout] | [INFO] [stdout] 252 | fn new(vars: Iter) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | Deserializer { [INFO] [stdout] 254 | inner: MapDeserializer::new(Vars(vars)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 301 | pub fn from_iter(iter: Iter) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | T::deserialize(Deserializer::new(iter.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:26 [INFO] [stdout] | [INFO] [stdout] 326 | iter: Iter, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | crate::from_iter(iter.into_iter().filter_map(|(k, v)| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 333 | | if k.starts_with(self.0.as_ref()) { [INFO] [stdout] 334 | | Some((k.trim_start_matches(self.0.as_ref()).to_owned(), v)) [INFO] [stdout] 335 | | } else { [INFO] [stdout] 336 | | None [INFO] [stdout] 337 | | } [INFO] [stdout] 338 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:14 [INFO] [stdout] | [INFO] [stdout] 377 | #[derive(Deserialize, Debug, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `envy` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "4591a5117eef7da4a62989b34d9af643a25538e7cf0a2d91d7331f5495a5e4f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4591a5117eef7da4a62989b34d9af643a25538e7cf0a2d91d7331f5495a5e4f9", kill_on_drop: false }` [INFO] [stdout] 4591a5117eef7da4a62989b34d9af643a25538e7cf0a2d91d7331f5495a5e4f9