[INFO] fetching crate envuse-parser 0.9.1... [INFO] checking envuse-parser-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate envuse-parser 0.9.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate envuse-parser 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate envuse-parser 0.9.1 [INFO] finished tweaking crates.io crate envuse-parser 0.9.1 [INFO] tweaked toml for crates.io crate envuse-parser 0.9.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 65076886be2f4fb2797c03d522d243ec83f48e339b158372ad9ae614fc19de39 [INFO] running `Command { std: "docker" "start" "-a" "65076886be2f4fb2797c03d522d243ec83f48e339b158372ad9ae614fc19de39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "65076886be2f4fb2797c03d522d243ec83f48e339b158372ad9ae614fc19de39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65076886be2f4fb2797c03d522d243ec83f48e339b158372ad9ae614fc19de39", kill_on_drop: false }` [INFO] [stdout] 65076886be2f4fb2797c03d522d243ec83f48e339b158372ad9ae614fc19de39 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0623de985aded1e289a105671c58836c4167abb10d93920fa0247a84d8d0ffd [INFO] running `Command { std: "docker" "start" "-a" "a0623de985aded1e289a105671c58836c4167abb10d93920fa0247a84d8d0ffd", kill_on_drop: false }` [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking envuse-parser v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ptr::NonNull` [INFO] [stdout] --> src/envuse/to_custom_transformers.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{ptr::NonNull, vec}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `type_input` [INFO] [stdout] --> src/transformers/kinds/boolean_transform.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | fn parse(&self, type_input: String, input_value: String) -> ValueType { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_type_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `type_input` [INFO] [stdout] --> src/transformers/kinds/number_transform.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | fn parse(&self, type_input: String, input_value: String) -> ValueType { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_type_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `type_input` [INFO] [stdout] --> src/transformers/kinds/string_transform.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | fn parse(&self, type_input: String, input_value: String) -> ValueType { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_type_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `select_nexts`, `select_prev`, and `next` are never used [INFO] [stdout] --> src/parser/ast.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 97 | / impl Cursor [INFO] [stdout] 98 | | where [INFO] [stdout] 99 | | T: AsRef>, [INFO] [stdout] | |_________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 149 | fn select_nexts(&self, steps: usize) -> Option<&Token> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 153 | fn select_prev(&self) -> Option<&Token> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 157 | fn next(&mut self) -> Option<&Token> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `has_next` and `next_matches_char` are never used [INFO] [stdout] --> src/parser/tokenizer.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 29 | impl Cursor { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 89 | fn has_next<'a>(&'a self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 107 | fn next_matches_char(&self, val: char) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/envuse/program.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 27 | values: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | custom_transformers: D, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | self.parse_unwrap(values, custom_transformers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/envuse/to_envs.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 16 | fn to_envs(self) -> BTreeMap> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | BTreeMap::from(self.map(|t| (t.0.to_string(), t.1.to_optional_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn parse(payload: A) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let tokens = Tokenizer::parse(payload.to_string())?; [INFO] [stdout] 15 | Ok(AST::parse(tokens)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 185 | let elements = Self::parse_expressions_list(token_cursor)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | Ok(Expression::Document(Document { [INFO] [stdout] | ____________^ [INFO] [stdout] 192 | | executable, [INFO] [stdout] 193 | | elements, [INFO] [stdout] 194 | | span: Span { [INFO] [stdout] ... | [INFO] [stdout] 197 | | }, [INFO] [stdout] 198 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 273 | comment: Option, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let mut options_variable_type: Option>> = None; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | let mut default_value: Option = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | Ok(Expression::Variable(Variable { [INFO] [stdout] | ____________^ [INFO] [stdout] 346 | | span: Span { [INFO] [stdout] 347 | | start: span_start, [INFO] [stdout] 348 | | end: span_end, [INFO] [stdout] ... | [INFO] [stdout] 355 | | nullable, [INFO] [stdout] 356 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `envuse-parser` (lib) due to 6 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a0623de985aded1e289a105671c58836c4167abb10d93920fa0247a84d8d0ffd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0623de985aded1e289a105671c58836c4167abb10d93920fa0247a84d8d0ffd", kill_on_drop: false }` [INFO] [stdout] a0623de985aded1e289a105671c58836c4167abb10d93920fa0247a84d8d0ffd