[INFO] fetching crate environmental 1.1.4... [INFO] checking environmental-1.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate environmental 1.1.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate environmental 1.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate environmental 1.1.4 [INFO] finished tweaking crates.io crate environmental 1.1.4 [INFO] tweaked toml for crates.io crate environmental 1.1.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b91bf18a343f6ffbedf76411df84c757abb682060f47882228b453215a8f0c8 [INFO] running `Command { std: "docker" "start" "-a" "7b91bf18a343f6ffbedf76411df84c757abb682060f47882228b453215a8f0c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b91bf18a343f6ffbedf76411df84c757abb682060f47882228b453215a8f0c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b91bf18a343f6ffbedf76411df84c757abb682060f47882228b453215a8f0c8", kill_on_drop: false }` [INFO] [stdout] 7b91bf18a343f6ffbedf76411df84c757abb682060f47882228b453215a8f0c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6f5532bdc285acedfeac11bfb9ddd62d0a4021f4cfeca731feceb573e219f31 [INFO] running `Command { std: "docker" "start" "-a" "b6f5532bdc285acedfeac11bfb9ddd62d0a4021f4cfeca731feceb573e219f31", kill_on_drop: false }` [INFO] [stderr] Checking environmental v1.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 107 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | global.with(|r| { [INFO] [stdout] | _________________^ [INFO] [stdout] 116 | | // Push the new global to the end of the stack. [INFO] [stdout] 117 | | r.borrow_mut().push( [INFO] [stdout] 118 | | Rc::new(RefCell::new(protected as _)), [INFO] [stdout] ... | [INFO] [stdout] 124 | | f() [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:14 [INFO] [stdout] | [INFO] [stdout] 132 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | global.with(|r| { [INFO] [stdout] | _________________^ [INFO] [stdout] 141 | | // If there is already some state set, we want to use it. [INFO] [stdout] 142 | | if r.borrow().last().is_some() { [INFO] [stdout] 143 | | f() [INFO] [stdout] ... | [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:14 [INFO] [stdout] | [INFO] [stdout] 161 | mutator: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> Option { [INFO] [stdout] 163 | global.with(|r| { [INFO] [stdout] | _________________^ [INFO] [stdout] 164 | | // We always use the `last` element when we want to access the [INFO] [stdout] 165 | | // currently set global. [INFO] [stdout] 166 | | let last = r.borrow().last().cloned(); [INFO] [stdout] ... | [INFO] [stdout] 174 | | } [INFO] [stdout] 175 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `environmental` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 107 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | global.with(|r| { [INFO] [stdout] | _________________^ [INFO] [stdout] 116 | | // Push the new global to the end of the stack. [INFO] [stdout] 117 | | r.borrow_mut().push( [INFO] [stdout] 118 | | Rc::new(RefCell::new(protected as _)), [INFO] [stdout] ... | [INFO] [stdout] 124 | | f() [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:14 [INFO] [stdout] | [INFO] [stdout] 132 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | global.with(|r| { [INFO] [stdout] | _________________^ [INFO] [stdout] 141 | | // If there is already some state set, we want to use it. [INFO] [stdout] 142 | | if r.borrow().last().is_some() { [INFO] [stdout] 143 | | f() [INFO] [stdout] ... | [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:14 [INFO] [stdout] | [INFO] [stdout] 161 | mutator: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> Option { [INFO] [stdout] 163 | global.with(|r| { [INFO] [stdout] | _________________^ [INFO] [stdout] 164 | | // We always use the `last` element when we want to access the [INFO] [stdout] 165 | | // currently set global. [INFO] [stdout] 166 | | let last = r.borrow().last().cloned(); [INFO] [stdout] ... | [INFO] [stdout] 174 | | } [INFO] [stdout] 175 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 262 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | ) -> Option { [INFO] [stdout] 264 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 385 | environmental!(counter: u32); [INFO] [stdout] | ---------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 262 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | ) -> Option { [INFO] [stdout] 264 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 401 | environmental!(items: Vec); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 262 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | ) -> Option { [INFO] [stdout] 264 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 424 | environmental!(foo: dyn Foo + 'static); [INFO] [stdout] | -------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 262 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | ) -> Option { [INFO] [stdout] 264 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 447 | environmental!(items: Vec); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:302:27 [INFO] [stdout] | [INFO] [stdout] 300 | f: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | ) -> Option { [INFO] [stdout] 302 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 477 | environmental!(sum: trait Sum); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `$crate::environmental` which comes from the expansion of the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:302:27 [INFO] [stdout] | [INFO] [stdout] 300 | f: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | ) -> Option { [INFO] [stdout] 302 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 496 | environmental!(sum: trait Sum); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `$crate::environmental` which comes from the expansion of the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:27 [INFO] [stdout] | [INFO] [stdout] 342 | f: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | ) -> Option { [INFO] [stdout] 344 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 535 | environmental!(foo: trait Multiplier); [INFO] [stdout] | --------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 262 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | ) -> Option { [INFO] [stdout] 264 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 540 | environmental!(value: u32); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:302:27 [INFO] [stdout] | [INFO] [stdout] 300 | f: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | ) -> Option { [INFO] [stdout] 302 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 374 | environmental!(item_positon_trait: trait Test); [INFO] [stdout] | ---------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `$crate::environmental` which comes from the expansion of the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:27 [INFO] [stdout] | [INFO] [stdout] 262 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | ) -> Option { [INFO] [stdout] 264 | $crate::with(&GLOBAL, |x| f(x)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 380 | environmental!(item_position_type: u32); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `environmental` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `environmental` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "b6f5532bdc285acedfeac11bfb9ddd62d0a4021f4cfeca731feceb573e219f31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6f5532bdc285acedfeac11bfb9ddd62d0a4021f4cfeca731feceb573e219f31", kill_on_drop: false }` [INFO] [stdout] b6f5532bdc285acedfeac11bfb9ddd62d0a4021f4cfeca731feceb573e219f31