[INFO] fetching crate env-y 0.1.0... [INFO] checking env-y-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate env-y 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate env-y 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate env-y 0.1.0 [INFO] finished tweaking crates.io crate env-y 0.1.0 [INFO] tweaked toml for crates.io crate env-y 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate env-y 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11c7270f6698c20b6ec61ad873a07d9028a42ccbd3521f0e9f76c9659425f417 [INFO] running `Command { std: "docker" "start" "-a" "11c7270f6698c20b6ec61ad873a07d9028a42ccbd3521f0e9f76c9659425f417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11c7270f6698c20b6ec61ad873a07d9028a42ccbd3521f0e9f76c9659425f417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11c7270f6698c20b6ec61ad873a07d9028a42ccbd3521f0e9f76c9659425f417", kill_on_drop: false }` [INFO] [stdout] 11c7270f6698c20b6ec61ad873a07d9028a42ccbd3521f0e9f76c9659425f417 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c25a85665894617f767cb61c3c04fdadc9ae939b39c9e0cafeecf3ff6eec365 [INFO] running `Command { std: "docker" "start" "-a" "9c25a85665894617f767cb61c3c04fdadc9ae939b39c9e0cafeecf3ff6eec365", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling rustix v0.38.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling serde v1.0.171 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Compiling serde_json v1.0.100 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking combine v4.6.6 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking polyval v0.6.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking ghash v0.5.0 [INFO] [stderr] Checking aes v0.8.3 [INFO] [stderr] Checking aes-gcm v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking env-y v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/envy/crypt/encrypt.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 17 | let cipher = Aes256Gcm::new(&key); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | Ok(EnvEncrypt { cipher }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/envy/json.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | hashmap.insert(env.key().clone(), env.value().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/envy/json.rs:8:54 [INFO] [stdout] | [INFO] [stdout] 8 | hashmap.insert(env.key().clone(), env.value().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `env-y` (bin "envy") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/envy/crypt/encrypt.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 17 | let cipher = Aes256Gcm::new(&key); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | Ok(EnvEncrypt { cipher }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/envy/json.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | hashmap.insert(env.key().clone(), env.value().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/envy/json.rs:8:54 [INFO] [stdout] | [INFO] [stdout] 8 | hashmap.insert(env.key().clone(), env.value().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `env-y` (bin "envy" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9c25a85665894617f767cb61c3c04fdadc9ae939b39c9e0cafeecf3ff6eec365", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c25a85665894617f767cb61c3c04fdadc9ae939b39c9e0cafeecf3ff6eec365", kill_on_drop: false }` [INFO] [stdout] 9c25a85665894617f767cb61c3c04fdadc9ae939b39c9e0cafeecf3ff6eec365