[INFO] fetching crate enum_to_enum_derive 0.1.0... [INFO] checking enum_to_enum_derive-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate enum_to_enum_derive 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate enum_to_enum_derive 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate enum_to_enum_derive 0.1.0 [INFO] finished tweaking crates.io crate enum_to_enum_derive 0.1.0 [INFO] tweaked toml for crates.io crate enum_to_enum_derive 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0293ed4b57f1db0d757b9e58729778ea857b866488b4bbd97229e4790861ea3c [INFO] running `Command { std: "docker" "start" "-a" "0293ed4b57f1db0d757b9e58729778ea857b866488b4bbd97229e4790861ea3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0293ed4b57f1db0d757b9e58729778ea857b866488b4bbd97229e4790861ea3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0293ed4b57f1db0d757b9e58729778ea857b866488b4bbd97229e4790861ea3c", kill_on_drop: false }` [INFO] [stdout] 0293ed4b57f1db0d757b9e58729778ea857b866488b4bbd97229e4790861ea3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21a094eee795f3a1e5401ad8f0a55d15d1f93d4e382d7c7a1121c83100ecd851 [INFO] running `Command { std: "docker" "start" "-a" "21a094eee795f3a1e5401ad8f0a55d15d1f93d4e382d7c7a1121c83100ecd851", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking enum_to_enum_derive v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `src_case` is never read [INFO] [stdout] --> src/ir.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct ConversionCfg { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 8 | pub src_case: SrcCase, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConversionCfg` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fallible` is never read [INFO] [stdout] --> src/ir.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 114 | pub struct SrcCase { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 115 | pub case_name: Ident, [INFO] [stdout] 116 | pub fallible: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SrcCase` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 276 | let result_wrapper = |case_match: TokenStream2, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | let ret = if should_return { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | quote! { return } [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | / effect_holder_name [INFO] [stdout] 286 | | .map(|n| { [INFO] [stdout] 287 | | let chains = conversion_cfg.each_arg(|arg, _| { [INFO] [stdout] 288 | | let arg_effects = format_ident!("{}_effects", arg); [INFO] [stdout] ... | [INFO] [stdout] 304 | | } [INFO] [stdout] 305 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge_in.rs:10:52 [INFO] [stdout] | [INFO] [stdout] 10 | other.into_iter().for_each(|(k, vs)| match self.entry(k) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 33 | let conversion_cfgs_by_src_case_by_src = self.src_cases_by_src_by_dest.iter().fold( [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | / conversion_cfgs_by_src_case_by_src [INFO] [stdout] 67 | | .into_iter() [INFO] [stdout] 68 | | .map(|(src, conversion_cfgs_by_src_case)| { [INFO] [stdout] 69 | | ( [INFO] [stdout] ... | [INFO] [stdout] 80 | | ) [INFO] [stdout] 81 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|(src, conversion_cfgs_by_src_case)| { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | / conversion_cfgs_by_src_case [INFO] [stdout] 72 | | .into_iter() [INFO] [stdout] 73 | | .map(|(src_case, mut conversion_cfgs)| { [INFO] [stdout] 74 | | conversion_cfgs.sort_by_key(|cfg| { [INFO] [stdout] ... | [INFO] [stdout] 78 | | }) [INFO] [stdout] 79 | | .collect(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn parse(input: TokenStream2) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let mut parser = EnumParser::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let enm: ItemEnum = parse2(input)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Ok(ParsedEnum { [INFO] [stdout] | ____________^ [INFO] [stdout] 114 | | src_names: parser.src_names, [INFO] [stdout] 115 | | effect_holder_name: parser.effect_holder_name, [INFO] [stdout] 116 | | src_cases_by_src_by_dest: parser.src_cases_by_src_by_dest, [INFO] [stdout] 117 | | dest: enm.ident, [INFO] [stdout] 118 | | dest_case_order: parser.dest_case_order, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 368 | fn into_src_cases_by_src(self) -> SrcCasesBySrc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | / self.case_matches [INFO] [stdout] 370 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:371:19 [INFO] [stdout] | [INFO] [stdout] 368 | fn into_src_cases_by_src(self) -> SrcCasesBySrc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | .fold(HashMap::new(), |mut m, cm| { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:383:12 [INFO] [stdout] | [INFO] [stdout] 380 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | parenthesized!(content in input); [INFO] [stdout] 382 | let case_matches = Punctuated::::parse_terminated(&content)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | Ok(FromCaseAttr { [INFO] [stdout] | ____________^ [INFO] [stdout] 384 | | case_matches: case_matches.into_iter().collect(), [INFO] [stdout] 385 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `enum_to_enum_derive` (lib) due to 9 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "21a094eee795f3a1e5401ad8f0a55d15d1f93d4e382d7c7a1121c83100ecd851", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21a094eee795f3a1e5401ad8f0a55d15d1f93d4e382d7c7a1121c83100ecd851", kill_on_drop: false }` [INFO] [stdout] 21a094eee795f3a1e5401ad8f0a55d15d1f93d4e382d7c7a1121c83100ecd851