[INFO] fetching crate engine_io_server 0.1.0... [INFO] checking engine_io_server-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate engine_io_server 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate engine_io_server 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate engine_io_server 0.1.0 [INFO] finished tweaking crates.io crate engine_io_server 0.1.0 [INFO] tweaked toml for crates.io crate engine_io_server 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding strum v0.18.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.18.0 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 802b8ddda1504363c1ebafa820e5864ef4a0904391f56e7084e8562aa2418fdf [INFO] running `Command { std: "docker" "start" "-a" "802b8ddda1504363c1ebafa820e5864ef4a0904391f56e7084e8562aa2418fdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "802b8ddda1504363c1ebafa820e5864ef4a0904391f56e7084e8562aa2418fdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "802b8ddda1504363c1ebafa820e5864ef4a0904391f56e7084e8562aa2418fdf", kill_on_drop: false }` [INFO] [stdout] 802b8ddda1504363c1ebafa820e5864ef4a0904391f56e7084e8562aa2418fdf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c7efefdff6fc4fec7028eb7e4c8b2f171dce027d6e2c4acd6f8f661a0ce425fa [INFO] running `Command { std: "docker" "start" "-a" "c7efefdff6fc4fec7028eb7e4c8b2f171dce027d6e2c4acd6f8f661a0ce425fa", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking strum v0.18.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking engine_io_parser v0.2.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking engine_io_server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `reason` [INFO] [stdout] --> src/socket.rs:363:34 [INFO] [stdout] | [INFO] [stdout] 363 | async fn on_close(&mut self, reason: SocketError, description: &str) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reason` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `description` [INFO] [stdout] --> src/socket.rs:363:55 [INFO] [stdout] | [INFO] [stdout] 363 | async fn on_close(&mut self, reason: SocketError, description: &str) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_description` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reason` [INFO] [stdout] --> src/socket.rs:363:34 [INFO] [stdout] | [INFO] [stdout] 363 | async fn on_close(&mut self, reason: SocketError, description: &str) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reason` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `description` [INFO] [stdout] --> src/socket.rs:363:55 [INFO] [stdout] | [INFO] [stdout] 363 | async fn on_close(&mut self, reason: SocketError, description: &str) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_description` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/socket.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let mut holder = TransportHolder { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/socket.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let mut holder = TransportHolder { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `remote_address` is never read [INFO] [stdout] --> src/socket.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Socket { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | remote_address: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `transport_event_sender` is never read [INFO] [stdout] --> src/socket.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 43 | struct TransportHolder { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 44 | transport: Transport, [INFO] [stdout] 45 | transport_event_sender: mpsc::Sender, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(options: ServerOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | // To listen events from socket instances [INFO] [stdout] 113 | let (client_event_sender, _) = mpsc::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | // To send events to the owner of this Server instance [INFO] [stdout] 115 | let (server_event_sender, _) = broadcast::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | state: Arc::new(AsyncRwLock::new(ServerState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 119 | | socket_receiver_temp: None, [INFO] [stdout] 120 | | clients: HashMap::new(), [INFO] [stdout] 121 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:122:28 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(options: ServerOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | // To listen events from socket instances [INFO] [stdout] 113 | let (client_event_sender, _) = mpsc::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | // To send events to the owner of this Server instance [INFO] [stdout] 115 | let (server_event_sender, _) = broadcast::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | event_senders: EventSenders { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 123 | | server: server_event_sender, [INFO] [stdout] 124 | | client: client_event_sender, [INFO] [stdout] 125 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:90:31 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | transport_holder: TransportHolder::new( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 91 | | transport, [INFO] [stdout] 92 | | transport_event_sender, [INFO] [stdout] 93 | | transport_event_receiver, [INFO] [stdout] 94 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | write_buffer: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:98:32 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | pending_callbacks: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | flushed_callbacks: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `remote_address` is never read [INFO] [stdout] --> src/socket.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Socket { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | remote_address: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `transport_event_sender` is never read [INFO] [stdout] --> src/socket.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 43 | struct TransportHolder { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 44 | transport: Transport, [INFO] [stdout] 45 | transport_event_sender: mpsc::Sender, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(options: ServerOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | // To listen events from socket instances [INFO] [stdout] 113 | let (client_event_sender, _) = mpsc::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | // To send events to the owner of this Server instance [INFO] [stdout] 115 | let (server_event_sender, _) = broadcast::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | state: Arc::new(AsyncRwLock::new(ServerState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 119 | | socket_receiver_temp: None, [INFO] [stdout] 120 | | clients: HashMap::new(), [INFO] [stdout] 121 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:122:28 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(options: ServerOptions) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | // To listen events from socket instances [INFO] [stdout] 113 | let (client_event_sender, _) = mpsc::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | // To send events to the owner of this Server instance [INFO] [stdout] 115 | let (server_event_sender, _) = broadcast::channel(options.buffer_factor * BUFFER_CONST); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | event_senders: EventSenders { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 123 | | server: server_event_sender, [INFO] [stdout] 124 | | client: client_event_sender, [INFO] [stdout] 125 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:90:31 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | transport_holder: TransportHolder::new( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 91 | | transport, [INFO] [stdout] 92 | | transport_event_sender, [INFO] [stdout] 93 | | transport_event_receiver, [INFO] [stdout] 94 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | write_buffer: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:98:32 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | pending_callbacks: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 78 | event_sender: mpsc::Sender, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (transport, transport_event_sender, transport_event_receiver) = [INFO] [stdout] | --------- ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | flushed_callbacks: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/socket.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | / self.event_sender [INFO] [stdout] 173 | | .send(SocketEvent::Open { [INFO] [stdout] 174 | | socket_id: self.id.clone(), [INFO] [stdout] 175 | | }) [INFO] [stdout] 176 | | .await; [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 172 | let _ = self.event_sender [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused pinned boxed `std::future::Future` trait object that must be used [INFO] [stdout] --> src/socket.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | self.transport_holder.transport.close(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: futures do nothing unless you `.await` or poll them [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `TransportImpl::close` that must be used [INFO] [stdout] --> src/socket.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | self.transport_holder.transport.close(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 187 | let _ = self.transport_holder.transport.close(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/socket.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | / self.event_sender [INFO] [stdout] 285 | | .send(SocketEvent::Flush { [INFO] [stdout] 286 | | socket_id: id.clone(), [INFO] [stdout] 287 | | }) [INFO] [stdout] 288 | | .await; [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 284 | let _ = self.event_sender [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:179:52 [INFO] [stdout] | [INFO] [stdout] 179 | async fn send(&mut self, packets: Vec) { [INFO] [stdout] | ______________________________--------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | | match self { [INFO] [stdout] 181 | | Transport::WebSocket(transport) => transport.send(packets).await, [INFO] [stdout] 182 | | Transport::Polling(transport) => transport.send(packets).await, [INFO] [stdout] 183 | | } [INFO] [stdout] 184 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/socket.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | / self.event_sender [INFO] [stdout] 173 | | .send(SocketEvent::Open { [INFO] [stdout] 174 | | socket_id: self.id.clone(), [INFO] [stdout] 175 | | }) [INFO] [stdout] 176 | | .await; [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 172 | let _ = self.event_sender [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused pinned boxed `std::future::Future` trait object that must be used [INFO] [stdout] --> src/socket.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | self.transport_holder.transport.close(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: futures do nothing unless you `.await` or poll them [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `TransportImpl::close` that must be used [INFO] [stdout] --> src/socket.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | self.transport_holder.transport.close(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 187 | let _ = self.transport_holder.transport.close(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/socket.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | / self.event_sender [INFO] [stdout] 285 | | .send(SocketEvent::Flush { [INFO] [stdout] 286 | | socket_id: id.clone(), [INFO] [stdout] 287 | | }) [INFO] [stdout] 288 | | .await; [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 284 | let _ = self.event_sender [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:179:52 [INFO] [stdout] | [INFO] [stdout] 179 | async fn send(&mut self, packets: Vec) { [INFO] [stdout] | ______________________________--------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | | match self { [INFO] [stdout] 181 | | Transport::WebSocket(transport) => transport.send(packets).await, [INFO] [stdout] 182 | | Transport::Polling(transport) => transport.send(packets).await, [INFO] [stdout] 183 | | } [INFO] [stdout] 184 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `engine_io_server` (lib test) due to 8 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `engine_io_server` (lib) due to 8 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c7efefdff6fc4fec7028eb7e4c8b2f171dce027d6e2c4acd6f8f661a0ce425fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7efefdff6fc4fec7028eb7e4c8b2f171dce027d6e2c4acd6f8f661a0ce425fa", kill_on_drop: false }` [INFO] [stdout] c7efefdff6fc4fec7028eb7e4c8b2f171dce027d6e2c4acd6f8f661a0ce425fa