[INFO] fetching crate encoding_derive_helpers 0.9.0... [INFO] checking encoding_derive_helpers-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate encoding_derive_helpers 0.9.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate encoding_derive_helpers 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate encoding_derive_helpers 0.9.0 [INFO] finished tweaking crates.io crate encoding_derive_helpers 0.9.0 [INFO] tweaked toml for crates.io crate encoding_derive_helpers 0.9.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding amplify v3.14.2 (latest: v4.7.0) [INFO] [stderr] Adding amplify_derive v2.11.3 (latest: v4.0.1) [INFO] [stderr] Adding amplify_num v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding amplify_syn v1.1.6 (latest: v2.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e20cb6983ea87c565fb6dcbe854c5e6a18c16325f519d039e26413790c239be8 [INFO] running `Command { std: "docker" "start" "-a" "e20cb6983ea87c565fb6dcbe854c5e6a18c16325f519d039e26413790c239be8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e20cb6983ea87c565fb6dcbe854c5e6a18c16325f519d039e26413790c239be8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e20cb6983ea87c565fb6dcbe854c5e6a18c16325f519d039e26413790c239be8", kill_on_drop: false }` [INFO] [stdout] e20cb6983ea87c565fb6dcbe854c5e6a18c16325f519d039e26413790c239be8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42d2baf8aafbc45dec17a0b3ad46bfff590863f18a1be80629acd0b1e815598f [INFO] running `Command { std: "docker" "start" "-a" "42d2baf8aafbc45dec17a0b3ad46bfff590863f18a1be80629acd0b1e815598f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking amplify_num v0.4.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking amplify_syn v1.1.6 [INFO] [stderr] Compiling amplify_derive v2.11.3 [INFO] [stderr] Checking amplify v3.14.2 [INFO] [stderr] Checking encoding_derive_helpers v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/param.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 67 | let mut map = if is_global { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / map! { [INFO] [stdout] 69 | | CRATE => ArgValueReq::with_default(crate_name.clone()), [INFO] [stdout] 70 | | USE_TLV => ArgValueReq::with_default(true) [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | } else { [INFO] [stdout] 73 | / map! { [INFO] [stdout] 74 | | SKIP => ArgValueReq::Prohibited, [INFO] [stdout] 75 | | TLV => ArgValueReq::Optional(ValueClass::Literal(LiteralClass::Int)), [INFO] [stdout] 76 | | UNKNOWN_TLVS => ArgValueReq::with_default(true) [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let repr: Ident = attr [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let use_crate = attr [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let value = attr [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Ok(EncodingDerive { [INFO] [stdout] | ____________^ [INFO] [stdout] 151 | | use_crate, [INFO] [stdout] 152 | | skip, [INFO] [stdout] 153 | | by_order, [INFO] [stdout] ... | [INFO] [stdout] 156 | | tlv, [INFO] [stdout] 157 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/param.rs:132:47 [INFO] [stdout] | [INFO] [stdout] 132 | .unwrap_or_else(|| ArgValue::from(crate_name.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `encoding_derive_helpers` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/param.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 67 | let mut map = if is_global { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / map! { [INFO] [stdout] 69 | | CRATE => ArgValueReq::with_default(crate_name.clone()), [INFO] [stdout] 70 | | USE_TLV => ArgValueReq::with_default(true) [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | } else { [INFO] [stdout] 73 | / map! { [INFO] [stdout] 74 | | SKIP => ArgValueReq::Prohibited, [INFO] [stdout] 75 | | TLV => ArgValueReq::Optional(ValueClass::Literal(LiteralClass::Int)), [INFO] [stdout] 76 | | UNKNOWN_TLVS => ArgValueReq::with_default(true) [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let repr: Ident = attr [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let use_crate = attr [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let value = attr [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Ok(EncodingDerive { [INFO] [stdout] | ____________^ [INFO] [stdout] 151 | | use_crate, [INFO] [stdout] 152 | | skip, [INFO] [stdout] 153 | | by_order, [INFO] [stdout] ... | [INFO] [stdout] 156 | | tlv, [INFO] [stdout] 157 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/param.rs:132:47 [INFO] [stdout] | [INFO] [stdout] 132 | .unwrap_or_else(|| ArgValue::from(crate_name.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `encoding_derive_helpers` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "42d2baf8aafbc45dec17a0b3ad46bfff590863f18a1be80629acd0b1e815598f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42d2baf8aafbc45dec17a0b3ad46bfff590863f18a1be80629acd0b1e815598f", kill_on_drop: false }` [INFO] [stdout] 42d2baf8aafbc45dec17a0b3ad46bfff590863f18a1be80629acd0b1e815598f