[INFO] fetching crate emuman 2.10.1... [INFO] checking emuman-2.10.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate emuman 2.10.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate emuman 2.10.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate emuman 2.10.1 [INFO] finished tweaking crates.io crate emuman 2.10.1 [INFO] tweaked toml for crates.io crate emuman 2.10.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate emuman 2.10.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 074c77f61acc24e6c6bd2fba241d32b36cf824bd5005c62b17168cdacb845288 [INFO] running `Command { std: "docker" "start" "-a" "074c77f61acc24e6c6bd2fba241d32b36cf824bd5005c62b17168cdacb845288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "074c77f61acc24e6c6bd2fba241d32b36cf824bd5005c62b17168cdacb845288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "074c77f61acc24e6c6bd2fba241d32b36cf824bd5005c62b17168cdacb845288", kill_on_drop: false }` [INFO] [stdout] 074c77f61acc24e6c6bd2fba241d32b36cf824bd5005c62b17168cdacb845288 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd4cf66c00d3be57c1ba8a6c8277b1e81c7e1241e5ebb1f3b4bc0024e4d4ae4f [INFO] running `Command { std: "docker" "start" "-a" "dd4cf66c00d3be57c1ba8a6c8277b1e81c7e1241e5ebb1f3b4bc0024e4d4ae4f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking winnow v0.6.6 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking nt-time v0.6.10 [INFO] [stderr] Checking filetime_creation v0.2.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking zopfli v0.8.0 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking lzma-rust v0.1.6 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking deflate64 v0.1.8 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Checking iter-group v0.2.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking nohash v0.2.0 [INFO] [stderr] Checking filesize v0.2.0 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking bitstream-io v2.2.0 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking sevenz-rust v0.6.0 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling libz-ng-sys v1.1.15 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking zip v1.1.1 [INFO] [stderr] Checking attohttpc v0.28.0 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking emuman v2.10.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `unix` [INFO] [stdout] --> src/game.rs:1189:11 [INFO] [stdout] | [INFO] [stdout] 1189 | #[cfg(target_os = "unix")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, `vxworks`, and `wasi` and 4 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `unix` [INFO] [stdout] --> src/game.rs:1189:11 [INFO] [stdout] | [INFO] [stdout] 1189 | #[cfg(target_os = "unix")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, `vxworks`, and `wasi` and 4 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `part`, and `path` are never read [INFO] [stdout] --> src/game.rs:787:9 [INFO] [stdout] | [INFO] [stdout] 786 | pub struct VerifySuccess<'s> { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 787 | pub name: &'s str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 788 | pub part: &'s Part, [INFO] [stdout] | ^^^^ [INFO] [stdout] 789 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VerifySuccess` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `part` are never read [INFO] [stdout] --> src/game.rs:806:9 [INFO] [stdout] | [INFO] [stdout] 803 | Rename { [INFO] [stdout] | ------ fields in this variant [INFO] [stdout] ... [INFO] [stdout] 806 | name: &'s str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 807 | part: &'s Part, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VerifyFailure` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `extend_many` is never used [INFO] [stdout] --> src/game.rs:1035:8 [INFO] [stdout] | [INFO] [stdout] 1031 | pub trait ExtendOne: Extend { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 1035 | fn extend_many(&mut self, iter: T) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:157:47 [INFO] [stdout] | [INFO] [stdout] 157 | .map(|data| ResourceFile::Url(std::io::Cursor::new(data))), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 244 | let mut f = resource.open()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | / quick_xml::de::from_str(&xml_data) [INFO] [stdout] 263 | | .map_err(Error::Xml) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:377:29 [INFO] [stdout] | [INFO] [stdout] 377 | .filter_map(|e| e.ok().and_then(|e| e.file_name().into_string().ok())) [INFO] [stdout] | - ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:507:40 [INFO] [stdout] | [INFO] [stdout] 506 | .map_err(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | Error::XmlFile(ResourceError { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 508 | | error, [INFO] [stdout] 509 | | file: Resource::File(file), [INFO] [stdout] 510 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:705:29 [INFO] [stdout] | [INFO] [stdout] 705 | .filter_map(|e| e.ok().and_then(|e| e.file_name().into_string().ok())) [INFO] [stdout] | - ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1138:49 [INFO] [stdout] | [INFO] [stdout] 1138 | |datfile, dir, pbar| Ok::<_, Never>(datfile.verify(dir, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1198:13 [INFO] [stdout] | [INFO] [stdout] 1194 | let mut parts = rom_sources(&self.input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1198 | dirs::extra_dirs(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1502:49 [INFO] [stdout] | [INFO] [stdout] 1502 | |datfile, dir, pbar| Ok::<_, Never>(datfile.verify(dir, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1562:13 [INFO] [stdout] | [INFO] [stdout] 1558 | let mut parts = rom_sources(&self.input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1562 | dirs::redump_dirs(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1952:49 [INFO] [stdout] | [INFO] [stdout] 1952 | |datfile, dir, pbar| Ok::<_, Never>(datfile.verify(dir, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2012:13 [INFO] [stdout] | [INFO] [stdout] 2008 | let mut parts = rom_sources(&self.input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2012 | dirs::nointro_dirs(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2150:44 [INFO] [stdout] | [INFO] [stdout] 2150 | |datfile, pbar| Ok::<_, Never>(datfile.verify(&self.roms, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2384:43 [INFO] [stdout] | [INFO] [stdout] 2384 | .filter(|pb| matches!(Part::has_xattr(pb), Ok(false))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2397:45 [INFO] [stdout] | [INFO] [stdout] 2397 | .for_each(|file: PathBuf| match Part::from_path(&file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2424:39 [INFO] [stdout] | [INFO] [stdout] 2424 | .filter(|pb| matches!(Part::has_xattr(pb), Ok(true))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2474:44 [INFO] [stdout] | [INFO] [stdout] 2474 | .for_each(|(file, part)| match part.is_valid(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2628:5 [INFO] [stdout] | [INFO] [stdout] 2624 | let f = BufReader::new( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2628 | ciborium::de::from_reader(f).map_err(|_| Error::InvalidCache(utility)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2682:20 [INFO] [stdout] | [INFO] [stdout] 2682 | .map(|dir| dir.filter_map(|e| e.map(|e| e.path()).ok()).collect()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2682:39 [INFO] [stdout] | [INFO] [stdout] 2682 | .map(|dir| dir.filter_map(|e| e.map(|e| e.path()).ok()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2711:31 [INFO] [stdout] | [INFO] [stdout] 2711 | .and_then(|f| ciborium::de::from_reader(f).ok())?, [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2717:13 [INFO] [stdout] | [INFO] [stdout] 2716 | Ok(dir) => Some(dir.filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2717 | / entry [INFO] [stdout] 2718 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2729:13 [INFO] [stdout] | [INFO] [stdout] 2728 | Ok(dir) => Some(dir.filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2729 | / entry [INFO] [stdout] 2730 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2925:36 [INFO] [stdout] | [INFO] [stdout] 2925 | .and_then(|()| std::fs::remove_file(old_config_name).map_err(Error::IO))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:419:12 [INFO] [stdout] | [INFO] [stdout] 358 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | / handle_failure: impl Fn(VerifyFailure) -> Result, VerifyFailure>, E> [INFO] [stdout] 360 | | + Send [INFO] [stdout] 361 | | + Sync, [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | files, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | dirs, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | mut failures, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 389 | let failures = Mutex::new(failures); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | let mut failures = failures.into_inner().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | Ok(VerifyResults { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 420 | | failures, [INFO] [stdout] 421 | | summary: crate::game::VerifyResultsSummary { [INFO] [stdout] 422 | | successes, [INFO] [stdout] 423 | | total: self.flat.len() + self.tree.len(), [INFO] [stdout] 424 | | }, [INFO] [stdout] 425 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:445:42 [INFO] [stdout] | [INFO] [stdout] 445 | |failure| Ok::<_, Never>(Err(failure)), [INFO] [stdout] | ------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:461:29 [INFO] [stdout] | [INFO] [stdout] 461 | |failure| match failure.try_fix(roms) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:553:15 [INFO] [stdout] | [INFO] [stdout] 551 | let mut f = resource.open()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 552 | [INFO] [stdout] 553 | match is_zip(&mut f) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn valid_games<'g, I, C>(&'g self, games: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / games [INFO] [stdout] 84 | | .into_iter() [INFO] [stdout] 85 | | .map(|name| self.valid_game(name.as_ref())) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn games(&self, games: I, simple: bool) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | &games [INFO] [stdout] | ______________^ [INFO] [stdout] 128 | | .into_iter() [INFO] [stdout] 129 | | .filter_map(|g| self.game(g.as_ref()).map(|g| g.report(simple))) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:442:23 [INFO] [stdout] | [INFO] [stdout] 442 | .map(|pb| FileSize::new(&pb).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:491:12 [INFO] [stdout] | [INFO] [stdout] 462 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | / handle_failure: impl Fn(VerifyFailure) -> Result, VerifyFailure>, E> [INFO] [stdout] 464 | | + Send [INFO] [stdout] 465 | | + Sync, [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 473 | files, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | dirs, [INFO] [stdout] 475 | mut failures, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let successes = self.process( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | Ok((successes, failures)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:643:12 [INFO] [stdout] | [INFO] [stdout] 501 | files: DashMap, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 502 | failures: &mut F, [INFO] [stdout] 503 | missing_path: impl Fn(&str) -> PathBuf + Send + Sync, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 504 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 505 | / handle_failure: impl Fn(VerifyFailure) -> Result, VerifyFailure>, E> [INFO] [stdout] 506 | | + Send [INFO] [stdout] 507 | | + Sync, [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | let successes = Mutex::new(S::default()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 556 | let extras = PartMap::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | Ok(successes.into_inner().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:631:19 [INFO] [stdout] | [INFO] [stdout] 631 | part: Ok(part), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:656:9 [INFO] [stdout] | [INFO] [stdout] 650 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 656 | / self.process_parts(game_root, increment_progress, |failure| { [INFO] [stdout] 657 | | Ok::<_, Never>(Err(failure)) [INFO] [stdout] 658 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:657:28 [INFO] [stdout] | [INFO] [stdout] 656 | self.process_parts(game_root, increment_progress, |failure| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 657 | Ok::<_, Never>(Err(failure)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:690:13 [INFO] [stdout] | [INFO] [stdout] 689 | self.process_parts(game_root, increment_progress, |failure| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | failure.try_fix(rom_sources).map(|r| r.map(handle_repair)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:752:9 [INFO] [stdout] | [INFO] [stdout] 748 | fn sum(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 752 | iter.into_iter().fold(Self::default(), |acc, x| acc + x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1264:15 [INFO] [stdout] | [INFO] [stdout] 1264 | match map.get(&file_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1377:15 [INFO] [stdout] | [INFO] [stdout] 1373 | fn from_reader(r: R) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1376 | let mut r = Sha1Reader::new(r); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1377 | match Part::disk_from_reader(&mut r) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1556:9 [INFO] [stdout] | [INFO] [stdout] 1551 | fn extract_to_buf(&self, i: R) -> Result>, Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1556 | self.extract(i, &mut buf).map(|_| std::io::Cursor::new(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1630:12 [INFO] [stdout] | [INFO] [stdout] 1627 | let file = Arc::from(pb); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1628 | let mut r = File::open(&file).map(BufReader::new)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1629 | [INFO] [stdout] 1630 | Ok(if is_zip(&mut r).unwrap_or(false) { [INFO] [stdout] | ____________^ [INFO] [stdout] 1631 | | unpack_zip_parts(r, File::open(&file).map(BufReader::new)?) [INFO] [stdout] 1632 | | .into_iter() [INFO] [stdout] 1633 | | .map(|(part, zip_parts)| { [INFO] [stdout] ... | [INFO] [stdout] 1652 | | )] [INFO] [stdout] 1653 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1703:25 [INFO] [stdout] | [INFO] [stdout] 1702 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1703 | / Rate::from_copy(|| copy(source, target)) [INFO] [stdout] 1704 | | .map(|rate| Extracted::Copied { rate }) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1710:51 [INFO] [stdout] | [INFO] [stdout] 1710 | .and_then(|w| Rate::from_copy(|| c.extract(File::open(source.as_ref())?, w))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1710:64 [INFO] [stdout] | [INFO] [stdout] 1710 | .and_then(|w| Rate::from_copy(|| c.extract(File::open(source.as_ref())?, w))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1763:43 [INFO] [stdout] | [INFO] [stdout] 1752 | mut r: R, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1763 | .and_then(|w| Rate::from_copy(|| c.extract(r, w))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1782:19 [INFO] [stdout] | [INFO] [stdout] 1780 | fn is_zip(mut reader: R) -> bool { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1781 | let mut buf = [0; 4]; [INFO] [stdout] 1782 | match reader.read_exact(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1817:12 [INFO] [stdout] | [INFO] [stdout] 1817 | || unpack(&mut zip).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1906:9 [INFO] [stdout] | [INFO] [stdout] 1902 | let mut seen = IntSet::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1906 | / ProgressBar::new_spinner() [INFO] [stdout] 1907 | | .with_style(find_files_style()) [INFO] [stdout] 1908 | | .with_message("locating files"), [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1910:13 [INFO] [stdout] | [INFO] [stdout] 1909 | |pbar| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1910 | / walkdir::WalkDir::new(root) [INFO] [stdout] 1911 | | .into_iter() [INFO] [stdout] 1912 | | .filter_map(|e| e.ok()) [INFO] [stdout] 1913 | | .filter(|e| { [INFO] [stdout] ... | [INFO] [stdout] 1922 | | .progress_with(pbar) [INFO] [stdout] 1923 | | .flat_map(|pb| RomSource::from_path(pb).unwrap_or_default().into_par_iter()) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1923:32 [INFO] [stdout] | [INFO] [stdout] 1923 | .flat_map(|pb| RomSource::from_path(pb).unwrap_or_default().into_par_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1932:18 [INFO] [stdout] | [INFO] [stdout] 1932 | .map(|v| v.into_iter().collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 30 | fn fetch(source: &str, add_bar: A, remove_bar: R, zip_data: &mut Vec) -> Result<(), Error> [INFO] [stdout] | ---------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let builder = if zip_data.is_empty() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | match builder.send()?.split() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 52 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `part`, and `path` are never read [INFO] [stdout] --> src/game.rs:787:9 [INFO] [stdout] | [INFO] [stdout] 786 | pub struct VerifySuccess<'s> { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 787 | pub name: &'s str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 788 | pub part: &'s Part, [INFO] [stdout] | ^^^^ [INFO] [stdout] 789 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VerifySuccess` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `part` are never read [INFO] [stdout] --> src/game.rs:806:9 [INFO] [stdout] | [INFO] [stdout] 803 | Rename { [INFO] [stdout] | ------ fields in this variant [INFO] [stdout] ... [INFO] [stdout] 806 | name: &'s str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 807 | part: &'s Part, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VerifyFailure` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `extend_many` is never used [INFO] [stdout] --> src/game.rs:1035:8 [INFO] [stdout] | [INFO] [stdout] 1031 | pub trait ExtendOne: Extend { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 1035 | fn extend_many(&mut self, iter: T) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:157:47 [INFO] [stdout] | [INFO] [stdout] 157 | .map(|data| ResourceFile::Url(std::io::Cursor::new(data))), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 244 | let mut f = resource.open()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | / quick_xml::de::from_str(&xml_data) [INFO] [stdout] 263 | | .map_err(Error::Xml) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `emuman` (bin "emuman" test) due to 53 previous errors; 4 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:377:29 [INFO] [stdout] | [INFO] [stdout] 377 | .filter_map(|e| e.ok().and_then(|e| e.file_name().into_string().ok())) [INFO] [stdout] | - ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:507:40 [INFO] [stdout] | [INFO] [stdout] 506 | .map_err(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | Error::XmlFile(ResourceError { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 508 | | error, [INFO] [stdout] 509 | | file: Resource::File(file), [INFO] [stdout] 510 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:705:29 [INFO] [stdout] | [INFO] [stdout] 705 | .filter_map(|e| e.ok().and_then(|e| e.file_name().into_string().ok())) [INFO] [stdout] | - ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1138:49 [INFO] [stdout] | [INFO] [stdout] 1138 | |datfile, dir, pbar| Ok::<_, Never>(datfile.verify(dir, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1198:13 [INFO] [stdout] | [INFO] [stdout] 1194 | let mut parts = rom_sources(&self.input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1198 | dirs::extra_dirs(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1502:49 [INFO] [stdout] | [INFO] [stdout] 1502 | |datfile, dir, pbar| Ok::<_, Never>(datfile.verify(dir, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1562:13 [INFO] [stdout] | [INFO] [stdout] 1558 | let mut parts = rom_sources(&self.input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1562 | dirs::redump_dirs(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1952:49 [INFO] [stdout] | [INFO] [stdout] 1952 | |datfile, dir, pbar| Ok::<_, Never>(datfile.verify(dir, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2012:13 [INFO] [stdout] | [INFO] [stdout] 2008 | let mut parts = rom_sources(&self.input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2012 | dirs::nointro_dirs(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2150:44 [INFO] [stdout] | [INFO] [stdout] 2150 | |datfile, pbar| Ok::<_, Never>(datfile.verify(&self.roms, pbar)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2384:43 [INFO] [stdout] | [INFO] [stdout] 2384 | .filter(|pb| matches!(Part::has_xattr(pb), Ok(false))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2397:45 [INFO] [stdout] | [INFO] [stdout] 2397 | .for_each(|file: PathBuf| match Part::from_path(&file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2424:39 [INFO] [stdout] | [INFO] [stdout] 2424 | .filter(|pb| matches!(Part::has_xattr(pb), Ok(true))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2474:44 [INFO] [stdout] | [INFO] [stdout] 2474 | .for_each(|(file, part)| match part.is_valid(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2628:5 [INFO] [stdout] | [INFO] [stdout] 2624 | let f = BufReader::new( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2628 | ciborium::de::from_reader(f).map_err(|_| Error::InvalidCache(utility)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2682:20 [INFO] [stdout] | [INFO] [stdout] 2682 | .map(|dir| dir.filter_map(|e| e.map(|e| e.path()).ok()).collect()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2682:39 [INFO] [stdout] | [INFO] [stdout] 2682 | .map(|dir| dir.filter_map(|e| e.map(|e| e.path()).ok()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2711:31 [INFO] [stdout] | [INFO] [stdout] 2711 | .and_then(|f| ciborium::de::from_reader(f).ok())?, [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2717:13 [INFO] [stdout] | [INFO] [stdout] 2716 | Ok(dir) => Some(dir.filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2717 | / entry [INFO] [stdout] 2718 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2729:13 [INFO] [stdout] | [INFO] [stdout] 2728 | Ok(dir) => Some(dir.filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2729 | / entry [INFO] [stdout] 2730 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:2925:36 [INFO] [stdout] | [INFO] [stdout] 2925 | .and_then(|()| std::fs::remove_file(old_config_name).map_err(Error::IO))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:419:12 [INFO] [stdout] | [INFO] [stdout] 358 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | / handle_failure: impl Fn(VerifyFailure) -> Result, VerifyFailure>, E> [INFO] [stdout] 360 | | + Send [INFO] [stdout] 361 | | + Sync, [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | files, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | dirs, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | mut failures, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 389 | let failures = Mutex::new(failures); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | let mut failures = failures.into_inner().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | Ok(VerifyResults { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 420 | | failures, [INFO] [stdout] 421 | | summary: crate::game::VerifyResultsSummary { [INFO] [stdout] 422 | | successes, [INFO] [stdout] 423 | | total: self.flat.len() + self.tree.len(), [INFO] [stdout] 424 | | }, [INFO] [stdout] 425 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:445:42 [INFO] [stdout] | [INFO] [stdout] 445 | |failure| Ok::<_, Never>(Err(failure)), [INFO] [stdout] | ------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:461:29 [INFO] [stdout] | [INFO] [stdout] 461 | |failure| match failure.try_fix(roms) { [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dat.rs:553:15 [INFO] [stdout] | [INFO] [stdout] 551 | let mut f = resource.open()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 552 | [INFO] [stdout] 553 | match is_zip(&mut f) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn valid_games<'g, I, C>(&'g self, games: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / games [INFO] [stdout] 84 | | .into_iter() [INFO] [stdout] 85 | | .map(|name| self.valid_game(name.as_ref())) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn games(&self, games: I, simple: bool) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | &games [INFO] [stdout] | ______________^ [INFO] [stdout] 128 | | .into_iter() [INFO] [stdout] 129 | | .filter_map(|g| self.game(g.as_ref()).map(|g| g.report(simple))) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:442:23 [INFO] [stdout] | [INFO] [stdout] 442 | .map(|pb| FileSize::new(&pb).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:491:12 [INFO] [stdout] | [INFO] [stdout] 462 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | / handle_failure: impl Fn(VerifyFailure) -> Result, VerifyFailure>, E> [INFO] [stdout] 464 | | + Send [INFO] [stdout] 465 | | + Sync, [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 473 | files, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | dirs, [INFO] [stdout] 475 | mut failures, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let successes = self.process( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | Ok((successes, failures)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:643:12 [INFO] [stdout] | [INFO] [stdout] 501 | files: DashMap, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 502 | failures: &mut F, [INFO] [stdout] 503 | missing_path: impl Fn(&str) -> PathBuf + Send + Sync, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 504 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 505 | / handle_failure: impl Fn(VerifyFailure) -> Result, VerifyFailure>, E> [INFO] [stdout] 506 | | + Send [INFO] [stdout] 507 | | + Sync, [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | let successes = Mutex::new(S::default()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 556 | let extras = PartMap::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | Ok(successes.into_inner().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:631:19 [INFO] [stdout] | [INFO] [stdout] 631 | part: Ok(part), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:656:9 [INFO] [stdout] | [INFO] [stdout] 650 | increment_progress: impl Fn() + Send + Sync, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 656 | / self.process_parts(game_root, increment_progress, |failure| { [INFO] [stdout] 657 | | Ok::<_, Never>(Err(failure)) [INFO] [stdout] 658 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:657:28 [INFO] [stdout] | [INFO] [stdout] 656 | self.process_parts(game_root, increment_progress, |failure| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 657 | Ok::<_, Never>(Err(failure)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:690:13 [INFO] [stdout] | [INFO] [stdout] 689 | self.process_parts(game_root, increment_progress, |failure| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | failure.try_fix(rom_sources).map(|r| r.map(handle_repair)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:752:9 [INFO] [stdout] | [INFO] [stdout] 748 | fn sum(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 752 | iter.into_iter().fold(Self::default(), |acc, x| acc + x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1264:15 [INFO] [stdout] | [INFO] [stdout] 1264 | match map.get(&file_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1377:15 [INFO] [stdout] | [INFO] [stdout] 1373 | fn from_reader(r: R) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1376 | let mut r = Sha1Reader::new(r); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1377 | match Part::disk_from_reader(&mut r) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1556:9 [INFO] [stdout] | [INFO] [stdout] 1551 | fn extract_to_buf(&self, i: R) -> Result>, Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1556 | self.extract(i, &mut buf).map(|_| std::io::Cursor::new(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1630:12 [INFO] [stdout] | [INFO] [stdout] 1627 | let file = Arc::from(pb); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1628 | let mut r = File::open(&file).map(BufReader::new)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1629 | [INFO] [stdout] 1630 | Ok(if is_zip(&mut r).unwrap_or(false) { [INFO] [stdout] | ____________^ [INFO] [stdout] 1631 | | unpack_zip_parts(r, File::open(&file).map(BufReader::new)?) [INFO] [stdout] 1632 | | .into_iter() [INFO] [stdout] 1633 | | .map(|(part, zip_parts)| { [INFO] [stdout] ... | [INFO] [stdout] 1652 | | )] [INFO] [stdout] 1653 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1703:25 [INFO] [stdout] | [INFO] [stdout] 1702 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1703 | / Rate::from_copy(|| copy(source, target)) [INFO] [stdout] 1704 | | .map(|rate| Extracted::Copied { rate }) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1710:51 [INFO] [stdout] | [INFO] [stdout] 1710 | .and_then(|w| Rate::from_copy(|| c.extract(File::open(source.as_ref())?, w))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1710:64 [INFO] [stdout] | [INFO] [stdout] 1710 | .and_then(|w| Rate::from_copy(|| c.extract(File::open(source.as_ref())?, w))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1763:43 [INFO] [stdout] | [INFO] [stdout] 1752 | mut r: R, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1763 | .and_then(|w| Rate::from_copy(|| c.extract(r, w))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1782:19 [INFO] [stdout] | [INFO] [stdout] 1780 | fn is_zip(mut reader: R) -> bool { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1781 | let mut buf = [0; 4]; [INFO] [stdout] 1782 | match reader.read_exact(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1817:12 [INFO] [stdout] | [INFO] [stdout] 1817 | || unpack(&mut zip).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1906:9 [INFO] [stdout] | [INFO] [stdout] 1902 | let mut seen = IntSet::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1906 | / ProgressBar::new_spinner() [INFO] [stdout] 1907 | | .with_style(find_files_style()) [INFO] [stdout] 1908 | | .with_message("locating files"), [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1910:13 [INFO] [stdout] | [INFO] [stdout] 1909 | |pbar| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1910 | / walkdir::WalkDir::new(root) [INFO] [stdout] 1911 | | .into_iter() [INFO] [stdout] 1912 | | .filter_map(|e| e.ok()) [INFO] [stdout] 1913 | | .filter(|e| { [INFO] [stdout] ... | [INFO] [stdout] 1922 | | .progress_with(pbar) [INFO] [stdout] 1923 | | .flat_map(|pb| RomSource::from_path(pb).unwrap_or_default().into_par_iter()) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1923:32 [INFO] [stdout] | [INFO] [stdout] 1923 | .flat_map(|pb| RomSource::from_path(pb).unwrap_or_default().into_par_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:1932:18 [INFO] [stdout] | [INFO] [stdout] 1932 | .map(|v| v.into_iter().collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 30 | fn fetch(source: &str, add_bar: A, remove_bar: R, zip_data: &mut Vec) -> Result<(), Error> [INFO] [stdout] | ---------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let builder = if zip_data.is_empty() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | match builder.send()?.split() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 52 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `emuman` (bin "emuman") due to 53 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dd4cf66c00d3be57c1ba8a6c8277b1e81c7e1241e5ebb1f3b4bc0024e4d4ae4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd4cf66c00d3be57c1ba8a6c8277b1e81c7e1241e5ebb1f3b4bc0024e4d4ae4f", kill_on_drop: false }` [INFO] [stdout] dd4cf66c00d3be57c1ba8a6c8277b1e81c7e1241e5ebb1f3b4bc0024e4d4ae4f