[INFO] fetching crate employees 0.0.6... [INFO] checking employees-0.0.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate employees 0.0.6 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate employees 0.0.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate employees 0.0.6 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate employees 0.0.6 [INFO] tweaked toml for crates.io crate employees 0.0.6 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate employees 0.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60697d307816e534ca28fd2fb0dfe95760646edbac0dccd22ed15a80461b4892 [INFO] running `Command { std: "docker" "start" "-a" "60697d307816e534ca28fd2fb0dfe95760646edbac0dccd22ed15a80461b4892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60697d307816e534ca28fd2fb0dfe95760646edbac0dccd22ed15a80461b4892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60697d307816e534ca28fd2fb0dfe95760646edbac0dccd22ed15a80461b4892", kill_on_drop: false }` [INFO] [stdout] 60697d307816e534ca28fd2fb0dfe95760646edbac0dccd22ed15a80461b4892 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 31f3e98f8d8a016bf840421598fed6af1112875a9b6fbb041d18dd15c472cf6d [INFO] running `Command { std: "docker" "start" "-a" "31f3e98f8d8a016bf840421598fed6af1112875a9b6fbb041d18dd15c472cf6d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling async-trait v0.1.79 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking errno v0.3.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking affinity v0.1.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking employees v0.0.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn context(reason: D) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Self::Context(Box::new(reason)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn other(err: E) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Self::Other(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:137:62 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn launch_pinned(&mut self, worker: W, cores: C) -> Result<(), Error> [INFO] [stdout] | --------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | self.inner_spawn_thread(worker, Settings::default(), Some(cores)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:173:51 [INFO] [stdout] | [INFO] [stdout] 165 | worker: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | cores: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | self.inner_spawn_thread(worker, settings, Some(cores)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:372:22 [INFO] [stdout] | [INFO] [stdout] 369 | fn from(shutdown: Shutdown) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | threads: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:373:27 [INFO] [stdout] | [INFO] [stdout] 369 | fn from(shutdown: Shutdown) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | respawnables: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 399 | ctx: impl RespawnableContext<'static> + 'static, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let worker = ctx.boxed_worker()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | [INFO] [stdout] 406 | let thread = crate::utils::spawn_thread(worker, settings, cores, shutdown)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | [INFO] [stdout] 408 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 409 | | handle: Some(thread), [INFO] [stdout] 410 | | context: Box::new(ctx), [INFO] [stdout] 411 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scoped_runtime.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn nested(scope: &'scope Scope<'scope, 'env>, shutdown: Shutdown) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | threads: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scoped_runtime.rs:58:27 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn nested(scope: &'scope Scope<'scope, 'env>, shutdown: Shutdown) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | respawnables: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scoped_runtime.rs:119:51 [INFO] [stdout] | [INFO] [stdout] 111 | worker: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | cores: C, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | self.inner_spawn_thread(worker, settings, Some(cores)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scoped_runtime.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 240 | ctx: impl RespawnableContext<'env> + 'env, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let worker = ctx.boxed_worker()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | [INFO] [stdout] 247 | let thread = crate::utils::spawn_scoped_thread(scope, worker, settings, cores, shutdown)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | [INFO] [stdout] 249 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 250 | | scope, [INFO] [stdout] 251 | | handle: Some(thread), [INFO] [stdout] 252 | | context: Box::new(ctx), [INFO] [stdout] 253 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 31 | mut worker: W, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | settings: Settings, [INFO] [stdout] 33 | cores: Option, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let shutdown = shutdown.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | / settings [INFO] [stdout] 43 | | .into_inner() [INFO] [stdout] 44 | | .spawn(move || { [INFO] [stdout] 45 | | if let Some(cores) = cores.as_ref() { [INFO] [stdout] ... | [INFO] [stdout] 49 | | worker.run(shutdown); [INFO] [stdout] 50 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 58 | mut worker: W, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | settings: Settings, [INFO] [stdout] 60 | cores: Option, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let shutdown = shutdown.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | / settings [INFO] [stdout] 70 | | .into_inner() [INFO] [stdout] 71 | | .spawn_scoped(scope, move || { [INFO] [stdout] 72 | | if let Some(cores) = cores.as_ref() { [INFO] [stdout] ... | [INFO] [stdout] 76 | | worker.run(shutdown); [INFO] [stdout] 77 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] error: could not compile `employees` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "31f3e98f8d8a016bf840421598fed6af1112875a9b6fbb041d18dd15c472cf6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31f3e98f8d8a016bf840421598fed6af1112875a9b6fbb041d18dd15c472cf6d", kill_on_drop: false }` [INFO] [stdout] 31f3e98f8d8a016bf840421598fed6af1112875a9b6fbb041d18dd15c472cf6d