[INFO] fetching crate emit_file 0.11.0-alpha.13... [INFO] checking emit_file-0.11.0-alpha.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate emit_file 0.11.0-alpha.13 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate emit_file 0.11.0-alpha.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate emit_file 0.11.0-alpha.13 [INFO] finished tweaking crates.io crate emit_file 0.11.0-alpha.13 [INFO] tweaked toml for crates.io crate emit_file 0.11.0-alpha.13 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdf52f77bdff456eab38918ee20e0e4487d75ee81058149cd3b8457f4ad27a3f [INFO] running `Command { std: "docker" "start" "-a" "cdf52f77bdff456eab38918ee20e0e4487d75ee81058149cd3b8457f4ad27a3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdf52f77bdff456eab38918ee20e0e4487d75ee81058149cd3b8457f4ad27a3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdf52f77bdff456eab38918ee20e0e4487d75ee81058149cd3b8457f4ad27a3f", kill_on_drop: false }` [INFO] [stdout] cdf52f77bdff456eab38918ee20e0e4487d75ee81058149cd3b8457f4ad27a3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91718111072a5c0fae983ee0dae4d75bb9a79baaf025f7455bdaf80c37ef340f [INFO] running `Command { std: "docker" "start" "-a" "91718111072a5c0fae983ee0dae4d75bb9a79baaf025f7455bdaf80c37ef340f", kill_on_drop: false }` [INFO] [stderr] Checking sval v2.13.0 [INFO] [stderr] Compiling value-bag v1.9.0 [INFO] [stderr] Compiling emit_macros v0.11.0-alpha.13 [INFO] [stderr] Compiling fv-template v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling emit_core v0.11.0-alpha.13 [INFO] [stderr] Checking sval_ref v2.13.0 [INFO] [stderr] Checking sval_fmt v2.13.0 [INFO] [stderr] Checking sval_dynamic v2.13.0 [INFO] [stderr] Checking sval_json v2.13.0 [INFO] [stderr] Checking sval_buffer v2.13.0 [INFO] [stderr] Checking value-bag-sval2 v1.9.0 [INFO] [stderr] Checking sval_nested v2.13.0 [INFO] [stderr] Checking emit v0.11.0-alpha.13 [INFO] [stderr] Checking emit_batcher v0.11.0-alpha.13 [INFO] [stderr] Checking emit_file v0.11.0-alpha.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:15 [INFO] [stdout] | [INFO] [stdout] 159 | fn new(e: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | Error(e.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:21 [INFO] [stdout] | [INFO] [stdout] 290 | file_set: impl Into, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | / writer: impl Fn(&mut FileBuf, &emit::Event<&dyn emit::props::ErasedProps>) -> io::Result<()> [INFO] [stdout] 292 | | + Send [INFO] [stdout] 293 | | + Sync [INFO] [stdout] 294 | | + 'static, [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | writer: Box::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 387 | pub fn spawn(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | let metrics = Arc::new(InternalMetrics::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | [INFO] [stdout] 392 | let mut worker = Worker::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let (sender, receiver) = emit_batcher::bounded(10_000); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | [INFO] [stdout] 406 | let handle = emit_batcher::sync::spawn(receiver, move |batch| worker.on_batch(batch)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | [INFO] [stdout] 408 | Ok(FileSet { [INFO] [stdout] | ____________^ [INFO] [stdout] 409 | | sender, [INFO] [stdout] 410 | | metrics, [INFO] [stdout] 411 | | writer: self.writer, [INFO] [stdout] 412 | | separator: self.separator, [INFO] [stdout] 413 | | _handle: handle, [INFO] [stdout] 414 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:663:26 [INFO] [stdout] | [INFO] [stdout] 651 | metrics: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 663 | active_file: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:953:12 [INFO] [stdout] | [INFO] [stdout] 941 | fn try_open_reuse(file_path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 946 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 953 | Ok(ActiveFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 954 | | file, [INFO] [stdout] 955 | | file_ts, [INFO] [stdout] 956 | | file_path: file_path.into(), [INFO] [stdout] ... | [INFO] [stdout] 960 | | file_size_bytes, [INFO] [stdout] 961 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:975:12 [INFO] [stdout] | [INFO] [stdout] 964 | fn try_open_create(file_path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 969 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 975 | Ok(ActiveFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 976 | | file, [INFO] [stdout] 977 | | file_ts, [INFO] [stdout] 978 | | file_path: file_path.into(), [INFO] [stdout] 979 | | file_needs_recovery: false, [INFO] [stdout] 980 | | file_size_bytes: 0, [INFO] [stdout] 981 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:15 [INFO] [stdout] | [INFO] [stdout] 159 | fn new(e: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | Error(e.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:21 [INFO] [stdout] | [INFO] [stdout] 290 | file_set: impl Into, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | / writer: impl Fn(&mut FileBuf, &emit::Event<&dyn emit::props::ErasedProps>) -> io::Result<()> [INFO] [stdout] 292 | | + Send [INFO] [stdout] 293 | | + Sync [INFO] [stdout] 294 | | + 'static, [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | writer: Box::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 387 | pub fn spawn(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | let metrics = Arc::new(InternalMetrics::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | [INFO] [stdout] 392 | let mut worker = Worker::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let (sender, receiver) = emit_batcher::bounded(10_000); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | [INFO] [stdout] 406 | let handle = emit_batcher::sync::spawn(receiver, move |batch| worker.on_batch(batch)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | [INFO] [stdout] 408 | Ok(FileSet { [INFO] [stdout] | ____________^ [INFO] [stdout] 409 | | sender, [INFO] [stdout] 410 | | metrics, [INFO] [stdout] 411 | | writer: self.writer, [INFO] [stdout] 412 | | separator: self.separator, [INFO] [stdout] 413 | | _handle: handle, [INFO] [stdout] 414 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:663:26 [INFO] [stdout] | [INFO] [stdout] 651 | metrics: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 663 | active_file: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:953:12 [INFO] [stdout] | [INFO] [stdout] 941 | fn try_open_reuse(file_path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 946 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 953 | Ok(ActiveFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 954 | | file, [INFO] [stdout] 955 | | file_ts, [INFO] [stdout] 956 | | file_path: file_path.into(), [INFO] [stdout] ... | [INFO] [stdout] 960 | | file_size_bytes, [INFO] [stdout] 961 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:975:12 [INFO] [stdout] | [INFO] [stdout] 964 | fn try_open_create(file_path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 969 | let file = fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 975 | Ok(ActiveFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 976 | | file, [INFO] [stdout] 977 | | file_ts, [INFO] [stdout] 978 | | file_path: file_path.into(), [INFO] [stdout] 979 | | file_needs_recovery: false, [INFO] [stdout] 980 | | file_size_bytes: 0, [INFO] [stdout] 981 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `emit_file` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `emit_file` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "91718111072a5c0fae983ee0dae4d75bb9a79baaf025f7455bdaf80c37ef340f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91718111072a5c0fae983ee0dae4d75bb9a79baaf025f7455bdaf80c37ef340f", kill_on_drop: false }` [INFO] [stdout] 91718111072a5c0fae983ee0dae4d75bb9a79baaf025f7455bdaf80c37ef340f