[INFO] fetching crate emit_batcher 0.11.0-alpha.13... [INFO] checking emit_batcher-0.11.0-alpha.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate emit_batcher 0.11.0-alpha.13 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate emit_batcher 0.11.0-alpha.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate emit_batcher 0.11.0-alpha.13 [INFO] finished tweaking crates.io crate emit_batcher 0.11.0-alpha.13 [INFO] tweaked toml for crates.io crate emit_batcher 0.11.0-alpha.13 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b9ae5e12c2b83ce22ef9f52ffa31358af813793328fb20e96b4212a4e5d197a [INFO] running `Command { std: "docker" "start" "-a" "4b9ae5e12c2b83ce22ef9f52ffa31358af813793328fb20e96b4212a4e5d197a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b9ae5e12c2b83ce22ef9f52ffa31358af813793328fb20e96b4212a4e5d197a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b9ae5e12c2b83ce22ef9f52ffa31358af813793328fb20e96b4212a4e5d197a", kill_on_drop: false }` [INFO] [stdout] 4b9ae5e12c2b83ce22ef9f52ffa31358af813793328fb20e96b4212a4e5d197a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d747b97705fd5f4a0ebeae062e86165ec095a3e6ad8edc1b67e5f2a1b8f2e1db [INFO] running `Command { std: "docker" "start" "-a" "d747b97705fd5f4a0ebeae062e86165ec095a3e6ad8edc1b67e5f2a1b8f2e1db", kill_on_drop: false }` [INFO] [stderr] Compiling emit_macros v0.11.0-alpha.13 [INFO] [stderr] Compiling value-bag v1.9.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling fv-template v0.5.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking emit_core v0.11.0-alpha.13 [INFO] [stderr] Checking emit v0.11.0-alpha.13 [INFO] [stderr] Checking emit_batcher v0.11.0-alpha.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 129 | let shared = Arc::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | / Sender { [INFO] [stdout] 140 | | max_capacity, [INFO] [stdout] 141 | | shared: shared.clone(), [INFO] [stdout] 142 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 129 | let shared = Arc::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | / Receiver { [INFO] [stdout] 144 | | idle_delay: Delay::new(Duration::from_millis(1), Duration::from_millis(500)), [INFO] [stdout] 145 | | retry: Retry::new(10), [INFO] [stdout] 146 | | retry_delay: Delay::new(Duration::from_millis(50), Duration::from_secs(1)), [INFO] [stdout] 147 | | capacity: Capacity::new(), [INFO] [stdout] 148 | | shared, [INFO] [stdout] 149 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:487:33 [INFO] [stdout] | [INFO] [stdout] 486 | pub fn no_retry(_: impl std::error::Error + Send + Sync + 'static) -> Self { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | BatchError { retryable: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:495:24 [INFO] [stdout] | [INFO] [stdout] 493 | pub fn retry(_: impl std::error::Error + Send + Sync + 'static, retryable: T) -> Self { [INFO] [stdout] | ------------------------------------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | BatchError { [INFO] [stdout] 495 | retryable: Some(retryable), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:503:62 [INFO] [stdout] | [INFO] [stdout] 503 | self.retryable.ok_or_else(|| BatchError { retryable: None }) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:522:24 [INFO] [stdout] | [INFO] [stdout] 520 | pub fn map_retryable(self, f: impl FnOnce(Option) -> Option) -> BatchError { [INFO] [stdout] | ---- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | BatchError { [INFO] [stdout] 522 | retryable: f(self.retryable), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 21 | receiver: Receiver, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | mut on_batch: impl FnMut(T) -> Result<(), BatchError> + Send + 'static, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 28 | | block_on(receiver.exec( [INFO] [stdout] 29 | | |delay| future::ready(thread::sleep(delay)), [INFO] [stdout] 30 | | move |batch| future::ready(on_batch(batch)), [INFO] [stdout] 31 | | )) [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 21 | receiver: Receiver, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | mut on_batch: impl FnMut(T) -> Result<(), BatchError> + Send + 'static, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | block_on(receiver.exec( [INFO] [stdout] | __________________^ [INFO] [stdout] 29 | | |delay| future::ready(thread::sleep(delay)), [INFO] [stdout] 30 | | move |batch| future::ready(on_batch(batch)), [INFO] [stdout] 31 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:30:40 [INFO] [stdout] | [INFO] [stdout] 22 | mut on_batch: impl FnMut(T) -> Result<(), BatchError> + Send + 'static, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | move |batch| future::ready(on_batch(batch)), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:60:14 [INFO] [stdout] | [INFO] [stdout] 57 | msg: T::Item, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | block_on(sender.send_or_wait(msg, timeout, |sender, timeout| { [INFO] [stdout] | ______________^ [INFO] [stdout] 61 | | let notifier = Trigger::new(); [INFO] [stdout] 62 | | [INFO] [stdout] 63 | | sender.when_empty({ [INFO] [stdout] ... | [INFO] [stdout] 73 | | future::ready(()) [INFO] [stdout] 74 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `emit_batcher` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d747b97705fd5f4a0ebeae062e86165ec095a3e6ad8edc1b67e5f2a1b8f2e1db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d747b97705fd5f4a0ebeae062e86165ec095a3e6ad8edc1b67e5f2a1b8f2e1db", kill_on_drop: false }` [INFO] [stdout] d747b97705fd5f4a0ebeae062e86165ec095a3e6ad8edc1b67e5f2a1b8f2e1db