[INFO] fetching crate emf-core-base-rs 0.1.3... [INFO] checking emf-core-base-rs-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate emf-core-base-rs 0.1.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate emf-core-base-rs 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate emf-core-base-rs 0.1.3 [INFO] finished tweaking crates.io crate emf-core-base-rs 0.1.3 [INFO] tweaked toml for crates.io crate emf-core-base-rs 0.1.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8494bdaa2c33af657f2b8b01d1c089c9a3b30cfbfa533e0e3088dde51dfc35b [INFO] running `Command { std: "docker" "start" "-a" "b8494bdaa2c33af657f2b8b01d1c089c9a3b30cfbfa533e0e3088dde51dfc35b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8494bdaa2c33af657f2b8b01d1c089c9a3b30cfbfa533e0e3088dde51dfc35b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8494bdaa2c33af657f2b8b01d1c089c9a3b30cfbfa533e0e3088dde51dfc35b", kill_on_drop: false }` [INFO] [stdout] b8494bdaa2c33af657f2b8b01d1c089c9a3b30cfbfa533e0e3088dde51dfc35b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87e9a34bf23f34900fb9c3ae239105213c4c5689194a704dc07284299ecd2dfe [INFO] running `Command { std: "docker" "start" "-a" "87e9a34bf23f34900fb9c3ae239105213c4c5689194a704dc07284299ecd2dfe", kill_on_drop: false }` [INFO] [stderr] Checking emf-core-base-rs-ffi v0.1.2 [INFO] [stderr] Checking emf-core-base-rs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/extensions/unwind_internal.rs:230:40 [INFO] [stdout] | [INFO] [stdout] 230 | use std::panic::{AssertUnwindSafe, PanicInfo, UnwindSafe}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/extensions/unwind_internal.rs:271:26 [INFO] [stdout] | [INFO] [stdout] 271 | fn panic_hook(info: &PanicInfo<'_>) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `const_fn_trait_bound` has been stable since 1.61.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(const_fn_trait_bound)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `c_unwind` has been stable since 1.81.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | #![feature(c_unwind)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/extensions/unwind_internal.rs:230:40 [INFO] [stdout] | [INFO] [stdout] 230 | use std::panic::{AssertUnwindSafe, PanicInfo, UnwindSafe}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/extensions/unwind_internal.rs:271:26 [INFO] [stdout] | [INFO] [stdout] 271 | fn panic_hook(info: &PanicInfo<'_>) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `const_fn_trait_bound` has been stable since 1.61.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | #![feature(const_fn_trait_bound)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `c_unwind` has been stable since 1.81.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | #![feature(c_unwind)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/api.rs:329:28 [INFO] [stdout] | [INFO] [stdout] 329 | |v| Ok(LibraryLoader::from_interface(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/api.rs:518:24 [INFO] [stdout] | [INFO] [stdout] 505 | caster: impl FnOnce(CBaseFn) -> U, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/library_loader.rs:487:17 [INFO] [stdout] | [INFO] [stdout] 473 | caster: impl FnOnce(NonNullConst) -> &'a U, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 487 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/library/library_loader.rs:481:25 [INFO] [stdout] | [INFO] [stdout] 481 | internal.borrow().as_handle(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `InternalLibrary` does not implement `Borrow`, so calling `borrow` on `&InternalLibrary` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 481 - internal.borrow().as_handle(), [INFO] [stdout] 481 + internal.as_handle(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `InternalLibrary`, implement `Clone` for it [INFO] [stdout] --> src/library.rs:159:1 [INFO] [stdout] | [INFO] [stdout] 159 + #[derive(Clone)] [INFO] [stdout] 160 | pub struct InternalLibrary { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/library_loader.rs:510:17 [INFO] [stdout] | [INFO] [stdout] 496 | caster: impl FnOnce(CBaseFn) -> U, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/library/library_loader.rs:504:25 [INFO] [stdout] | [INFO] [stdout] 504 | internal.borrow().as_handle(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `InternalLibrary` does not implement `Borrow`, so calling `borrow` on `&InternalLibrary` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 504 - internal.borrow().as_handle(), [INFO] [stdout] 504 + internal.as_handle(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `InternalLibrary`, implement `Clone` for it [INFO] [stdout] --> src/library.rs:159:1 [INFO] [stdout] | [INFO] [stdout] 159 + #[derive(Clone)] [INFO] [stdout] 160 | pub struct InternalLibrary { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/library_loader.rs:510:24 [INFO] [stdout] | [INFO] [stdout] 496 | caster: impl FnOnce(CBaseFn) -> U, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/library/library_loader.rs:801:40 [INFO] [stdout] | [INFO] [stdout] 801 | .get_native_handle(internal.borrow().as_handle()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `InternalLibrary` does not implement `Borrow`, so calling `borrow` on `&InternalLibrary` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 801 - .get_native_handle(internal.borrow().as_handle()) [INFO] [stdout] 801 + .get_native_handle(internal.as_handle()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `InternalLibrary`, implement `Clone` for it [INFO] [stdout] --> src/library.rs:159:1 [INFO] [stdout] | [INFO] [stdout] 159 + #[derive(Clone)] [INFO] [stdout] 160 | pub struct InternalLibrary { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/api.rs:569:28 [INFO] [stdout] | [INFO] [stdout] 569 | |v| Ok(ModuleLoader::from_interface(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/api.rs:1002:28 [INFO] [stdout] | [INFO] [stdout] 992 | caster: impl FnOnce(crate::ffi::module::Interface) -> IT, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1002 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/module_loader.rs:945:17 [INFO] [stdout] | [INFO] [stdout] 934 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 945 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/module_loader.rs:945:24 [INFO] [stdout] | [INFO] [stdout] 934 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 945 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/native_module.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 280 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/native_module.rs:291:24 [INFO] [stdout] | [INFO] [stdout] 280 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/extensions/unwind_internal.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn setup_unwind(f: impl FnOnce() -> T + UnwindSafe) -> T { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | move |_interface| f(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/extensions/unwind_internal.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn catch_unwind(f: impl FnOnce() -> T + UnwindSafe) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | move |_interface| f(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `emf-core-base-rs` (lib) due to 14 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/api.rs:329:28 [INFO] [stdout] | [INFO] [stdout] 329 | |v| Ok(LibraryLoader::from_interface(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/api.rs:518:24 [INFO] [stdout] | [INFO] [stdout] 505 | caster: impl FnOnce(CBaseFn) -> U, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/library_loader.rs:487:17 [INFO] [stdout] | [INFO] [stdout] 473 | caster: impl FnOnce(NonNullConst) -> &'a U, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 487 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/library/library_loader.rs:481:25 [INFO] [stdout] | [INFO] [stdout] 481 | internal.borrow().as_handle(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `InternalLibrary` does not implement `Borrow`, so calling `borrow` on `&InternalLibrary` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 481 - internal.borrow().as_handle(), [INFO] [stdout] 481 + internal.as_handle(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `InternalLibrary`, implement `Clone` for it [INFO] [stdout] --> src/library.rs:159:1 [INFO] [stdout] | [INFO] [stdout] 159 + #[derive(Clone)] [INFO] [stdout] 160 | pub struct InternalLibrary { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/library_loader.rs:510:17 [INFO] [stdout] | [INFO] [stdout] 496 | caster: impl FnOnce(CBaseFn) -> U, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/library/library_loader.rs:504:25 [INFO] [stdout] | [INFO] [stdout] 504 | internal.borrow().as_handle(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `InternalLibrary` does not implement `Borrow`, so calling `borrow` on `&InternalLibrary` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 504 - internal.borrow().as_handle(), [INFO] [stdout] 504 + internal.as_handle(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `InternalLibrary`, implement `Clone` for it [INFO] [stdout] --> src/library.rs:159:1 [INFO] [stdout] | [INFO] [stdout] 159 + #[derive(Clone)] [INFO] [stdout] 160 | pub struct InternalLibrary { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library/library_loader.rs:510:24 [INFO] [stdout] | [INFO] [stdout] 496 | caster: impl FnOnce(CBaseFn) -> U, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | |v| Ok(Symbol::new(caster(v.symbol))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/library/library_loader.rs:801:40 [INFO] [stdout] | [INFO] [stdout] 801 | .get_native_handle(internal.borrow().as_handle()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `InternalLibrary` does not implement `Borrow`, so calling `borrow` on `&InternalLibrary` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 801 - .get_native_handle(internal.borrow().as_handle()) [INFO] [stdout] 801 + .get_native_handle(internal.as_handle()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `InternalLibrary`, implement `Clone` for it [INFO] [stdout] --> src/library.rs:159:1 [INFO] [stdout] | [INFO] [stdout] 159 + #[derive(Clone)] [INFO] [stdout] 160 | pub struct InternalLibrary { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/api.rs:569:28 [INFO] [stdout] | [INFO] [stdout] 569 | |v| Ok(ModuleLoader::from_interface(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/api.rs:1002:28 [INFO] [stdout] | [INFO] [stdout] 992 | caster: impl FnOnce(crate::ffi::module::Interface) -> IT, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1002 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/module_loader.rs:945:17 [INFO] [stdout] | [INFO] [stdout] 934 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 945 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/module_loader.rs:945:24 [INFO] [stdout] | [INFO] [stdout] 934 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 945 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/native_module.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 280 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/native_module.rs:291:24 [INFO] [stdout] | [INFO] [stdout] 280 | caster: impl FnOnce(crate::ffi::module::Interface) -> T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | |v| Ok(Interface::new(caster(v))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/extensions/unwind_internal.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn setup_unwind(f: impl FnOnce() -> T + UnwindSafe) -> T { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | move |_interface| f(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/extensions/unwind_internal.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn catch_unwind(f: impl FnOnce() -> T + UnwindSafe) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | move |_interface| f(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `emf-core-base-rs` (lib test) due to 14 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "87e9a34bf23f34900fb9c3ae239105213c4c5689194a704dc07284299ecd2dfe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87e9a34bf23f34900fb9c3ae239105213c4c5689194a704dc07284299ecd2dfe", kill_on_drop: false }` [INFO] [stdout] 87e9a34bf23f34900fb9c3ae239105213c4c5689194a704dc07284299ecd2dfe