[INFO] fetching crate embedded-nano-mesh 1.0.5... [INFO] checking embedded-nano-mesh-1.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embedded-nano-mesh 1.0.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate embedded-nano-mesh 1.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate embedded-nano-mesh 1.0.5 [INFO] finished tweaking crates.io crate embedded-nano-mesh 1.0.5 [INFO] tweaked toml for crates.io crate embedded-nano-mesh 1.0.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a35b0120473a459704ce00e029c4d488260f42a562458a211383a211e420c648 [INFO] running `Command { std: "docker" "start" "-a" "a35b0120473a459704ce00e029c4d488260f42a562458a211383a211e420c648", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a35b0120473a459704ce00e029c4d488260f42a562458a211383a211e420c648", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a35b0120473a459704ce00e029c4d488260f42a562458a211383a211e420c648", kill_on_drop: false }` [INFO] [stdout] a35b0120473a459704ce00e029c4d488260f42a562458a211383a211e420c648 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e55fdae2d35e548c710af90a20789203eb7b74bb508c6d5d55abe3d319a69b68 [INFO] running `Command { std: "docker" "start" "-a" "e55fdae2d35e548c710af90a20789203eb7b74bb508c6d5d55abe3d319a69b68", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking ufmt-write v0.1.0 [INFO] [stderr] Checking platform-millis v2.0.0 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking platform-serial v1.0.2 [INFO] [stderr] Compiling ufmt-macros v0.3.0 [INFO] [stderr] Checking ufmt v0.2.0 [INFO] [stderr] Checking embedded-nano-mesh v1.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/mod.rs:280:20 [INFO] [stdout] | [INFO] [stdout] 275 | data: PacketDataBytes, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | self._send(PacketMetaData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 281 | | data, [INFO] [stdout] 282 | | source_device_identifier: self.my_address.clone().into(), [INFO] [stdout] 283 | | destination_device_identifier: destination_device_identifier.into(), [INFO] [stdout] ... | [INFO] [stdout] 287 | | packet_id: 0, [INFO] [stdout] 288 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/packet/trait_implementations/data_packer.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | fn unpack(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Ok(PacketMetaData { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | data: self.data.iter().map(|el| *el).collect(), // Can it be simplified? [INFO] [stdout] 26 | | source_device_identifier: match ExactAddressType::new(self.source_device_identifier) { [INFO] [stdout] 27 | | Some(addr) => addr, [INFO] [stdout] ... | [INFO] [stdout] 36 | | packet_id: self.id, [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/receiver/mod.rs:45:15 [INFO] [stdout] | [INFO] [stdout] 42 | packet: Packet, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 46 | | .packet_filter [INFO] [stdout] 47 | | .filter_out_duplicated(packet, current_time) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/receiver/mod.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 71 | let packet = match self.packet_bytes_parser.get_packet() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | None => return None, [INFO] [stdout] 73 | Some(packet) => packet, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let packet = match self.filter_out_duplicated(packet, current_time) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Err(_) => return None, [INFO] [stdout] 78 | Ok(packet) => packet, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | match ::unpack(packet) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/router/mod.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 77 | packet_meta_data: PacketMetaData, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> Result { [INFO] [stdout] 79 | let received = packet_meta_data.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let transit = packet_meta_data.mutated()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Ok(RouteResult::ReceivedAndTransit { received, transit }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/router/mod.rs:118:15 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn route(&self, packet_meta_data: PacketMetaData) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | match packet_meta_data.deacrease_lifetime() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/transmitter.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 48 | mut packet_meta_data: PacketMetaData, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let packed_data = ::pack(packet_meta_data); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | match self.packet_queue.push_back(packed_data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-nano-mesh` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/mod.rs:280:20 [INFO] [stdout] | [INFO] [stdout] 275 | data: PacketDataBytes, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | self._send(PacketMetaData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 281 | | data, [INFO] [stdout] 282 | | source_device_identifier: self.my_address.clone().into(), [INFO] [stdout] 283 | | destination_device_identifier: destination_device_identifier.into(), [INFO] [stdout] ... | [INFO] [stdout] 287 | | packet_id: 0, [INFO] [stdout] 288 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/packet/trait_implementations/data_packer.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | fn unpack(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Ok(PacketMetaData { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | data: self.data.iter().map(|el| *el).collect(), // Can it be simplified? [INFO] [stdout] 26 | | source_device_identifier: match ExactAddressType::new(self.source_device_identifier) { [INFO] [stdout] 27 | | Some(addr) => addr, [INFO] [stdout] ... | [INFO] [stdout] 36 | | packet_id: self.id, [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/receiver/mod.rs:45:15 [INFO] [stdout] | [INFO] [stdout] 42 | packet: Packet, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 46 | | .packet_filter [INFO] [stdout] 47 | | .filter_out_duplicated(packet, current_time) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/receiver/mod.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 71 | let packet = match self.packet_bytes_parser.get_packet() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | None => return None, [INFO] [stdout] 73 | Some(packet) => packet, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let packet = match self.filter_out_duplicated(packet, current_time) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Err(_) => return None, [INFO] [stdout] 78 | Ok(packet) => packet, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | match ::unpack(packet) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/router/mod.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 77 | packet_meta_data: PacketMetaData, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> Result { [INFO] [stdout] 79 | let received = packet_meta_data.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let transit = packet_meta_data.mutated()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Ok(RouteResult::ReceivedAndTransit { received, transit }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/router/mod.rs:118:15 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn route(&self, packet_meta_data: PacketMetaData) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | match packet_meta_data.deacrease_lifetime() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh_lib/node/transmitter.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 48 | mut packet_meta_data: PacketMetaData, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let packed_data = ::pack(packet_meta_data); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | match self.packet_queue.push_back(packed_data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-nano-mesh` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "e55fdae2d35e548c710af90a20789203eb7b74bb508c6d5d55abe3d319a69b68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e55fdae2d35e548c710af90a20789203eb7b74bb508c6d5d55abe3d319a69b68", kill_on_drop: false }` [INFO] [stdout] e55fdae2d35e548c710af90a20789203eb7b74bb508c6d5d55abe3d319a69b68