[INFO] fetching crate embedded-menu 0.6.1... [INFO] checking embedded-menu-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embedded-menu 0.6.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate embedded-menu 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embedded-menu 0.6.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate embedded-menu 0.6.1 [INFO] tweaked toml for crates.io crate embedded-menu 0.6.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate embedded-menu 0.6.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] da4e08ec85033a3f597586dc5e31b53313b2ba8e34dad5a65b7cffe4efca2d08 [INFO] running `Command { std: "docker" "start" "-a" "da4e08ec85033a3f597586dc5e31b53313b2ba8e34dad5a65b7cffe4efca2d08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da4e08ec85033a3f597586dc5e31b53313b2ba8e34dad5a65b7cffe4efca2d08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da4e08ec85033a3f597586dc5e31b53313b2ba8e34dad5a65b7cffe4efca2d08", kill_on_drop: false }` [INFO] [stdout] da4e08ec85033a3f597586dc5e31b53313b2ba8e34dad5a65b7cffe4efca2d08 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5977678423bc612a76eecb18b8f5137b7767b756ea931f5f1f276e1936acd265 [INFO] running `Command { std: "docker" "start" "-a" "5977678423bc612a76eecb18b8f5137b7767b756ea931f5f1f276e1936acd265", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking micromath v2.0.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking object-chain v0.1.3 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking embedded-graphics-core v0.4.0 [INFO] [stderr] Checking embedded-graphics v0.8.1 [INFO] [stderr] Checking embedded-text v0.7.0 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Compiling embedded-layout-macros v0.2.1 [INFO] [stderr] Compiling ouroboros_macro v0.17.2 [INFO] [stderr] Compiling embedded-menu-macros v0.4.0 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking embedded-layout v0.4.0 [INFO] [stderr] Checking embedded-menu v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters/color_map.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 33 | fn draw_iter(&mut self, pixels: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | .draw_iter(pixels.into_iter().map(|Pixel(pos, color)| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 39 | | let color = if self.area.contains(pos) ^ (color == BinaryColor::On) { [INFO] [stdout] 40 | | self.on_color [INFO] [stdout] 41 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 45 | | Pixel(pos, color) [INFO] [stdout] 46 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 58 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | title: T2, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | / MenuItem::new(title, ()) [INFO] [stdout] 63 | | .with_value_converter(|_| unreachable!()) [INFO] [stdout] 64 | | .selectable::(), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 74 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | title: T2, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | value: V, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | self.add_menu_item(MenuItem::new(title, value).with_value_converter(converter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 84 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | mut item: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | items: Chain::new(item), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 98 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | mut items: IC, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | items: Chain::new(MenuItems::new(items)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 129 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | title: T2, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | / MenuItem::new(title, ()) [INFO] [stdout] 134 | | .with_value_converter(|_| unreachable!()) [INFO] [stdout] 135 | | .selectable::(), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:150:28 [INFO] [stdout] | [INFO] [stdout] 145 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | title: T2, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | value: V, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | self.add_menu_item(MenuItem::new(title, value).with_value_converter(converter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:162:20 [INFO] [stdout] | [INFO] [stdout] 155 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | mut item: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | items: Link { [INFO] [stdout] | ____________________^ [INFO] [stdout] 163 | | parent: self.items, [INFO] [stdout] 164 | | object: item, [INFO] [stdout] 165 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:186:20 [INFO] [stdout] | [INFO] [stdout] 172 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | mut items: IC, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | items: Link { [INFO] [stdout] | ____________________^ [INFO] [stdout] 187 | | parent: self.items, [INFO] [stdout] 188 | | object: MenuItems::new(items), [INFO] [stdout] 189 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-menu` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5977678423bc612a76eecb18b8f5137b7767b756ea931f5f1f276e1936acd265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5977678423bc612a76eecb18b8f5137b7767b756ea931f5f1f276e1936acd265", kill_on_drop: false }` [INFO] [stdout] 5977678423bc612a76eecb18b8f5137b7767b756ea931f5f1f276e1936acd265