[INFO] fetching crate embedded-hal-vcd 0.2.0... [INFO] checking embedded-hal-vcd-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embedded-hal-vcd 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate embedded-hal-vcd 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embedded-hal-vcd 0.2.0 [INFO] finished tweaking crates.io crate embedded-hal-vcd 0.2.0 [INFO] tweaked toml for crates.io crate embedded-hal-vcd 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate embedded-hal-vcd 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ec5753ca4e124547cab1c7e3d8d0b9572834289063aca5df88f1d0910a126d8 [INFO] running `Command { std: "docker" "start" "-a" "2ec5753ca4e124547cab1c7e3d8d0b9572834289063aca5df88f1d0910a126d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ec5753ca4e124547cab1c7e3d8d0b9572834289063aca5df88f1d0910a126d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ec5753ca4e124547cab1c7e3d8d0b9572834289063aca5df88f1d0910a126d8", kill_on_drop: false }` [INFO] [stdout] 2ec5753ca4e124547cab1c7e3d8d0b9572834289063aca5df88f1d0910a126d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 890171a6ff8166a5bc5479a30cae59a351a176abf52477ab8f75dbc0abee2aa6 [INFO] running `Command { std: "docker" "start" "-a" "890171a6ff8166a5bc5479a30cae59a351a176abf52477ab8f75dbc0abee2aa6", kill_on_drop: false }` [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Checking embedded-hal v1.0.0-alpha.9 [INFO] [stderr] Checking vcd v0.6.1 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking synchronized-writer v1.1.10 [INFO] [stderr] Checking pretty_assertions v1.0.0 [INFO] [stderr] Checking num-rational v0.3.2 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Checking embedded-time v0.12.1 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking embedded-hal-sync-pins v0.7.0 [INFO] [stderr] Checking embedded-hal-vcd v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(read: R) -> IOResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut parser = vcd::Parser::new(read); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | parser, [INFO] [stdout] 35 | | header, [INFO] [stdout] 36 | | scale, [INFO] [stdout] 37 | | pins: FnvHashMap::default(), [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new_with_module(writer: W, module: &str) -> IOResult { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let mut writer = vcd::Writer::new(writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(VcdWriterBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | writer, [INFO] [stdout] 38 | | pins: vec![], [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 55 | let pin = Arc::new(AtomicPinState::new_with_state(PinState::Low)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.pins.push((code, pin.clone())); [INFO] [stdout] 57 | Ok(PushPullPin::new(pin)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 73 | let pin = Arc::new(AtomicPinState::new_with_state(PinState::Floating)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | self.pins.push((code, pin.clone())); [INFO] [stdout] 75 | Ok(OpenDrainPin::new(pin)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn build(mut self) -> IOResult> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok(VcdWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 90 | | writer: self.writer, [INFO] [stdout] 91 | | pins: self.pins, [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-hal-vcd` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(read: R) -> IOResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut parser = vcd::Parser::new(read); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | parser, [INFO] [stdout] 35 | | header, [INFO] [stdout] 36 | | scale, [INFO] [stdout] 37 | | pins: FnvHashMap::default(), [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new_with_module(writer: W, module: &str) -> IOResult { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let mut writer = vcd::Writer::new(writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(VcdWriterBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | writer, [INFO] [stdout] 38 | | pins: vec![], [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 55 | let pin = Arc::new(AtomicPinState::new_with_state(PinState::Low)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.pins.push((code, pin.clone())); [INFO] [stdout] 57 | Ok(PushPullPin::new(pin)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 73 | let pin = Arc::new(AtomicPinState::new_with_state(PinState::Floating)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | self.pins.push((code, pin.clone())); [INFO] [stdout] 75 | Ok(OpenDrainPin::new(pin)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn build(mut self) -> IOResult> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok(VcdWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 90 | | writer: self.writer, [INFO] [stdout] 91 | | pins: self.pins, [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-hal-vcd` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "890171a6ff8166a5bc5479a30cae59a351a176abf52477ab8f75dbc0abee2aa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "890171a6ff8166a5bc5479a30cae59a351a176abf52477ab8f75dbc0abee2aa6", kill_on_drop: false }` [INFO] [stdout] 890171a6ff8166a5bc5479a30cae59a351a176abf52477ab8f75dbc0abee2aa6