[INFO] fetching crate embedded-graphics-transform 0.1.0... [INFO] checking embedded-graphics-transform-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embedded-graphics-transform 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate embedded-graphics-transform 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embedded-graphics-transform 0.1.0 [INFO] finished tweaking crates.io crate embedded-graphics-transform 0.1.0 [INFO] tweaked toml for crates.io crate embedded-graphics-transform 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] [stderr] Adding embedded-graphics v0.7.1 (latest: v0.8.1) [INFO] [stderr] Adding embedded-graphics-core v0.3.3 (latest: v0.4.0) [INFO] [stderr] Adding float-cmp v0.8.0 (latest: v0.9.0) [INFO] [stderr] Adding micromath v1.1.1 (latest: v2.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff3f43e242716acaf6d5064f064c82f0df491541ad5127632f997f9ab12e5fde [INFO] running `Command { std: "docker" "start" "-a" "ff3f43e242716acaf6d5064f064c82f0df491541ad5127632f997f9ab12e5fde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff3f43e242716acaf6d5064f064c82f0df491541ad5127632f997f9ab12e5fde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff3f43e242716acaf6d5064f064c82f0df491541ad5127632f997f9ab12e5fde", kill_on_drop: false }` [INFO] [stdout] ff3f43e242716acaf6d5064f064c82f0df491541ad5127632f997f9ab12e5fde [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37acd0cc48b842db5d002d7c66d14ef422d49c7250cfb93a439bd310af124e0a [INFO] running `Command { std: "docker" "start" "-a" "37acd0cc48b842db5d002d7c66d14ef422d49c7250cfb93a439bd310af124e0a", kill_on_drop: false }` [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Checking micromath v1.1.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking float-cmp v0.8.0 [INFO] [stderr] Checking embedded-graphics-core v0.3.3 [INFO] [stderr] Checking embedded-graphics v0.7.1 [INFO] [stderr] Checking embedded-graphics-transform v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | r#impl::$xform::new(xform_new!($inner, $($rest)*)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new(target: D) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `xform_new` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:46 [INFO] [stdout] | [INFO] [stdout] 52 | impl_as_ref!($asref, r#impl::$xform::$asref($expr), $($rest)*) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | pub fn into_inner(self) -> D { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_as_ref` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | r#impl::$xform::new(xform_new!($inner, $($rest)*)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new(target: D) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `xform_new` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:46 [INFO] [stdout] | [INFO] [stdout] 52 | impl_as_ref!($asref, r#impl::$xform::$asref($expr), $($rest)*) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | pub fn into_inner(self) -> D { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_as_ref` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | r#impl::$xform::new(xform_new!($inner, $($rest)*)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new(target: D) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `xform_new` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:46 [INFO] [stdout] | [INFO] [stdout] 52 | impl_as_ref!($asref, r#impl::$xform::$asref($expr), $($rest)*) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | pub fn into_inner(self) -> D { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_as_ref` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | r#impl::$xform::new(xform_new!($inner, $($rest)*)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new(target: D) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `xform_new` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | r#impl::$xform::new(xform_new!($inner, $($rest)*)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new(target: D) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `xform_new` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-graphics-transform` (lib) due to 13 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | r#impl::$xform::new(xform_new!($inner, $($rest)*)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn new(target: D) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / impl_xform! { [INFO] [stdout] 151 | | /// No-op (identity) rotation for completeness. [INFO] [stdout] 152 | | Rotate0: ; [INFO] [stdout] 153 | | /// Rotate image 90 degrees to the right. [INFO] [stdout] ... | [INFO] [stdout] 165 | | FlipY: MirrorY; [INFO] [stdout] 166 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `xform_new` which comes from the expansion of the macro `impl_xform` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:381:17 [INFO] [stdout] | [INFO] [stdout] 376 | fn draw_iter(&mut self, pixels: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 381 | / pixels [INFO] [stdout] 382 | | .into_iter() [INFO] [stdout] 383 | | .map(|Pixel(loc, col)| Pixel(loc.transpose(), col)), [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:442:17 [INFO] [stdout] | [INFO] [stdout] 435 | fn draw_iter(&mut self, pixels: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | / pixels [INFO] [stdout] 443 | | .into_iter() [INFO] [stdout] 444 | | .map(|Pixel(Point { x, y }, col)| Pixel(Point { x: width - x, y }, col)), [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:510:17 [INFO] [stdout] | [INFO] [stdout] 503 | fn draw_iter(&mut self, pixels: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | / pixels [INFO] [stdout] 511 | | .into_iter() [INFO] [stdout] 512 | | .map(|Pixel(Point { x, y }, col)| Pixel(Point { x, y: height - y }, col)), [INFO] [stdout] | |_____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "37acd0cc48b842db5d002d7c66d14ef422d49c7250cfb93a439bd310af124e0a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37acd0cc48b842db5d002d7c66d14ef422d49c7250cfb93a439bd310af124e0a", kill_on_drop: false }` [INFO] [stdout] 37acd0cc48b842db5d002d7c66d14ef422d49c7250cfb93a439bd310af124e0a