[INFO] fetching crate embedded-graphics 0.8.1... [INFO] checking embedded-graphics-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embedded-graphics 0.8.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate embedded-graphics 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embedded-graphics 0.8.1 [INFO] finished tweaking crates.io crate embedded-graphics 0.8.1 [INFO] tweaked toml for crates.io crate embedded-graphics 0.8.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding nalgebra v0.30.1 (latest: v0.33.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding simba v0.7.3 (latest: v0.9.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a0fbbaad4799502854bf79c3af8d9dc789ee55d6d7c4e1009b6eda1dae011b0 [INFO] running `Command { std: "docker" "start" "-a" "6a0fbbaad4799502854bf79c3af8d9dc789ee55d6d7c4e1009b6eda1dae011b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a0fbbaad4799502854bf79c3af8d9dc789ee55d6d7c4e1009b6eda1dae011b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a0fbbaad4799502854bf79c3af8d9dc789ee55d6d7c4e1009b6eda1dae011b0", kill_on_drop: false }` [INFO] [stdout] 6a0fbbaad4799502854bf79c3af8d9dc789ee55d6d7c4e1009b6eda1dae011b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9d2be3f846c26d0e3be2693923b8e21f86d793f17fa19ca27df3c5eb8e625ba [INFO] running `Command { std: "docker" "start" "-a" "d9d2be3f846c26d0e3be2693923b8e21f86d793f17fa19ca27df3c5eb8e625ba", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking micromath v2.1.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking embedded-graphics-core v0.4.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking embedded-graphics v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `tan` is never used [INFO] [stdout] --> src/geometry/angle.rs:122:8 [INFO] [stdout] | [INFO] [stdout] 114 | pub(crate) trait Trigonometry { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 122 | fn tan(self) -> Option; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/draw_target/color_converted.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 43 | fn draw_iter(&mut self, pixels: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | .draw_iter(pixels.into_iter().map(|Pixel(p, c)| Pixel(p, c.into()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/draw_target/color_converted.rs:56:36 [INFO] [stdout] | [INFO] [stdout] 51 | fn fill_contiguous(&mut self, area: &Rectangle, colors: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .fill_contiguous(area, colors.into_iter().map(|c| c.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/draw_target/translated.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 42 | fn draw_iter(&mut self, pixels: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | .draw_iter(pixels.into_iter().translated(self.offset)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator/contiguous.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 27 | pub(super) fn new(iter: I, bounding_box: Rectangle) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self { [INFO] [stdout] 29 | iter: bounding_box.points().zip(iter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mono_font/draw_target.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 21 | fn fill_contiguous(&mut self, area: &Rectangle, colors: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / colors [INFO] [stdout] 29 | | .into_iter() [INFO] [stdout] 30 | | .into_pixels(area) [INFO] [stdout] 31 | | .filter(|Pixel(_, color)| color.is_on()) [INFO] [stdout] 32 | | .map(|Pixel(pos, _)| Pixel(pos, foreground_color)), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mono_font/draw_target.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 59 | fn fill_contiguous(&mut self, area: &Rectangle, colors: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | / colors [INFO] [stdout] 67 | | .into_iter() [INFO] [stdout] 68 | | .into_pixels(area) [INFO] [stdout] 69 | | .filter(|Pixel(_, color)| color.is_off()) [INFO] [stdout] 70 | | .map(|Pixel(pos, _)| Pixel(pos, foreground_color)), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mono_font/draw_target.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 97 | fn fill_contiguous(&mut self, area: &Rectangle, colors: I) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | / colors.into_iter().map(|color| match color { [INFO] [stdout] 107 | | BinaryColor::Off => background_color, [INFO] [stdout] 108 | | BinaryColor::On => foreground_color, [INFO] [stdout] 109 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-graphics` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d9d2be3f846c26d0e3be2693923b8e21f86d793f17fa19ca27df3c5eb8e625ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9d2be3f846c26d0e3be2693923b8e21f86d793f17fa19ca27df3c5eb8e625ba", kill_on_drop: false }` [INFO] [stdout] d9d2be3f846c26d0e3be2693923b8e21f86d793f17fa19ca27df3c5eb8e625ba