[INFO] fetching crate embedded-async-timer 0.1.0... [INFO] checking embedded-async-timer-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embedded-async-timer 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate embedded-async-timer 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embedded-async-timer 0.1.0 [INFO] finished tweaking crates.io crate embedded-async-timer 0.1.0 [INFO] tweaked toml for crates.io crate embedded-async-timer 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding aligned v0.3.5 (latest: v0.4.2) [INFO] [stderr] Adding arraydeque v0.4.5 (latest: v0.5.1) [INFO] [stderr] Adding as-slice v0.1.5 (latest: v0.2.1) [INFO] [stderr] Adding bare-metal v0.2.5 (latest: v1.0.0) [INFO] [stderr] Adding bitfield v0.13.2 (latest: v0.16.1) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding cortex-m v0.6.7 (latest: v0.7.7) [INFO] [stderr] Adding cortex-m-rt v0.6.15 (latest: v0.7.3) [INFO] [stderr] Adding cortex-m-rt-macros v0.6.15 (latest: v0.7.0) [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding generic-array v0.13.3 (latest: v1.1.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding r0 v0.2.2 (latest: v1.0.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding stm32f1 v0.9.0 (latest: v0.15.1) [INFO] [stderr] Adding stm32f1xx-hal v0.5.3 (latest: v0.10.0) [INFO] [stderr] Adding stm32l4 v0.8.0 (latest: v0.15.1) [INFO] [stderr] Adding stm32l4xx-hal v0.5.0 (latest: v0.7.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08884d86bea9539ea485455ecd366ac49c6296f61dc895294ced2a2ca422db50 [INFO] running `Command { std: "docker" "start" "-a" "08884d86bea9539ea485455ecd366ac49c6296f61dc895294ced2a2ca422db50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08884d86bea9539ea485455ecd366ac49c6296f61dc895294ced2a2ca422db50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08884d86bea9539ea485455ecd366ac49c6296f61dc895294ced2a2ca422db50", kill_on_drop: false }` [INFO] [stdout] 08884d86bea9539ea485455ecd366ac49c6296f61dc895294ced2a2ca422db50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d947052d60d12249bd21c31425e5a06ac277ea20b486d414f35a271b2240b6f8 [INFO] running `Command { std: "docker" "start" "-a" "d947052d60d12249bd21c31425e5a06ac277ea20b486d414f35a271b2240b6f8", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling cortex-m-rt v0.6.15 [INFO] [stderr] Compiling cortex-m v0.6.7 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling cortex-m-rt-macros v0.6.15 [INFO] [stderr] Checking r0 v0.2.2 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Compiling stm32f1 v0.9.0 [INFO] [stderr] Compiling arraydeque v0.4.5 [INFO] [stderr] Checking cortex-m v0.7.7 [INFO] [stderr] Checking as-slice v0.1.5 [INFO] [stderr] Checking aligned v0.3.5 [INFO] [stderr] Checking stm32f1xx-hal v0.5.3 [INFO] [stderr] Checking embedded-async-timer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Ordering` and `self` [INFO] [stdout] --> src/impls/stm32f103_rtc.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use core::sync::atomic::{self, Ordering}; [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Ordering` and `self` [INFO] [stdout] --> src/impls/stm32f103_rtc.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use core::sync::atomic::{self, Ordering}; [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::sync::atomic::AtomicBool::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:83:34 [INFO] [stdout] | [INFO] [stdout] 83 | let result = self.awoken.compare_and_swap(false, true, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | drop(inner); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut AsyncTimerInner` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 181 - drop(inner); [INFO] [stdout] 181 + let _ = inner; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:14 [INFO] [stdout] | [INFO] [stdout] 216 | pub fn new(timer: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Self(MutMutex::new(AsyncTimerInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 218 | | handles: PriorityQueue::new(), [INFO] [stdout] 219 | | timer, [INFO] [stdout] 220 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:27 [INFO] [stdout] | [INFO] [stdout] 237 | pub unsafe fn get_inner(&self, f: impl FnOnce(&mut T) -> U) -> U { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | T::interrupt_free(|cs| f(&mut self.0.borrow_mut(cs).timer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:39 [INFO] [stdout] | [INFO] [stdout] 237 | pub unsafe fn get_inner(&self, f: impl FnOnce(&mut T) -> U) -> U { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | T::interrupt_free(|cs| f(&mut self.0.borrow_mut(cs).timer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:286:32 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn wait<'a>(&'a self, dur: T::Duration) -> Result, CapacityError> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | self.wait_until_always(future(self.now(), dur)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:322:12 [INFO] [stdout] | [INFO] [stdout] 307 | deadline: T::Instant, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | let handle = Handle { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | Ok(Delay { index, timer: self }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:338:19 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn new(duration: CLOCK::Duration, timer: &AsyncTimer) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | Self { [INFO] [stdout] 338 | last: timer.now(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/mutmutex.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self(Mutex::new(UnsafeCell::new(t))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/util/packed_slab.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | drop(unsafe { &mut *self.buffer[i].as_mut_ptr() }); [INFO] [stdout] | ^^^^^--------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut T` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 110 - drop(unsafe { &mut *self.buffer[i].as_mut_ptr() }); [INFO] [stdout] 110 + let _ = unsafe { &mut *self.buffer[i].as_mut_ptr() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-async-timer` (lib) due to 8 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `core::sync::atomic::AtomicBool::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:83:34 [INFO] [stdout] | [INFO] [stdout] 83 | let result = self.awoken.compare_and_swap(false, true, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | drop(inner); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut AsyncTimerInner` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 181 - drop(inner); [INFO] [stdout] 181 + let _ = inner; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:14 [INFO] [stdout] | [INFO] [stdout] 216 | pub fn new(timer: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Self(MutMutex::new(AsyncTimerInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 218 | | handles: PriorityQueue::new(), [INFO] [stdout] 219 | | timer, [INFO] [stdout] 220 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:27 [INFO] [stdout] | [INFO] [stdout] 237 | pub unsafe fn get_inner(&self, f: impl FnOnce(&mut T) -> U) -> U { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | T::interrupt_free(|cs| f(&mut self.0.borrow_mut(cs).timer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:39 [INFO] [stdout] | [INFO] [stdout] 237 | pub unsafe fn get_inner(&self, f: impl FnOnce(&mut T) -> U) -> U { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | T::interrupt_free(|cs| f(&mut self.0.borrow_mut(cs).timer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:286:32 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn wait<'a>(&'a self, dur: T::Duration) -> Result, CapacityError> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | self.wait_until_always(future(self.now(), dur)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:322:12 [INFO] [stdout] | [INFO] [stdout] 307 | deadline: T::Instant, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | let handle = Handle { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | Ok(Delay { index, timer: self }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:338:19 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn new(duration: CLOCK::Duration, timer: &AsyncTimer) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | Self { [INFO] [stdout] 338 | last: timer.now(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/mutmutex.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self(Mutex::new(UnsafeCell::new(t))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/util/packed_slab.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | drop(unsafe { &mut *self.buffer[i].as_mut_ptr() }); [INFO] [stdout] | ^^^^^--------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut T` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 110 - drop(unsafe { &mut *self.buffer[i].as_mut_ptr() }); [INFO] [stdout] 110 + let _ = unsafe { &mut *self.buffer[i].as_mut_ptr() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embedded-async-timer` (lib test) due to 8 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d947052d60d12249bd21c31425e5a06ac277ea20b486d414f35a271b2240b6f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d947052d60d12249bd21c31425e5a06ac277ea20b486d414f35a271b2240b6f8", kill_on_drop: false }` [INFO] [stdout] d947052d60d12249bd21c31425e5a06ac277ea20b486d414f35a271b2240b6f8