[INFO] fetching crate embassy-usb 0.3.0... [INFO] checking embassy-usb-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embassy-usb 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate embassy-usb 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embassy-usb 0.3.0 [INFO] finished tweaking crates.io crate embassy-usb 0.3.0 [INFO] tweaked toml for crates.io crate embassy-usb 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding bitfield v0.14.0 (latest: v0.16.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08cf2a848ecb00bd3827cc88e1223bcfc77e3753bcee177a752a31793137e1aa [INFO] running `Command { std: "docker" "start" "-a" "08cf2a848ecb00bd3827cc88e1223bcfc77e3753bcee177a752a31793137e1aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08cf2a848ecb00bd3827cc88e1223bcfc77e3753bcee177a752a31793137e1aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08cf2a848ecb00bd3827cc88e1223bcfc77e3753bcee177a752a31793137e1aa", kill_on_drop: false }` [INFO] [stdout] 08cf2a848ecb00bd3827cc88e1223bcfc77e3753bcee177a752a31793137e1aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6d8c85d40a4e9a0ecff98b99498d74c35dcb1bfd8ce6846bd651897a18c0a05 [INFO] running `Command { std: "docker" "start" "-a" "a6d8c85d40a4e9a0ecff98b99498d74c35dcb1bfd8ce6846bd651897a18c0a05", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling embedded-io-async v0.6.1 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling embassy-sync v0.6.0 [INFO] [stderr] Checking embedded-io v0.6.1 [INFO] [stderr] Compiling bitfield v0.14.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling usbd-hid-descriptors v0.8.2 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Compiling hashbrown v0.13.2 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Checking usb-device v0.3.2 [INFO] [stderr] Checking embassy-net-driver v0.2.0 [INFO] [stderr] Compiling embassy-usb v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking embassy-futures v0.1.1 [INFO] [stderr] Checking embassy-usb-driver v0.1.0 [INFO] [stderr] Checking embassy-net-driver-channel v0.3.0 [INFO] [stderr] Checking ssmarshal v1.0.0 [INFO] [stderr] Compiling usbd-hid-macros v0.8.2 [INFO] [stderr] Checking usbd-hid v0.8.2 [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/class/cdc_ncm/embassy_net.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | Either::First(x) => x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ matches no values because `Either` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/class/cdc_ncm/embassy_net.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | Either::Second(x) => x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ matches no values because `Either` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/class/cdc_ncm/embassy_net.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | Either::First(x) => x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ matches no values because `Either` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/class/cdc_ncm/embassy_net.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | Either::Second(x) => x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ matches no values because `Either` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:20 [INFO] [stdout] | [INFO] [stdout] 215 | driver: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | config: Config<'d>, [INFO] [stdout] 217 | handlers: Vec<&'d mut dyn Handler, MAX_HANDLER_COUNT>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | interfaces: Vec, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let (bus, control) = driver.start(config.max_packet_size_0 as u16); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | inner: Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 233 | | bus, [INFO] [stdout] 234 | | config, [INFO] [stdout] 235 | | device_descriptor, [INFO] [stdout] ... | [INFO] [stdout] 247 | | handlers, [INFO] [stdout] 248 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:775:25 [INFO] [stdout] | [INFO] [stdout] 772 | fn first_last(iter: T) -> impl Iterator { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 773 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 774 | let mut first = true; [INFO] [stdout] 775 | core::iter::from_fn(move || { [INFO] [stdout] | _________________________^ [INFO] [stdout] 776 | | let val = iter.next()?; [INFO] [stdout] 777 | | let is_first = first; [INFO] [stdout] 778 | | first = false; [INFO] [stdout] 779 | | let is_last = iter.peek().is_none(); [INFO] [stdout] 780 | | Some((is_first, is_last, val)) [INFO] [stdout] 781 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:780:14 [INFO] [stdout] | [INFO] [stdout] 773 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 776 | let val = iter.next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 780 | Some((is_first, is_last, val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:178:25 [INFO] [stdout] | [INFO] [stdout] 145 | driver: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | interfaces: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:179:23 [INFO] [stdout] | [INFO] [stdout] 145 | driver: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | handlers: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:324:13 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | ( [INFO] [stdout] 324 | / Sender { [INFO] [stdout] 325 | | write_ep: self.write_ep, [INFO] [stdout] 326 | | control: self.control, [INFO] [stdout] 327 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | / Receiver { [INFO] [stdout] 329 | | read_ep: self.read_ep, [INFO] [stdout] 330 | | control: self.control, [INFO] [stdout] 331 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn split_with_control(self) -> (Sender<'d, D>, Receiver<'d, D>, ControlChanged<'d>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | ( [INFO] [stdout] 341 | / Sender { [INFO] [stdout] 342 | | write_ep: self.write_ep, [INFO] [stdout] 343 | | control: self.control, [INFO] [stdout] 344 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn split_with_control(self) -> (Sender<'d, D>, Receiver<'d, D>, ControlChanged<'d>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | / Receiver { [INFO] [stdout] 346 | | read_ep: self.read_ep, [INFO] [stdout] 347 | | control: self.control, [INFO] [stdout] 348 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_ncm/mod.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | ( [INFO] [stdout] 354 | / Sender { [INFO] [stdout] 355 | | write_ep: self.write_ep, [INFO] [stdout] 356 | | seq: 0, [INFO] [stdout] 357 | | max_packet_size: self.max_packet_size, [INFO] [stdout] 358 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_ncm/mod.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | / Receiver { [INFO] [stdout] 360 | | data_if: self.data_if, [INFO] [stdout] 361 | | comm_ep: self.comm_ep, [INFO] [stdout] 362 | | read_ep: self.read_ep, [INFO] [stdout] 363 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_ncm/embassy_net.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 85 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let (tx_usb, rx_usb) = self.split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | / Runner { [INFO] [stdout] 97 | | tx_usb, [INFO] [stdout] 98 | | rx_usb, [INFO] [stdout] 99 | | ch: runner, [INFO] [stdout] 100 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/hid.rs:166:21 [INFO] [stdout] | [INFO] [stdout] 163 | let (ep_out, ep_in, offset) = build(builder, state, config, true); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | reader: HidReader { [INFO] [stdout] | _____________________^ [INFO] [stdout] 167 | | ep_out: ep_out.unwrap(), [INFO] [stdout] 168 | | offset, [INFO] [stdout] 169 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/hid.rs:170:21 [INFO] [stdout] | [INFO] [stdout] 163 | let (ep_out, ep_in, offset) = build(builder, state, config, true); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | writer: HidWriter { ep_in }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/midi.rs:171:13 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ( [INFO] [stdout] 171 | / Sender { [INFO] [stdout] 172 | | write_ep: self.write_ep, [INFO] [stdout] 173 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/midi.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Receiver { read_ep: self.read_ep }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embassy-usb` (lib test) due to 17 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:20 [INFO] [stdout] | [INFO] [stdout] 215 | driver: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | config: Config<'d>, [INFO] [stdout] 217 | handlers: Vec<&'d mut dyn Handler, MAX_HANDLER_COUNT>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | interfaces: Vec, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let (bus, control) = driver.start(config.max_packet_size_0 as u16); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | inner: Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 233 | | bus, [INFO] [stdout] 234 | | config, [INFO] [stdout] 235 | | device_descriptor, [INFO] [stdout] ... | [INFO] [stdout] 247 | | handlers, [INFO] [stdout] 248 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:775:25 [INFO] [stdout] | [INFO] [stdout] 772 | fn first_last(iter: T) -> impl Iterator { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 773 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 774 | let mut first = true; [INFO] [stdout] 775 | core::iter::from_fn(move || { [INFO] [stdout] | _________________________^ [INFO] [stdout] 776 | | let val = iter.next()?; [INFO] [stdout] 777 | | let is_first = first; [INFO] [stdout] 778 | | first = false; [INFO] [stdout] 779 | | let is_last = iter.peek().is_none(); [INFO] [stdout] 780 | | Some((is_first, is_last, val)) [INFO] [stdout] 781 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:780:14 [INFO] [stdout] | [INFO] [stdout] 773 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 776 | let val = iter.next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 780 | Some((is_first, is_last, val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:178:25 [INFO] [stdout] | [INFO] [stdout] 145 | driver: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | interfaces: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:179:23 [INFO] [stdout] | [INFO] [stdout] 145 | driver: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | handlers: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:324:13 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | ( [INFO] [stdout] 324 | / Sender { [INFO] [stdout] 325 | | write_ep: self.write_ep, [INFO] [stdout] 326 | | control: self.control, [INFO] [stdout] 327 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | / Receiver { [INFO] [stdout] 329 | | read_ep: self.read_ep, [INFO] [stdout] 330 | | control: self.control, [INFO] [stdout] 331 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn split_with_control(self) -> (Sender<'d, D>, Receiver<'d, D>, ControlChanged<'d>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | ( [INFO] [stdout] 341 | / Sender { [INFO] [stdout] 342 | | write_ep: self.write_ep, [INFO] [stdout] 343 | | control: self.control, [INFO] [stdout] 344 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_acm.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn split_with_control(self) -> (Sender<'d, D>, Receiver<'d, D>, ControlChanged<'d>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | / Receiver { [INFO] [stdout] 346 | | read_ep: self.read_ep, [INFO] [stdout] 347 | | control: self.control, [INFO] [stdout] 348 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_ncm/mod.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | ( [INFO] [stdout] 354 | / Sender { [INFO] [stdout] 355 | | write_ep: self.write_ep, [INFO] [stdout] 356 | | seq: 0, [INFO] [stdout] 357 | | max_packet_size: self.max_packet_size, [INFO] [stdout] 358 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_ncm/mod.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | / Receiver { [INFO] [stdout] 360 | | data_if: self.data_if, [INFO] [stdout] 361 | | comm_ep: self.comm_ep, [INFO] [stdout] 362 | | read_ep: self.read_ep, [INFO] [stdout] 363 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/cdc_ncm/embassy_net.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 85 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let (tx_usb, rx_usb) = self.split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | / Runner { [INFO] [stdout] 97 | | tx_usb, [INFO] [stdout] 98 | | rx_usb, [INFO] [stdout] 99 | | ch: runner, [INFO] [stdout] 100 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/hid.rs:166:21 [INFO] [stdout] | [INFO] [stdout] 163 | let (ep_out, ep_in, offset) = build(builder, state, config, true); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | reader: HidReader { [INFO] [stdout] | _____________________^ [INFO] [stdout] 167 | | ep_out: ep_out.unwrap(), [INFO] [stdout] 168 | | offset, [INFO] [stdout] 169 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/hid.rs:170:21 [INFO] [stdout] | [INFO] [stdout] 163 | let (ep_out, ep_in, offset) = build(builder, state, config, true); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | writer: HidWriter { ep_in }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/midi.rs:171:13 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ( [INFO] [stdout] 171 | / Sender { [INFO] [stdout] 172 | | write_ep: self.write_ep, [INFO] [stdout] 173 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/class/midi.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn split(self) -> (Sender<'d, D>, Receiver<'d, D>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Receiver { read_ep: self.read_ep }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embassy-usb` (lib) due to 17 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a6d8c85d40a4e9a0ecff98b99498d74c35dcb1bfd8ce6846bd651897a18c0a05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6d8c85d40a4e9a0ecff98b99498d74c35dcb1bfd8ce6846bd651897a18c0a05", kill_on_drop: false }` [INFO] [stdout] a6d8c85d40a4e9a0ecff98b99498d74c35dcb1bfd8ce6846bd651897a18c0a05