[INFO] fetching crate embassy-embedded-hal 0.2.0... [INFO] checking embassy-embedded-hal-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate embassy-embedded-hal 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate embassy-embedded-hal 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embassy-embedded-hal 0.2.0 [INFO] finished tweaking crates.io crate embassy-embedded-hal 0.2.0 [INFO] tweaked toml for crates.io crate embassy-embedded-hal 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 918e4606ce782d030f08a709872382d41d2cc7c80807b9ce02366d6554b899af [INFO] running `Command { std: "docker" "start" "-a" "918e4606ce782d030f08a709872382d41d2cc7c80807b9ce02366d6554b899af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "918e4606ce782d030f08a709872382d41d2cc7c80807b9ce02366d6554b899af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "918e4606ce782d030f08a709872382d41d2cc7c80807b9ce02366d6554b899af", kill_on_drop: false }` [INFO] [stdout] 918e4606ce782d030f08a709872382d41d2cc7c80807b9ce02366d6554b899af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ded9f2da0aa21d0578b0fef237dd434e255b7bcc771a4f3625b5f48395e9f79b [INFO] running `Command { std: "docker" "start" "-a" "ded9f2da0aa21d0578b0fef237dd434e255b7bcc771a4f3625b5f48395e9f79b", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling embedded-io-async v0.6.1 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Compiling embassy-time-driver v0.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling embassy-time-queue-driver v0.1.0 [INFO] [stderr] Compiling embedded-hal-async v1.0.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking embedded-hal v1.0.0 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Checking embedded-io v0.6.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling embassy-sync v0.6.0 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking embedded-storage v0.3.1 [INFO] [stderr] Checking embassy-futures v0.1.1 [INFO] [stderr] Checking embedded-storage-async v0.4.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking embassy-time v0.3.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking embassy-embedded-hal v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | .lock(|bus| bus.borrow_mut().read(address, buffer).map_err(I2cDeviceError::I2c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | .lock(|bus| bus.borrow_mut().write(address, bytes).map_err(I2cDeviceError::I2c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:87:25 [INFO] [stdout] | [INFO] [stdout] 87 | .lock(|bus| bus.borrow_mut().write(addr, bytes).map_err(I2cDeviceError::I2c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | .lock(|bus| bus.borrow_mut().read(addr, bytes).map_err(I2cDeviceError::I2c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 157 | let mut bus = bus.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | bus.set_config(&self.config).map_err(|_| I2cDeviceError::Config)?; [INFO] [stdout] 159 | bus.read(address, buffer).map_err(I2cDeviceError::I2c) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 165 | let mut bus = bus.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | bus.set_config(&self.config).map_err(|_| I2cDeviceError::Config)?; [INFO] [stdout] 167 | bus.write(address, bytes).map_err(I2cDeviceError::I2c) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 173 | let mut bus = bus.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | bus.set_config(&self.config).map_err(|_| I2cDeviceError::Config)?; [INFO] [stdout] 175 | bus.write_read(address, wr_buffer, rd_buffer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_bus/blocking/i2c.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 182 | let mut bus = bus.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | bus.set_config(&self.config).map_err(|_| I2cDeviceError::Config)?; [INFO] [stdout] 184 | bus.transaction(address, operations).map_err(I2cDeviceError::I2c) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `embassy-embedded-hal` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ded9f2da0aa21d0578b0fef237dd434e255b7bcc771a4f3625b5f48395e9f79b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ded9f2da0aa21d0578b0fef237dd434e255b7bcc771a4f3625b5f48395e9f79b", kill_on_drop: false }` [INFO] [stdout] ded9f2da0aa21d0578b0fef237dd434e255b7bcc771a4f3625b5f48395e9f79b