[INFO] fetching crate elastictea 2.0.0... [INFO] checking elastictea-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate elastictea 2.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate elastictea 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate elastictea 2.0.0 [INFO] finished tweaking crates.io crate elastictea 2.0.0 [INFO] tweaked toml for crates.io crate elastictea 2.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate elastictea 2.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d5b09b0b580d584d705483d163b2ff67b789be68c24cb04504d7364c1c916bb4 [INFO] running `Command { std: "docker" "start" "-a" "d5b09b0b580d584d705483d163b2ff67b789be68c24cb04504d7364c1c916bb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d5b09b0b580d584d705483d163b2ff67b789be68c24cb04504d7364c1c916bb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5b09b0b580d584d705483d163b2ff67b789be68c24cb04504d7364c1c916bb4", kill_on_drop: false }` [INFO] [stdout] d5b09b0b580d584d705483d163b2ff67b789be68c24cb04504d7364c1c916bb4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f4d11a58fa45f4d86b692c94487388bca0f3ac5072bcfe8ead28f515b2e2902 [INFO] running `Command { std: "docker" "start" "-a" "1f4d11a58fa45f4d86b692c94487388bca0f3ac5072bcfe8ead28f515b2e2902", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.58 [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.39 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking futures v0.1.28 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling serde v1.0.94 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking spin v0.5.0 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling libm v0.1.4 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Compiling ring v0.14.6 [INFO] [stderr] Compiling backtrace-sys v0.1.30 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Checking http v0.1.17 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling cgmath v0.17.0 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking tokio-executor v0.1.7 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking tokio-sync v0.1.6 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking matrixmultiply v0.2.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling unicase v2.4.0 [INFO] [stderr] Checking alga v0.9.1 [INFO] [stderr] Compiling error-chain v0.12.1 [INFO] [stderr] Checking backtrace v0.3.32 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-threadpool v0.1.14 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling httparse v1.3.3 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tokio-reactor v0.1.9 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling regex v1.1.7 [INFO] [stderr] Checking nalgebra v0.18.0 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking regex-syntax v0.6.7 [INFO] [stderr] Checking tokio-fs v0.1.6 [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking tokio-timer v0.2.11 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Compiling miniz_oxide_c_api v0.2.2 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking tokio-trace-core v0.2.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling hyper v0.12.31 [INFO] [stderr] Checking pdqselect v0.1.0 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Compiling quick-error v1.2.2 [INFO] [stderr] Compiling nom v2.2.1 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking clamp v0.1.0 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking tokio v0.1.21 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking miniz_oxide v0.2.2 [INFO] [stderr] Checking crc32fast v1.2.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Compiling encoding_rs v0.8.17 [INFO] [stderr] Checking mime v0.3.13 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Checking try_from v0.3.2 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking h2 v0.1.25 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking dtoa v0.4.4 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking elastic_requests v0.21.0-pre.4 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking crossbeam-channel v0.3.8 [INFO] [stderr] Checking flate2 v1.0.9 [INFO] [stderr] Checking fluent_builder v0.5.0 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking sct v0.5.0 [INFO] [stderr] Checking webpki v0.19.1 [INFO] [stderr] Checking ct-logs v0.5.1 [INFO] [stderr] Compiling serde_derive v1.0.94 [INFO] [stderr] Checking rustls v0.15.2 [INFO] [stderr] Checking webpki-roots v0.16.0 [INFO] [stderr] Checking publicsuffix v1.5.2 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking tokio-rustls v0.9.3 [INFO] [stderr] Checking hyper-rustls v0.16.1 [INFO] [stderr] Checking spade v1.8.0 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking geo v0.4.13 [INFO] [stderr] Checking chrono v0.4.7 [INFO] [stderr] Checking serde_urlencoded v0.5.5 [INFO] [stderr] Checking geo v0.6.3 [INFO] [stderr] Checking geohash v0.4.0 [INFO] [stderr] Checking cookie_store v0.7.0 [INFO] [stderr] Checking geojson v0.9.1 [INFO] [stderr] Checking elastic_responses v0.21.0-pre.4 [INFO] [stderr] Checking rettle v2.0.0 [INFO] [stderr] Checking reqwest v0.9.18 [INFO] [stderr] Compiling elastic_types_derive_internals v0.21.0-pre.4 [INFO] [stderr] Compiling elastic_types_derive v0.21.0-pre.4 [INFO] [stderr] Compiling elastic_derive v0.21.0-pre.4 [INFO] [stderr] Checking elastic_types v0.21.0-pre.4 [INFO] [stderr] Checking elastic v0.21.0-pre.4 [INFO] [stderr] Checking elastictea v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fill.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(name: &str, source: &str, params: FillEsArg) -> Box> [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Box::new(Fill { [INFO] [stdout] | __________________^ [INFO] [stdout] 68 | | name: String::from(name), [INFO] [stdout] 69 | | source: String::from(source), [INFO] [stdout] 70 | | computation: Box::new(|args, brewery, recipe| { [INFO] [stdout] ... | [INFO] [stdout] 73 | | params: Some(Box::new(params)) [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pour.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(name: &str, params: PourEsArg) -> Box> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Box::new(Pour { [INFO] [stdout] | __________________^ [INFO] [stdout] 59 | | name: String::from(name), [INFO] [stdout] 60 | | computation: Box::new(|tea_batch, args| { [INFO] [stdout] 61 | | pour_to_es::(tea_batch, args) [INFO] [stdout] 62 | | }), [INFO] [stdout] 63 | | params: Some(Box::new(params)) [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `elastictea` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `name` and `value` are never read [INFO] [stdout] --> src/fill.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 175 | struct TestEsTea { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 176 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 177 | value: i32 [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestEsTea` has derived impls for the traits `Default`, `Debug`, and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fill.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(name: &str, source: &str, params: FillEsArg) -> Box> [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Box::new(Fill { [INFO] [stdout] | __________________^ [INFO] [stdout] 68 | | name: String::from(name), [INFO] [stdout] 69 | | source: String::from(source), [INFO] [stdout] 70 | | computation: Box::new(|args, brewery, recipe| { [INFO] [stdout] ... | [INFO] [stdout] 73 | | params: Some(Box::new(params)) [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pour.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(name: &str, params: PourEsArg) -> Box> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Box::new(Pour { [INFO] [stdout] | __________________^ [INFO] [stdout] 59 | | name: String::from(name), [INFO] [stdout] 60 | | computation: Box::new(|tea_batch, args| { [INFO] [stdout] 61 | | pour_to_es::(tea_batch, args) [INFO] [stdout] 62 | | }), [INFO] [stdout] 63 | | params: Some(Box::new(params)) [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `elastictea` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1f4d11a58fa45f4d86b692c94487388bca0f3ac5072bcfe8ead28f515b2e2902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f4d11a58fa45f4d86b692c94487388bca0f3ac5072bcfe8ead28f515b2e2902", kill_on_drop: false }` [INFO] [stdout] 1f4d11a58fa45f4d86b692c94487388bca0f3ac5072bcfe8ead28f515b2e2902