[INFO] fetching crate either 1.13.0... [INFO] checking either-1.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate either 1.13.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate either 1.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate either 1.13.0 [INFO] finished tweaking crates.io crate either 1.13.0 [INFO] tweaked toml for crates.io crate either 1.13.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8138a3723d66351ffc6afd27bc15c3bafa1dbfd04d3e9b89551ea825cd9a3b07 [INFO] running `Command { std: "docker" "start" "-a" "8138a3723d66351ffc6afd27bc15c3bafa1dbfd04d3e9b89551ea825cd9a3b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8138a3723d66351ffc6afd27bc15c3bafa1dbfd04d3e9b89551ea825cd9a3b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8138a3723d66351ffc6afd27bc15c3bafa1dbfd04d3e9b89551ea825cd9a3b07", kill_on_drop: false }` [INFO] [stdout] 8138a3723d66351ffc6afd27bc15c3bafa1dbfd04d3e9b89551ea825cd9a3b07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d838d9497421889b4605c8ab257cdd826bd5b508916668ab28a8e35321f34d4c [INFO] running `Command { std: "docker" "start" "-a" "d838d9497421889b4605c8ab257cdd826bd5b508916668ab28a8e35321f34d4c", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking either v1.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | / match $value { [INFO] [stdout] 136 | | Left($pattern) => Left($result), [INFO] [stdout] 137 | | Right($pattern) => Right($result), [INFO] [stdout] 138 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 615 | pub fn factor_into_iter(self) -> IterEither [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | IterEither::new(map_either!(self, inner => inner.into_iter())) [INFO] [stdout] | --------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `map_either` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | / match $value { [INFO] [stdout] 136 | | Left($pattern) => Left($result), [INFO] [stdout] 137 | | Right($pattern) => Right($result), [INFO] [stdout] 138 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/iterator.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | fn last(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | Some(map_either!(self.inner, inner => inner.last()?)) [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `map_either` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `either` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d838d9497421889b4605c8ab257cdd826bd5b508916668ab28a8e35321f34d4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d838d9497421889b4605c8ab257cdd826bd5b508916668ab28a8e35321f34d4c", kill_on_drop: false }` [INFO] [stdout] d838d9497421889b4605c8ab257cdd826bd5b508916668ab28a8e35321f34d4c