[INFO] fetching crate eggmine 3.4.1... [INFO] checking eggmine-3.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate eggmine 3.4.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate eggmine 3.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate eggmine 3.4.1 [INFO] finished tweaking crates.io crate eggmine 3.4.1 [INFO] tweaked toml for crates.io crate eggmine 3.4.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate eggmine 3.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad6f8f1d7ffc18e247256f3d73bffe1bc82d4364f3ff0b5fb5692f0c53adbcc6 [INFO] running `Command { std: "docker" "start" "-a" "ad6f8f1d7ffc18e247256f3d73bffe1bc82d4364f3ff0b5fb5692f0c53adbcc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad6f8f1d7ffc18e247256f3d73bffe1bc82d4364f3ff0b5fb5692f0c53adbcc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad6f8f1d7ffc18e247256f3d73bffe1bc82d4364f3ff0b5fb5692f0c53adbcc6", kill_on_drop: false }` [INFO] [stdout] ad6f8f1d7ffc18e247256f3d73bffe1bc82d4364f3ff0b5fb5692f0c53adbcc6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8937e212da29dd53e2952fd2f142fca68f6e2a680a5f4e0d4dd282517e857a35 [INFO] running `Command { std: "docker" "start" "-a" "8937e212da29dd53e2952fd2f142fca68f6e2a680a5f4e0d4dd282517e857a35", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling portable-atomic v0.3.19 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking console v0.15.5 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking rayon-core v1.11.0 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking num-complex v0.4.3 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking fraction v0.13.1 [INFO] [stderr] Checking indicatif v0.17.3 [INFO] [stderr] Checking eggmine v3.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_io.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | for mut c in &mut candidates { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_io.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 20 | fn read_headers(f: File) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let mut lines = io::BufReader::new(f).lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok((sep, total, candidates, lines)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_io.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 115 | let f = File::open(Path::new(path).join(format!("{}.tsv", filename))).unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | File::open(Path::new(path).join(format!("{}.csv", filename))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_io.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | for mut c in &mut candidates { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eggmine` (bin "eggmine") due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_io.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 20 | fn read_headers(f: File) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let mut lines = io::BufReader::new(f).lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok((sep, total, candidates, lines)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_io.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 115 | let f = File::open(Path::new(path).join(format!("{}.tsv", filename))).unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | File::open(Path::new(path).join(format!("{}.csv", filename))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eggmine` (bin "eggmine" test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8937e212da29dd53e2952fd2f142fca68f6e2a680a5f4e0d4dd282517e857a35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8937e212da29dd53e2952fd2f142fca68f6e2a680a5f4e0d4dd282517e857a35", kill_on_drop: false }` [INFO] [stdout] 8937e212da29dd53e2952fd2f142fca68f6e2a680a5f4e0d4dd282517e857a35