[INFO] fetching crate efivar 2.0.0... [INFO] checking efivar-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate efivar 2.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate efivar 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate efivar 2.0.0 [INFO] finished tweaking crates.io crate efivar 2.0.0 [INFO] tweaked toml for crates.io crate efivar 2.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d80a77f70fbbbb53789b72556fb578061b9c4ea413ae96f01038ea340b72d09 [INFO] running `Command { std: "docker" "start" "-a" "0d80a77f70fbbbb53789b72556fb578061b9c4ea413ae96f01038ea340b72d09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d80a77f70fbbbb53789b72556fb578061b9c4ea413ae96f01038ea340b72d09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d80a77f70fbbbb53789b72556fb578061b9c4ea413ae96f01038ea340b72d09", kill_on_drop: false }` [INFO] [stdout] 0d80a77f70fbbbb53789b72556fb578061b9c4ea413ae96f01038ea340b72d09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ccc260fa6969e22f8eb98e15cf25f0773bd6caaad8828db47250ffbbcbebfe64 [INFO] running `Command { std: "docker" "start" "-a" "ccc260fa6969e22f8eb98e15cf25f0773bd6caaad8828db47250ffbbcbebfe64", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Compiling ntapi v0.4.1 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking version-sync v0.9.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking efivar v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boot/boot_entry_iter.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 35 | let boot_var_res = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Some((boot_var_res, var)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivarfs.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 36 | list.filter_map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | / result [INFO] [stdout] 38 | | .map_err(Error::UnknownIoError) [INFO] [stdout] 39 | | .and_then(|entry| { [INFO] [stdout] 40 | | entry [INFO] [stdout] ... | [INFO] [stdout] 44 | | .and_then(|s| Variable::from_str(&s)) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivarfs.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / entry [INFO] [stdout] 41 | | .file_name() [INFO] [stdout] 42 | | .into_string() [INFO] [stdout] 43 | | .map_err(|_str| Error::InvalidUTF8) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivars.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|list| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / list.filter_map(Result::ok) [INFO] [stdout] 35 | | .filter(|entry| match entry.file_type() { [INFO] [stdout] 36 | | Ok(file_type) => file_type.is_dir(), [INFO] [stdout] 37 | | _ => false, [INFO] [stdout] 38 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivars.rs:35:43 [INFO] [stdout] | [INFO] [stdout] 35 | .filter(|entry| match entry.file_type() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivars.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 39 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / entry [INFO] [stdout] 41 | | .file_name() [INFO] [stdout] 42 | | .into_string() [INFO] [stdout] 43 | | .map_err(|_str| Error::InvalidUTF8) [INFO] [stdout] 44 | | .and_then(|s| Variable::from_str(&s)) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `efivar` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boot/boot_entry_iter.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 35 | let boot_var_res = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Some((boot_var_res, var)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivarfs.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 36 | list.filter_map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | / result [INFO] [stdout] 38 | | .map_err(Error::UnknownIoError) [INFO] [stdout] 39 | | .and_then(|entry| { [INFO] [stdout] 40 | | entry [INFO] [stdout] ... | [INFO] [stdout] 44 | | .and_then(|s| Variable::from_str(&s)) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivarfs.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / entry [INFO] [stdout] 41 | | .file_name() [INFO] [stdout] 42 | | .into_string() [INFO] [stdout] 43 | | .map_err(|_str| Error::InvalidUTF8) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivars.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|list| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / list.filter_map(Result::ok) [INFO] [stdout] 35 | | .filter(|entry| match entry.file_type() { [INFO] [stdout] 36 | | Ok(file_type) => file_type.is_dir(), [INFO] [stdout] 37 | | _ => false, [INFO] [stdout] 38 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivars.rs:35:43 [INFO] [stdout] | [INFO] [stdout] 35 | .filter(|entry| match entry.file_type() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/linux/efivars.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 39 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / entry [INFO] [stdout] 41 | | .file_name() [INFO] [stdout] 42 | | .into_string() [INFO] [stdout] 43 | | .map_err(|_str| Error::InvalidUTF8) [INFO] [stdout] 44 | | .and_then(|s| Variable::from_str(&s)) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `efivar` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "ccc260fa6969e22f8eb98e15cf25f0773bd6caaad8828db47250ffbbcbebfe64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccc260fa6969e22f8eb98e15cf25f0773bd6caaad8828db47250ffbbcbebfe64", kill_on_drop: false }` [INFO] [stdout] ccc260fa6969e22f8eb98e15cf25f0773bd6caaad8828db47250ffbbcbebfe64