[INFO] fetching crate efiloader 0.0.1... [INFO] checking efiloader-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate efiloader 0.0.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate efiloader 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate efiloader 0.0.1 [INFO] finished tweaking crates.io crate efiloader 0.0.1 [INFO] tweaked toml for crates.io crate efiloader 0.0.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding spinning_top v0.2.5 (latest: v0.3.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c797b49c42519cc29d08dac4e82ebe01b1a97025697c206509cf4ba7165610d2 [INFO] running `Command { std: "docker" "start" "-a" "c797b49c42519cc29d08dac4e82ebe01b1a97025697c206509cf4ba7165610d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c797b49c42519cc29d08dac4e82ebe01b1a97025697c206509cf4ba7165610d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c797b49c42519cc29d08dac4e82ebe01b1a97025697c206509cf4ba7165610d2", kill_on_drop: false }` [INFO] [stdout] c797b49c42519cc29d08dac4e82ebe01b1a97025697c206509cf4ba7165610d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0bf5ad3dbbbd30b32107223fec69c34d136db1c2a5e71f5ac98dbdb2023a240c [INFO] running `Command { std: "docker" "start" "-a" "0bf5ad3dbbbd30b32107223fec69c34d136db1c2a5e71f5ac98dbdb2023a240c", kill_on_drop: false }` [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking const-utf16 v0.2.1 [INFO] [stderr] Checking widestring v1.1.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking spinning_top v0.2.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking linked_list_allocator v0.10.5 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking efiloader v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:5 [INFO] [stdout] | [INFO] [stdout] 320 | mapper: impl MemoryMapper + 'static, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | rng: Option, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | ) -> Result<&'static EfiContext, ()> { [INFO] [stdout] 323 | EFI.0.get_or_try_init(move || { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:27 [INFO] [stdout] | [INFO] [stdout] 320 | mapper: impl MemoryMapper + 'static, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | rng: Option, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | ) -> Result<&'static EfiContext, ()> { [INFO] [stdout] 323 | EFI.0.get_or_try_init(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 324 | | let conhandle = new_handle(); [INFO] [stdout] 325 | | let inp = SimpleTextInput::new(EfiContext::read_byte); [INFO] [stdout] 326 | | let out = SimpleTextOutput::new(EfiContext::write_string); [INFO] [stdout] ... | [INFO] [stdout] 376 | | Ok(ctx) [INFO] [stdout] 377 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:347:30 [INFO] [stdout] | [INFO] [stdout] 347 | rng: rng.map(|r| Box::new(r) as _), [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockio.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(loader: impl FileLoader + Send + 'static) -> Result { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut m = Box::new(EfiBlockIoMedia { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(EfiBlockIoProtocol { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | revision: EFI_BLOCK_IO_PROTOCOL_REVISION, [INFO] [stdout] 87 | | media: &mut *m as *mut _, [INFO] [stdout] 88 | | reset: reset, [INFO] [stdout] ... | [INFO] [stdout] 94 | | _media: m, [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memmap.rs:567:12 [INFO] [stdout] | [INFO] [stdout] 561 | pub(crate) fn box_new(&self, memtype: EfiMemoryType, value: T) -> Result, &str> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 567 | Ok(PoolBox(Some(p))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `efiloader` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:5 [INFO] [stdout] | [INFO] [stdout] 320 | mapper: impl MemoryMapper + 'static, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | rng: Option, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | ) -> Result<&'static EfiContext, ()> { [INFO] [stdout] 323 | EFI.0.get_or_try_init(move || { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:27 [INFO] [stdout] | [INFO] [stdout] 320 | mapper: impl MemoryMapper + 'static, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | rng: Option, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | ) -> Result<&'static EfiContext, ()> { [INFO] [stdout] 323 | EFI.0.get_or_try_init(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 324 | | let conhandle = new_handle(); [INFO] [stdout] 325 | | let inp = SimpleTextInput::new(EfiContext::read_byte); [INFO] [stdout] 326 | | let out = SimpleTextOutput::new(EfiContext::write_string); [INFO] [stdout] ... | [INFO] [stdout] 376 | | Ok(ctx) [INFO] [stdout] 377 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:347:30 [INFO] [stdout] | [INFO] [stdout] 347 | rng: rng.map(|r| Box::new(r) as _), [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blockio.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(loader: impl FileLoader + Send + 'static) -> Result { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut m = Box::new(EfiBlockIoMedia { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(EfiBlockIoProtocol { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | revision: EFI_BLOCK_IO_PROTOCOL_REVISION, [INFO] [stdout] 87 | | media: &mut *m as *mut _, [INFO] [stdout] 88 | | reset: reset, [INFO] [stdout] ... | [INFO] [stdout] 94 | | _media: m, [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memmap.rs:567:12 [INFO] [stdout] | [INFO] [stdout] 561 | pub(crate) fn box_new(&self, memtype: EfiMemoryType, value: T) -> Result, &str> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 567 | Ok(PoolBox(Some(p))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `efiloader` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "0bf5ad3dbbbd30b32107223fec69c34d136db1c2a5e71f5ac98dbdb2023a240c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bf5ad3dbbbd30b32107223fec69c34d136db1c2a5e71f5ac98dbdb2023a240c", kill_on_drop: false }` [INFO] [stdout] 0bf5ad3dbbbd30b32107223fec69c34d136db1c2a5e71f5ac98dbdb2023a240c