[INFO] fetching crate editpe 0.1.0... [INFO] checking editpe-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate editpe 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate editpe 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate editpe 0.1.0 [INFO] finished tweaking crates.io crate editpe 0.1.0 [INFO] tweaked toml for crates.io crate editpe 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 57 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b686c496a170f9a964c77100d5786baaf6006fe7ba86ce37e023b7f5c8a4a6a [INFO] running `Command { std: "docker" "start" "-a" "4b686c496a170f9a964c77100d5786baaf6006fe7ba86ce37e023b7f5c8a4a6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b686c496a170f9a964c77100d5786baaf6006fe7ba86ce37e023b7f5c8a4a6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b686c496a170f9a964c77100d5786baaf6006fe7ba86ce37e023b7f5c8a4a6a", kill_on_drop: false }` [INFO] [stdout] 4b686c496a170f9a964c77100d5786baaf6006fe7ba86ce37e023b7f5c8a4a6a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a098a0b25cf499276a571b42d20484ca5c8b91cbae9e67c9ba2e44835d9905de [INFO] running `Command { std: "docker" "start" "-a" "a098a0b25cf499276a571b42d20484ca5c8b91cbae9e67c9ba2e44835d9905de", kill_on_drop: false }` [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking debug-ignore v1.0.5 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking editpe v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `indexmap::IndexSet::::remove`: `remove` disrupts the set order -- use `swap_remove` or `shift_remove` for explicit behavior. [INFO] [stdout] --> src/resource.rs:349:33 [INFO] [stdout] | [INFO] [stdout] 349 | icons_to_remove.remove(&icon_id); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `indexmap::IndexMap::::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior. [INFO] [stdout] --> src/resource.rs:992:43 [INFO] [stdout] | [INFO] [stdout] 992 | if let Some(entry) = self.entries.remove(name) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `indexmap::IndexSet::::remove`: `remove` disrupts the set order -- use `swap_remove` or `shift_remove` for explicit behavior. [INFO] [stdout] --> src/resource.rs:349:33 [INFO] [stdout] | [INFO] [stdout] 349 | icons_to_remove.remove(&icon_id); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `indexmap::IndexMap::::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior. [INFO] [stdout] --> src/resource.rs:992:43 [INFO] [stdout] | [INFO] [stdout] 992 | if let Some(entry) = self.entries.remove(name) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn parse>>(image: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut header_data_directory = IndexMap::::new(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let mut resource_directory = None; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | image, [INFO] [stdout] 219 | | pe_dos_magic, [INFO] [stdout] 220 | | pe_signature, [INFO] [stdout] ... | [INFO] [stdout] 229 | | directories_offset, [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | let root = ResourceTable::parse(image, base_address, virtual_address, 0, 0)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | virtual_address, [INFO] [stdout] 38 | | root, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:803:12 [INFO] [stdout] | [INFO] [stdout] 736 | let mut entries = IndexMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 803 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 804 | | data: resource_table, [INFO] [stdout] 805 | | entries, [INFO] [stdout] 806 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:1375:12 [INFO] [stdout] | [INFO] [stdout] 1278 | let mut strings = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1375 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1376 | | info, [INFO] [stdout] 1377 | | strings, [INFO] [stdout] 1378 | | vars, [INFO] [stdout] 1379 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `editpe` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn parse>>(image: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut header_data_directory = IndexMap::::new(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let mut resource_directory = None; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | image, [INFO] [stdout] 219 | | pe_dos_magic, [INFO] [stdout] 220 | | pe_signature, [INFO] [stdout] ... | [INFO] [stdout] 229 | | directories_offset, [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | let root = ResourceTable::parse(image, base_address, virtual_address, 0, 0)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | virtual_address, [INFO] [stdout] 38 | | root, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:803:12 [INFO] [stdout] | [INFO] [stdout] 736 | let mut entries = IndexMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 803 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 804 | | data: resource_table, [INFO] [stdout] 805 | | entries, [INFO] [stdout] 806 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:1375:12 [INFO] [stdout] | [INFO] [stdout] 1278 | let mut strings = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1375 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1376 | | info, [INFO] [stdout] 1377 | | strings, [INFO] [stdout] 1378 | | vars, [INFO] [stdout] 1379 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `editpe` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a098a0b25cf499276a571b42d20484ca5c8b91cbae9e67c9ba2e44835d9905de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a098a0b25cf499276a571b42d20484ca5c8b91cbae9e67c9ba2e44835d9905de", kill_on_drop: false }` [INFO] [stdout] a098a0b25cf499276a571b42d20484ca5c8b91cbae9e67c9ba2e44835d9905de