[INFO] fetching crate editorconfiger 0.4.10... [INFO] checking editorconfiger-0.4.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate editorconfiger 0.4.10 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate editorconfiger 0.4.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate editorconfiger 0.4.10 [INFO] finished tweaking crates.io crate editorconfiger 0.4.10 [INFO] tweaked toml for crates.io crate editorconfiger 0.4.10 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate editorconfiger 0.4.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9f720168cbf491b09dfdd51236323b0f56aac6dc742a0696be8d24f88fe52c9 [INFO] running `Command { std: "docker" "start" "-a" "c9f720168cbf491b09dfdd51236323b0f56aac6dc742a0696be8d24f88fe52c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9f720168cbf491b09dfdd51236323b0f56aac6dc742a0696be8d24f88fe52c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9f720168cbf491b09dfdd51236323b0f56aac6dc742a0696be8d24f88fe52c9", kill_on_drop: false }` [INFO] [stdout] c9f720168cbf491b09dfdd51236323b0f56aac6dc742a0696be8d24f88fe52c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7babfbd3b16b0873ce920209e7a0dc649ab8c6ecda17d3732c30f6313950c26a [INFO] running `Command { std: "docker" "start" "-a" "7babfbd3b16b0873ce920209e7a0dc649ab8c6ecda17d3732c30f6313950c26a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.140 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling smallvec v1.8.0 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling semver v1.0.7 [INFO] [stderr] Compiling syn v1.0.107 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling rayon-core v1.9.2 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.5 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling once_cell v1.12.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling bit-set v0.5.2 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling ena v0.14.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling rayon v1.5.2 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling pico-args v0.5.0 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling rstest_macros v0.21.0 [INFO] [stderr] Compiling syn v2.0.23 [INFO] [stderr] Compiling relative-path v1.8.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling petgraph v0.6.3 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Compiling parking_lot v0.12.0 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking table-test v0.2.1 [INFO] [stderr] Compiling regex-automata v0.4.5 [INFO] [stderr] Compiling string_cache v0.8.4 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking jwalk v0.8.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking lalrpop-util v0.20.2 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling lalrpop v0.20.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking rstest v0.21.0 [INFO] [stderr] Compiling editorconfiger v0.4.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 279 | let parallelism = Parallelism::RayonNewPool(num_cpus::get_physical()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let iter = WalkDir::new(root) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | / iter.into_iter() [INFO] [stdout] 288 | | .filter_map(std::result::Result::ok) [INFO] [stdout] 289 | | .filter(|f| f.file_type().is_file()) [INFO] [stdout] 290 | | .map(|f| f.path()) [INFO] [stdout] 291 | | .filter(|p| p.ends_with(EDITOR_CONFIG)) [INFO] [stdout] 292 | | .map(|f| f.to_str().unwrap_or("").to_string()) [INFO] [stdout] 293 | | .inspect(|p| validate_one(p, formatter, err)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editorconfig/lexer.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 91 | let parser = sequence::preceded(complete::char('['), is_not("\n\r;#")); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / combinator::map_res(parser, |val: &str| match val.rfind(']') { [INFO] [stdout] 95 | | Some(ix) => Ok(Token::Head(&val[..ix])), [INFO] [stdout] 96 | | None => Err(nom::Err::Failure(']')), [INFO] [stdout] 97 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editorconfig/lexer.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 105 | let parser = sequence::separated_pair( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | / combinator::map(parser, |(k, v): (&str, &str)| { [INFO] [stdout] 112 | | Token::Pair(k.trim(), v.trim()) [INFO] [stdout] 113 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enumerable.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 6 | fn unique(self) -> UniqueIterator [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enumerable.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 18 | fn only_duplicates(self) -> OnlyDuplicatesIterator [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | counter: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `editorconfiger` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 279 | let parallelism = Parallelism::RayonNewPool(num_cpus::get_physical()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let iter = WalkDir::new(root) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | / iter.into_iter() [INFO] [stdout] 288 | | .filter_map(std::result::Result::ok) [INFO] [stdout] 289 | | .filter(|f| f.file_type().is_file()) [INFO] [stdout] 290 | | .map(|f| f.path()) [INFO] [stdout] 291 | | .filter(|p| p.ends_with(EDITOR_CONFIG)) [INFO] [stdout] 292 | | .map(|f| f.to_str().unwrap_or("").to_string()) [INFO] [stdout] 293 | | .inspect(|p| validate_one(p, formatter, err)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editorconfig/lexer.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 91 | let parser = sequence::preceded(complete::char('['), is_not("\n\r;#")); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / combinator::map_res(parser, |val: &str| match val.rfind(']') { [INFO] [stdout] 95 | | Some(ix) => Ok(Token::Head(&val[..ix])), [INFO] [stdout] 96 | | None => Err(nom::Err::Failure(']')), [INFO] [stdout] 97 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editorconfig/lexer.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 105 | let parser = sequence::separated_pair( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | / combinator::map(parser, |(k, v): (&str, &str)| { [INFO] [stdout] 112 | | Token::Pair(k.trim(), v.trim()) [INFO] [stdout] 113 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enumerable.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 6 | fn unique(self) -> UniqueIterator [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enumerable.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 18 | fn only_duplicates(self) -> OnlyDuplicatesIterator [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | counter: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `editorconfiger` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "7babfbd3b16b0873ce920209e7a0dc649ab8c6ecda17d3732c30f6313950c26a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7babfbd3b16b0873ce920209e7a0dc649ab8c6ecda17d3732c30f6313950c26a", kill_on_drop: false }` [INFO] [stdout] 7babfbd3b16b0873ce920209e7a0dc649ab8c6ecda17d3732c30f6313950c26a