[INFO] fetching crate edgedb-composable-query-derive 0.0.4... [INFO] checking edgedb-composable-query-derive-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate edgedb-composable-query-derive 0.0.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate edgedb-composable-query-derive 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate edgedb-composable-query-derive 0.0.4 [INFO] finished tweaking crates.io crate edgedb-composable-query-derive 0.0.4 [INFO] tweaked toml for crates.io crate edgedb-composable-query-derive 0.0.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c599736c4c8f6501877473bee0258b1d16e4a7c72190177fec0d8f8ecb07b58f [INFO] running `Command { std: "docker" "start" "-a" "c599736c4c8f6501877473bee0258b1d16e4a7c72190177fec0d8f8ecb07b58f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c599736c4c8f6501877473bee0258b1d16e4a7c72190177fec0d8f8ecb07b58f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c599736c4c8f6501877473bee0258b1d16e4a7c72190177fec0d8f8ecb07b58f", kill_on_drop: false }` [INFO] [stdout] c599736c4c8f6501877473bee0258b1d16e4a7c72190177fec0d8f8ecb07b58f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d3e6f625b3009cde5505ad5cc6d473f253aa467ee6799a64ed4cbd04dab542b [INFO] running `Command { std: "docker" "start" "-a" "9d3e6f625b3009cde5505ad5cc6d473f253aa467ee6799a64ed4cbd04dab542b", kill_on_drop: false }` [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking edgedb-composable-query-derive v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `query::QueryVar` [INFO] [stdout] --> src/composable_selector.rs:1:40 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{opts::ComposableQueryOpts, query::QueryVar, tokens::ComposableQueryAttribute}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/tokens.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | .ok_or({ "expected #[select] or #[direct] attribute for wrapper structs" })?; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 129 - .ok_or({ "expected #[select] or #[direct] attribute for wrapper structs" })?; [INFO] [stdout] 129 + .ok_or("expected #[select] or #[direct] attribute for wrapper structs")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/composable_selector.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut attribs = ComposableQueryAttribute::from_attrs(&item.attrs)?; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `selector_only` [INFO] [stdout] --> src/tokens.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | selector_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_selector_only` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ty` is never read [INFO] [stdout] --> src/object.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct EdgedbObjectField { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 12 | ident: Option, [INFO] [stdout] 13 | ty: Type, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `EdgedbObjectField` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attrs` is never read [INFO] [stdout] --> src/object.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 20 | struct EdgedbObjectOpts { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 21 | ident: syn::Ident, [INFO] [stdout] 22 | attrs: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EdgedbObjectOpts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn derive_edgedb_object(item: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let item = syn::parse_macro_input!(item as DeriveInput); [INFO] [stdout] | ---- -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | match derive_edgedb_object_impl(item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:28:11 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn derive_edgedb_composable_selector(item: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let item = syn::parse_macro_input!(item as DeriveInput); [INFO] [stdout] | ---- -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | match derive_composable_selector_impl(item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn derive_composable_query(item: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let item = syn::parse_macro_input!(item as DeriveInput); [INFO] [stdout] | ---- -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | match derive_composable_query_impl(item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/opts.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 27 | let _ident = field.ident.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | [INFO] [stdout] 29 | let ty = field.ty.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | let mut var = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | field_name, [INFO] [stdout] 53 | | // ident, [INFO] [stdout] 54 | | ty, [INFO] [stdout] 55 | | var, [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokens.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 57 | attrs: Vec, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut errors = darling::Error::accumulator(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | let params = Self::by_discr_at_most_one( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let mut withs = Self::by_discr(&attrs, ComposableQueryAttribute::try_as_with_ref) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let selector = Self::by_discr_at_most_one( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let result: Result = (|| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let result = match result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Ok(Query { [INFO] [stdout] | ____________^ [INFO] [stdout] 200 | | result, [INFO] [stdout] 201 | | params, [INFO] [stdout] 202 | | withs, [INFO] [stdout] 203 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokens.rs:169:16 [INFO] [stdout] | [INFO] [stdout] 76 | let selector = Self::by_discr_at_most_one( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(QuerySelector::Object( [INFO] [stdout] | ________________^ [INFO] [stdout] 170 | | fields [INFO] [stdout] 171 | | .iter() [INFO] [stdout] 172 | | .map(|f| { [INFO] [stdout] ... | [INFO] [stdout] 183 | | .collect_vec(), [INFO] [stdout] 184 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokens.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 222 | let args = item.parse_args_with(Punctuated::::parse_terminated)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | let args: Vec<_> = args [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(Self::Params(Params(args))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokens.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 248 | let mut with = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | let with = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | Ok(Self::With(with)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `edgedb-composable-query-derive` (lib) due to 9 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9d3e6f625b3009cde5505ad5cc6d473f253aa467ee6799a64ed4cbd04dab542b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d3e6f625b3009cde5505ad5cc6d473f253aa467ee6799a64ed4cbd04dab542b", kill_on_drop: false }` [INFO] [stdout] 9d3e6f625b3009cde5505ad5cc6d473f253aa467ee6799a64ed4cbd04dab542b