[INFO] fetching crate ed-journals 0.5.1... [INFO] checking ed-journals-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ed-journals 0.5.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ed-journals 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ed-journals 0.5.1 [INFO] finished tweaking crates.io crate ed-journals 0.5.1 [INFO] tweaked toml for crates.io crate ed-journals 0.5.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 108 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding inotify v0.9.6 (latest: v0.11.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.8.11 (latest: v1.0.2) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6903eff054257c02bd3f468e14381aa779b29d887cc92643f95fd304e1d5cda8 [INFO] running `Command { std: "docker" "start" "-a" "6903eff054257c02bd3f468e14381aa779b29d887cc92643f95fd304e1d5cda8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6903eff054257c02bd3f468e14381aa779b29d887cc92643f95fd304e1d5cda8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6903eff054257c02bd3f468e14381aa779b29d887cc92643f95fd304e1d5cda8", kill_on_drop: false }` [INFO] [stdout] 6903eff054257c02bd3f468e14381aa779b29d887cc92643f95fd304e1d5cda8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5922e870b9eccbe1e90fa53dd3e71f9ba603314b82cf98b0a305710656044e41 [INFO] running `Command { std: "docker" "start" "-a" "5922e870b9eccbe1e90fa53dd3e71f9ba603314b82cf98b0a305710656044e41", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking async-mutex v1.4.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking regex-macro v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling kinded_macros v0.3.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking kinded v0.3.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking ed-journals v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `EngineerError` [INFO] [stdout] --> src/modules/logs/content/log_event_content/engineer_progress_event.rs:2:37 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::civilization::{Engineer, EngineerError}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/modules/state/models/planet_state.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Species` [INFO] [stdout] --> src/modules/state/models/system_state.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::exobiology::{SpawnSourceStar, Species, TargetSystem}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Atmosphere`, `PlanetClass`, `PlanetComposition`, `StarClass`, `StarLuminosity`, and `Volcanism` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | Atmosphere, AtmosphereDensity, AtmosphereType, Nebula, PlanetClass, PlanetComposition, [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 17 | StarClass, StarLuminosity, Volcanism, VolcanismType, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `from_str_deserialize_impl` [INFO] [stdout] --> src/modules/civilization/models/engineer.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::{from_str_deserialize_impl, try_from_deserialize_impl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::galaxy::StarClass::Y` [INFO] [stdout] --> src/modules/ship/models/ship_module/ship_internal_module.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::galaxy::StarClass::Y; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `EngineerError` [INFO] [stdout] --> src/modules/logs/content/log_event_content/engineer_progress_event.rs:2:37 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::civilization::{Engineer, EngineerError}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/modules/state/models/planet_state.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Species` [INFO] [stdout] --> src/modules/state/models/system_state.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::exobiology::{SpawnSourceStar, Species, TargetSystem}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `HashSet` [INFO] [stdout] --> src/modules/state/models/system_state.rs:127:28 [INFO] [stdout] | [INFO] [stdout] 127 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Species` [INFO] [stdout] --> src/modules/state/models/system_state.rs:130:42 [INFO] [stdout] | [INFO] [stdout] 130 | use crate::exobiology::{SpawnSource, Species}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Atmosphere`, `PlanetClass`, `PlanetComposition`, `StarClass`, `StarLuminosity`, and `Volcanism` [INFO] [stdout] --> src/modules/exobiology/models/spawn_source.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | Atmosphere, AtmosphereDensity, AtmosphereType, Nebula, PlanetClass, PlanetComposition, [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 17 | StarClass, StarLuminosity, Volcanism, VolcanismType, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `from_str_deserialize_impl` [INFO] [stdout] --> src/modules/civilization/models/engineer.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::{from_str_deserialize_impl, try_from_deserialize_impl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::galaxy::StarClass::Y` [INFO] [stdout] --> src/modules/ship/models/ship_module/ship_internal_module.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::galaxy::StarClass::Y; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ShipInternalModule` [INFO] [stdout] --> src/modules/ship/models/ship_module.rs:204:70 [INFO] [stdout] | [INFO] [stdout] 204 | use crate::ship::{HardpointMounting, HardpointSize, ModuleClass, ShipInternalModule}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `goal` [INFO] [stdout] --> src/modules/logs/content/log_event_content/community_goal_event.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | let goal: CommunityGoalEvent = serde_json::from_str( [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_goal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `goal` [INFO] [stdout] --> src/modules/logs/content/log_event_content/community_goal_event.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let goal: CommunityGoalEventGoal = serde_json::from_str( [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_goal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/logs/content/log_event_content.rs:878:13 [INFO] [stdout] | [INFO] [stdout] 877 | LogEventContent::CarrierJump(event) => event.system_info.body_id, [INFO] [stdout] | ----------------------------------- matches all the relevant values [INFO] [stdout] 878 | LogEventContent::CarrierJump(event) => event.system_info.body_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/logs/content/log_event_content.rs:891:13 [INFO] [stdout] | [INFO] [stdout] 889 | LogEventContent::Touchdown(event) => event.body_id, [INFO] [stdout] | --------------------------------- matches all the relevant values [INFO] [stdout] 890 | LogEventContent::ScanOrganic(event) => event.body, [INFO] [stdout] 891 | LogEventContent::Touchdown(event) => event.body_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/logs/content/log_event_content.rs:901:13 [INFO] [stdout] | [INFO] [stdout] 900 | LogEventContent::CarrierJump(event) => &event.system_info.body, [INFO] [stdout] | ----------------------------------- matches all the relevant values [INFO] [stdout] 901 | LogEventContent::CarrierJump(event) => &event.system_info.body, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/state/models/commander_state.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 81 | LogEventContent::CarrierJump(carrier_jump) => { [INFO] [stdout] | ------------------------------------------ matches all the relevant values [INFO] [stdout] ... [INFO] [stdout] 141 | LogEventContent::CarrierJump(_) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event` [INFO] [stdout] --> src/modules/state/models/commander_state.rs:47:35 [INFO] [stdout] | [INFO] [stdout] 47 | LogEventContent::Died(event) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_event` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/logs/content/log_event_content.rs:878:13 [INFO] [stdout] | [INFO] [stdout] 877 | LogEventContent::CarrierJump(event) => event.system_info.body_id, [INFO] [stdout] | ----------------------------------- matches all the relevant values [INFO] [stdout] 878 | LogEventContent::CarrierJump(event) => event.system_info.body_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/logs/content/log_event_content.rs:891:13 [INFO] [stdout] | [INFO] [stdout] 889 | LogEventContent::Touchdown(event) => event.body_id, [INFO] [stdout] | --------------------------------- matches all the relevant values [INFO] [stdout] 890 | LogEventContent::ScanOrganic(event) => event.body, [INFO] [stdout] 891 | LogEventContent::Touchdown(event) => event.body_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/logs/content/log_event_content.rs:901:13 [INFO] [stdout] | [INFO] [stdout] 900 | LogEventContent::CarrierJump(event) => &event.system_info.body, [INFO] [stdout] | ----------------------------------- matches all the relevant values [INFO] [stdout] 901 | LogEventContent::CarrierJump(event) => &event.system_info.body, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `entry` [INFO] [stdout] --> src/modules/logs/blocking/log_dir_reader.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | for entry in reader { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/state/models/commander_state.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 81 | LogEventContent::CarrierJump(carrier_jump) => { [INFO] [stdout] | ------------------------------------------ matches all the relevant values [INFO] [stdout] ... [INFO] [stdout] 141 | LogEventContent::CarrierJump(_) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event` [INFO] [stdout] --> src/modules/state/models/commander_state.rs:47:35 [INFO] [stdout] | [INFO] [stdout] 47 | LogEventContent::Died(event) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_event` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/exobiology/models/variant.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | let mut lines = content.lines(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/exobiology/models/variant.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let mut lines = content.lines(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/civilization/models/crime.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let mut lines = content.lines(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/ship/models/blueprint.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | let mut lines = contents.lines(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/live_log_dir_reader.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn open>(dir_path: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let log_dir_reader = LogDirReader::open(&dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | blocker, [INFO] [stdout] 63 | | log_dir_reader, [INFO] [stdout] 64 | | active: Arc::new(AtomicBool::new(true)), [INFO] [stdout] 65 | | _watcher: watcher, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/live_log_file_reader.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let journal_file_reader = LogFileReader::open(&path)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(LiveLogFileReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | blocker, [INFO] [stdout] 66 | | log_file_reader: journal_file_reader, [INFO] [stdout] 67 | | _watcher: watcher, [INFO] [stdout] 68 | | active: Arc::new(AtomicBool::new(true)), [INFO] [stdout] 69 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/log_dir_reader.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn open>(path: P) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | current_reader: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/log_file_reader.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Ok(LogFileReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | source: File::open(path)?, [INFO] [stdout] 71 | | position: 0, [INFO] [stdout] 72 | | file_read_buffer: String::new(), [INFO] [stdout] 73 | | entry_buffer: VecDeque::new(), [INFO] [stdout] 74 | | failing: false, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/asynchronous/live_log_dir_reader.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn open>(dir_path: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let log_dir_reader = LogDirReader::open(&dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | let blocker = AsyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(LiveLogDirReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | blocker, [INFO] [stdout] 70 | | active: Arc::new(AtomicBool::new(true)), [INFO] [stdout] 71 | | _watcher: watcher, [INFO] [stdout] 72 | | log_dir_reader, [INFO] [stdout] 73 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/asynchronous/log_dir_reader.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn open>(path: P) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | current_reader: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/journal/blocking/live_journal_dir_reader.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let journal_buffer = LiveJournalBuffer::new(dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let local_journal_buffer = journal_buffer.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | let mut watcher = notify::recommended_watcher(move |res: Result| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let log_dir_reader = LogDirReader::open(path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | Ok(LiveJournalDirReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | blocker, [INFO] [stdout] 81 | | _watcher: watcher, [INFO] [stdout] 82 | | log_dir_reader, [INFO] [stdout] 83 | | journal_buffer, [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/journal/asynchronous/live_journal_dir_reader.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let blocker = AsyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let journal_buffer = LiveJournalBuffer::new(dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let local_journal_buffer = journal_buffer.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let mut watcher = notify::recommended_watcher(move |res: Result| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let log_dir_reader = LogDirReader::open(path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | Ok(LiveJournalDirReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | blocker, [INFO] [stdout] 80 | | _watcher: watcher, [INFO] [stdout] 81 | | log_dir_reader, [INFO] [stdout] 82 | | journal_buffer, [INFO] [stdout] 83 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/exobiology/models/variant.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | from_str_deserialize_impl!(Variant); [INFO] [stdout] | ----------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/shared/blocking/live_json_file_watcher.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(LiveJsonFileWatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | blocker, [INFO] [stdout] 53 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 54 | | _watcher: watcher, [INFO] [stdout] 55 | | first: true, [INFO] [stdout] 56 | | phantom_data: PhantomData, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/shared/blocking/live_json_file_watcher.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 76 | Err(error) => return Some(Err(error.into())), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let value = match serde_json::from_str(&string_content) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Ok(value) => value, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Err(error) => return Some(Err(error.into())), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Some(Ok(value)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/shared/asynchronous/live_json_file_watcher.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let blocker = AsyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(LiveJsonFileWatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | blocker, [INFO] [stdout] 52 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 53 | | _watcher: watcher, [INFO] [stdout] 54 | | first: true, [INFO] [stdout] 55 | | phantom_data: PhantomData, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/galaxy/models/atmosphere.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | from_str_deserialize_impl!(Atmosphere); [INFO] [stdout] | -------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/galaxy/models/volcanism.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | from_str_deserialize_impl!(Volcanism); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/ship/models/ship_module/ship_hardpoint_module.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | from_str_deserialize_impl!(ShipHardpointModule); [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/ship/models/ship_module/ship_internal_module.rs:165:1 [INFO] [stdout] | [INFO] [stdout] 165 | from_str_deserialize_impl!(ShipInternalModule); [INFO] [stdout] | ---------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/ship/models/ship_module/ship_internal_module/armor_module.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 52 | let Some(captures) = ARMOR_MODULE_REGEX.captures(s) else { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Err(ArmorModuleError::FailedToParse(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/ship/models/ship_module/ship_internal_module/armor_module.rs:80:1 [INFO] [stdout] | [INFO] [stdout] 80 | from_str_deserialize_impl!(ArmorModule); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/ship/models/ship_module.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | let mut lines = content.lines(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `found_file_header` is assigned to, but never used [INFO] [stdout] --> src/lib.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | let mut found_file_header = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_found_file_header` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `found_file_header` is never read [INFO] [stdout] --> src/lib.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | found_file_header = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `load_game_event_is_parsed_correctly` is never used [INFO] [stdout] --> src/modules/logs/content/log_event_content/load_game_event.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | fn load_game_event_is_parsed_correctly() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/live_log_dir_reader.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn open>(dir_path: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let log_dir_reader = LogDirReader::open(&dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | blocker, [INFO] [stdout] 63 | | log_dir_reader, [INFO] [stdout] 64 | | active: Arc::new(AtomicBool::new(true)), [INFO] [stdout] 65 | | _watcher: watcher, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/live_log_file_reader.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let journal_file_reader = LogFileReader::open(&path)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(LiveLogFileReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | blocker, [INFO] [stdout] 66 | | log_file_reader: journal_file_reader, [INFO] [stdout] 67 | | _watcher: watcher, [INFO] [stdout] 68 | | active: Arc::new(AtomicBool::new(true)), [INFO] [stdout] 69 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/log_dir_reader.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn open>(path: P) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | current_reader: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/blocking/log_file_reader.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Ok(LogFileReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | source: File::open(path)?, [INFO] [stdout] 71 | | position: 0, [INFO] [stdout] 72 | | file_read_buffer: String::new(), [INFO] [stdout] 73 | | entry_buffer: VecDeque::new(), [INFO] [stdout] 74 | | failing: false, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/asynchronous/live_log_dir_reader.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn open>(dir_path: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let log_dir_reader = LogDirReader::open(&dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | let blocker = AsyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(LiveLogDirReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | blocker, [INFO] [stdout] 70 | | active: Arc::new(AtomicBool::new(true)), [INFO] [stdout] 71 | | _watcher: watcher, [INFO] [stdout] 72 | | log_dir_reader, [INFO] [stdout] 73 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/logs/asynchronous/log_dir_reader.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn open>(path: P) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | current_reader: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/journal/blocking/live_journal_dir_reader.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let journal_buffer = LiveJournalBuffer::new(dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let local_journal_buffer = journal_buffer.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | let mut watcher = notify::recommended_watcher(move |res: Result| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let log_dir_reader = LogDirReader::open(path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | Ok(LiveJournalDirReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | blocker, [INFO] [stdout] 81 | | _watcher: watcher, [INFO] [stdout] 82 | | log_dir_reader, [INFO] [stdout] 83 | | journal_buffer, [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/journal/asynchronous/live_journal_dir_reader.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let blocker = AsyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let journal_buffer = LiveJournalBuffer::new(dir_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let local_journal_buffer = journal_buffer.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let mut watcher = notify::recommended_watcher(move |res: Result| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let log_dir_reader = LogDirReader::open(path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | Ok(LiveJournalDirReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | blocker, [INFO] [stdout] 80 | | _watcher: watcher, [INFO] [stdout] 81 | | log_dir_reader, [INFO] [stdout] 82 | | journal_buffer, [INFO] [stdout] 83 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/exobiology/models/variant.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | from_str_deserialize_impl!(Variant); [INFO] [stdout] | ----------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/shared/blocking/live_json_file_watcher.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let blocker = SyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(LiveJsonFileWatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | blocker, [INFO] [stdout] 53 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 54 | | _watcher: watcher, [INFO] [stdout] 55 | | first: true, [INFO] [stdout] 56 | | phantom_data: PhantomData, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/shared/blocking/live_json_file_watcher.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 76 | Err(error) => return Some(Err(error.into())), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let value = match serde_json::from_str(&string_content) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Ok(value) => value, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Err(error) => return Some(Err(error.into())), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Some(Ok(value)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/shared/asynchronous/live_json_file_watcher.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let blocker = AsyncBlocker::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let local_blocker = blocker.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | let mut watcher = notify::recommended_watcher(move |_| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(LiveJsonFileWatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | blocker, [INFO] [stdout] 52 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 53 | | _watcher: watcher, [INFO] [stdout] 54 | | first: true, [INFO] [stdout] 55 | | phantom_data: PhantomData, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/galaxy/models/atmosphere.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | from_str_deserialize_impl!(Atmosphere); [INFO] [stdout] | -------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/galaxy/models/volcanism.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | from_str_deserialize_impl!(Volcanism); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/ship/models/ship_module/ship_hardpoint_module.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | from_str_deserialize_impl!(ShipHardpointModule); [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/ship/models/ship_module/ship_internal_module.rs:165:1 [INFO] [stdout] | [INFO] [stdout] 165 | from_str_deserialize_impl!(ShipInternalModule); [INFO] [stdout] | ---------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/ship/models/ship_module/ship_internal_module/armor_module.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 52 | let Some(captures) = ARMOR_MODULE_REGEX.captures(s) else { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Err(ArmorModuleError::FailedToParse(s.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modules/utils/macros.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | FromStr::from_str(&s).map_err(|value| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/modules/ship/models/ship_module/ship_internal_module/armor_module.rs:80:1 [INFO] [stdout] | [INFO] [stdout] 80 | from_str_deserialize_impl!(ArmorModule); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `from_str_deserialize_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ed-journals` (lib) due to 19 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 18 previous errors; 28 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ed-journals` (lib test) due to 19 previous errors; 28 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5922e870b9eccbe1e90fa53dd3e71f9ba603314b82cf98b0a305710656044e41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5922e870b9eccbe1e90fa53dd3e71f9ba603314b82cf98b0a305710656044e41", kill_on_drop: false }` [INFO] [stdout] 5922e870b9eccbe1e90fa53dd3e71f9ba603314b82cf98b0a305710656044e41