[INFO] fetching crate ecli 0.2.0... [INFO] checking ecli-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ecli 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ecli 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ecli 0.2.0 [INFO] finished tweaking crates.io crate ecli 0.2.0 [INFO] tweaked toml for crates.io crate ecli 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ecli 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7ee9d19c7216441b55e6f462ca7db526ddb9f0293f56f90d1780d50b51b349e [INFO] running `Command { std: "docker" "start" "-a" "c7ee9d19c7216441b55e6f462ca7db526ddb9f0293f56f90d1780d50b51b349e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7ee9d19c7216441b55e6f462ca7db526ddb9f0293f56f90d1780d50b51b349e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7ee9d19c7216441b55e6f462ca7db526ddb9f0293f56f90d1780d50b51b349e", kill_on_drop: false }` [INFO] [stdout] c7ee9d19c7216441b55e6f462ca7db526ddb9f0293f56f90d1780d50b51b349e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1076ff8ff89fa0625e1b601bc9ac4cdf5eace09853c20a43522c2bb0928e0c6 [INFO] running `Command { std: "docker" "start" "-a" "f1076ff8ff89fa0625e1b601bc9ac4cdf5eace09853c20a43522c2bb0928e0c6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling proc-macro2 v1.0.4 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling ucd-trie v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling pest v2.1.2 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Compiling pest_meta v2.1.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking dtoa v0.4.4 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking termion v1.5.3 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking rand_xoshiro v0.3.1 [INFO] [stderr] Checking rand_os v0.2.2 [INFO] [stderr] Checking criterion-plot v0.4.0 [INFO] [stderr] Compiling pest_generator v2.1.1 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking serde_yaml v0.8.9 [INFO] [stderr] Checking unstructured v0.3.1 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking templar v0.1.0 [INFO] [stderr] Checking criterion v0.3.0 [INFO] [stderr] Checking ecli v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/templates/mod.rs:9:39 [INFO] [stdout] | [INFO] [stdout] 9 | pub static ref TEMPLAR: Templar = { Templar::default() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 9 - pub static ref TEMPLAR: Templar = { Templar::default() }; [INFO] [stdout] 9 + pub static ref TEMPLAR: Templar = Templar::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 41 | let mut menus = BTreeMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | actions: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 41 | let mut menus = BTreeMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | vars: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 64 | let f = std::fs::File::open(file)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Ok(serde_yaml::from_reader(f)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/actions.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | #[derive(Debug, Deserialize, Serialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/styles.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | #[derive(Debug, Deserialize, Serialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / impl_colors! { [INFO] [stdout] 51 | | None:Reset, [INFO] [stdout] 52 | | Black:Black, [INFO] [stdout] 53 | | Red:Red, [INFO] [stdout] ... | [INFO] [stdout] 67 | | LightWhite:LightWhite [INFO] [stdout] 68 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` which comes from the expansion of the macro `impl_colors` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen/menus/choice.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(menu: ChoiceMenu) -> Result> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Ok(Box::new(ChoiceScreen { menu, selected: 0 })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/templates/ser.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 60 | let template: Template = TEMPLAR.$method(value).unwrap_or_default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Ok($name(template, value.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | / impl_render! { [INFO] [stdout] 80 | | EcliExpression(parse_expression); [INFO] [stdout] 81 | | EcliTemplate(parse); [INFO] [stdout] 82 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_render` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ecli` (bin "ecli") due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f1076ff8ff89fa0625e1b601bc9ac4cdf5eace09853c20a43522c2bb0928e0c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1076ff8ff89fa0625e1b601bc9ac4cdf5eace09853c20a43522c2bb0928e0c6", kill_on_drop: false }` [INFO] [stdout] f1076ff8ff89fa0625e1b601bc9ac4cdf5eace09853c20a43522c2bb0928e0c6