[INFO] fetching crate echo-library 0.0.6... [INFO] checking echo-library-0.0.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate echo-library 0.0.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate echo-library 0.0.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate echo-library 0.0.6 [INFO] finished tweaking crates.io crate echo-library 0.0.6 [INFO] tweaked toml for crates.io crate echo-library 0.0.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 173 packages to latest compatible versions [INFO] [stderr] Adding annotate-snippets v0.9.2 (latest: v0.11.4) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clipboard-win v4.5.0 (latest: v5.4.0) [INFO] [stderr] Adding composer-primitives v0.0.3 (latest: v0.0.6) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding endian-type v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding erased-serde v0.3.31 (latest: v0.4.5) [INFO] [stderr] Adding error-code v2.3.1 (latest: v3.2.0) [INFO] [stderr] Adding fd-lock v3.0.13 (latest: v4.0.2) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding lalrpop v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding logos v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding lsp-types v0.94.1 (latest: v0.97.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustyline v11.0.0 (latest: v14.0.0) [INFO] [stderr] Adding schemafy v0.5.2 (latest: v0.6.0) [INFO] [stderr] Adding schemafy_core v0.5.2 (latest: v0.6.0) [INFO] [stderr] Adding schemafy_lib v0.5.2 (latest: v0.6.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding str-buf v1.0.6 (latest: v3.0.3) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3061a9f0f8b449349925927c5881da7eb03dfd8ed536e14f76c2ab9917dde57b [INFO] running `Command { std: "docker" "start" "-a" "3061a9f0f8b449349925927c5881da7eb03dfd8ed536e14f76c2ab9917dde57b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3061a9f0f8b449349925927c5881da7eb03dfd8ed536e14f76c2ab9917dde57b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3061a9f0f8b449349925927c5881da7eb03dfd8ed536e14f76c2ab9917dde57b", kill_on_drop: false }` [INFO] [stdout] 3061a9f0f8b449349925927c5881da7eb03dfd8ed536e14f76c2ab9917dde57b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a82f1000b2c732e42dfcdc875b8994ad732ed4072f5c86c984ae4c4cab3b36e3 [INFO] running `Command { std: "docker" "start" "-a" "a82f1000b2c732e42dfcdc875b8994ad732ed4072f5c86c984ae4c4cab3b36e3", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling allocative v0.3.3 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling starlark_map v0.12.0 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking lalrpop-util v0.19.12 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking annotate-snippets v0.9.2 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Compiling starlark v0.12.0 [INFO] [stderr] Checking display_container v0.9.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking cmp_any v0.8.1 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking rustyline v11.0.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Compiling allocative_derive v0.3.3 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Compiling starlark_derive v0.12.0 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking lsp-types v0.94.1 [INFO] [stderr] Checking composer-primitives v0.0.3 [INFO] [stderr] Compiling schemafy_core v0.5.2 [INFO] [stderr] Compiling schemafy_lib v0.5.2 [INFO] [stderr] Compiling schemafy v0.5.2 [INFO] [stderr] Compiling starlark_syntax v0.12.0 [INFO] [stderr] Checking debugserver-types v0.5.0 [INFO] [stderr] Checking echo-library v0.0.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/composer.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 164 | let ast: AstModule = AstModule::parse_file( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let globals = GlobalsBuilder::extended_by(&[ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let module = Module::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | Ok(module.freeze()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | fn task( [INFO] [stdout] | ________^ [INFO] [stdout] 24 | | kind: String, [INFO] [stdout] 25 | | action_name: String, [INFO] [stdout] 26 | | input_arguments: Value, [INFO] [stdout] ... | [INFO] [stdout] 74 | | }) [INFO] [stdout] 75 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | fn workflows( [INFO] [stdout] | ________^ [INFO] [stdout] 93 | | name: String, [INFO] [stdout] 94 | | version: String, [INFO] [stdout] 95 | | tasks: Value, [INFO] [stdout] ... | [INFO] [stdout] 122 | | }) [INFO] [stdout] 123 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | fn argument( [INFO] [stdout] | ________^ [INFO] [stdout] 138 | | name: String, [INFO] [stdout] 139 | | input_type: Value, [INFO] [stdout] 140 | | default_value: Option, [INFO] [stdout] ... | [INFO] [stdout] 191 | | }) [INFO] [stdout] 192 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:194:8 [INFO] [stdout] | [INFO] [stdout] 194 | fn depend(task_name: String, cur_field: String, prev_field: String) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 195 | | Ok(Depend { [INFO] [stdout] 196 | | task_name, [INFO] [stdout] 197 | | cur_field, [INFO] [stdout] 198 | | prev_field, [INFO] [stdout] 199 | | }) [INFO] [stdout] 200 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | fn EchoStruct(name: String, fields: Value, eval: &mut Evaluator) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 216 | | let fields: HashMap = serde_json::from_str(&fields.to_json()?) [INFO] [stdout] 217 | | .map_err(|err| anyhow!("Failed to parse fields: {}", err))?; [INFO] [stdout] ... | [INFO] [stdout] 245 | | Ok(RustType::Struct(name)) [INFO] [stdout] 246 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:263:8 [INFO] [stdout] | [INFO] [stdout] 263 | fn Tuple(type_1: Value, type_2: Value) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 264 | | let type_1: RustType = serde_json::from_str(&type_1.to_json()?) [INFO] [stdout] 265 | | .map_err(|err| anyhow!("Failed to parse values: {}", err))?; [INFO] [stdout] 266 | | let type_2: RustType = serde_json::from_str(&type_2.to_json()?) [INFO] [stdout] ... | [INFO] [stdout] 269 | | Ok(RustType::Tuple(Box::new(type_1), Box::new(type_2))) [INFO] [stdout] 270 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:284:8 [INFO] [stdout] | [INFO] [stdout] 284 | fn HashMap(type_1: Value, type_2: Value) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 285 | | let type_1: RustType = serde_json::from_str(&type_1.to_json()?) [INFO] [stdout] 286 | | .map_err(|err| anyhow!("Failed to parse values: {}", err))?; [INFO] [stdout] 287 | | let type_2: RustType = serde_json::from_str(&type_2.to_json()?) [INFO] [stdout] ... | [INFO] [stdout] 290 | | Ok(RustType::HashMap(Box::new(type_1), Box::new(type_2))) [INFO] [stdout] 291 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:304:8 [INFO] [stdout] | [INFO] [stdout] 304 | fn List(type_of: Value) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 305 | | let type_of: RustType = serde_json::from_str(&type_of.to_json()?) [INFO] [stdout] 306 | | .map_err(|err| anyhow!("Failed to parse values: {}", err))?; [INFO] [stdout] 307 | | Ok(RustType::List(Box::new(type_of))) [INFO] [stdout] 308 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:320:8 [INFO] [stdout] | [INFO] [stdout] 320 | fn normal() -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 321 | | Ok(Operation::Normal) [INFO] [stdout] 322 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:331:8 [INFO] [stdout] | [INFO] [stdout] 331 | fn concat() -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 332 | | Ok(Operation::Concat) [INFO] [stdout] 333 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:342:8 [INFO] [stdout] | [INFO] [stdout] 342 | fn combine() -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 343 | | Ok(Operation::Combine) [INFO] [stdout] 344 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:357:8 [INFO] [stdout] | [INFO] [stdout] 357 | fn map(field: String) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 358 | | Ok(Operation::Map(field)) [INFO] [stdout] 359 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `echo-library` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/composer.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 164 | let ast: AstModule = AstModule::parse_file( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let globals = GlobalsBuilder::extended_by(&[ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let module = Module::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | Ok(module.freeze()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | fn task( [INFO] [stdout] | ________^ [INFO] [stdout] 24 | | kind: String, [INFO] [stdout] 25 | | action_name: String, [INFO] [stdout] 26 | | input_arguments: Value, [INFO] [stdout] ... | [INFO] [stdout] 74 | | }) [INFO] [stdout] 75 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | fn workflows( [INFO] [stdout] | ________^ [INFO] [stdout] 93 | | name: String, [INFO] [stdout] 94 | | version: String, [INFO] [stdout] 95 | | tasks: Value, [INFO] [stdout] ... | [INFO] [stdout] 122 | | }) [INFO] [stdout] 123 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | fn argument( [INFO] [stdout] | ________^ [INFO] [stdout] 138 | | name: String, [INFO] [stdout] 139 | | input_type: Value, [INFO] [stdout] 140 | | default_value: Option, [INFO] [stdout] ... | [INFO] [stdout] 191 | | }) [INFO] [stdout] 192 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:194:8 [INFO] [stdout] | [INFO] [stdout] 194 | fn depend(task_name: String, cur_field: String, prev_field: String) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 195 | | Ok(Depend { [INFO] [stdout] 196 | | task_name, [INFO] [stdout] 197 | | cur_field, [INFO] [stdout] 198 | | prev_field, [INFO] [stdout] 199 | | }) [INFO] [stdout] 200 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | fn EchoStruct(name: String, fields: Value, eval: &mut Evaluator) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 216 | | let fields: HashMap = serde_json::from_str(&fields.to_json()?) [INFO] [stdout] 217 | | .map_err(|err| anyhow!("Failed to parse fields: {}", err))?; [INFO] [stdout] ... | [INFO] [stdout] 245 | | Ok(RustType::Struct(name)) [INFO] [stdout] 246 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:263:8 [INFO] [stdout] | [INFO] [stdout] 263 | fn Tuple(type_1: Value, type_2: Value) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 264 | | let type_1: RustType = serde_json::from_str(&type_1.to_json()?) [INFO] [stdout] 265 | | .map_err(|err| anyhow!("Failed to parse values: {}", err))?; [INFO] [stdout] 266 | | let type_2: RustType = serde_json::from_str(&type_2.to_json()?) [INFO] [stdout] ... | [INFO] [stdout] 269 | | Ok(RustType::Tuple(Box::new(type_1), Box::new(type_2))) [INFO] [stdout] 270 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:284:8 [INFO] [stdout] | [INFO] [stdout] 284 | fn HashMap(type_1: Value, type_2: Value) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 285 | | let type_1: RustType = serde_json::from_str(&type_1.to_json()?) [INFO] [stdout] 286 | | .map_err(|err| anyhow!("Failed to parse values: {}", err))?; [INFO] [stdout] 287 | | let type_2: RustType = serde_json::from_str(&type_2.to_json()?) [INFO] [stdout] ... | [INFO] [stdout] 290 | | Ok(RustType::HashMap(Box::new(type_1), Box::new(type_2))) [INFO] [stdout] 291 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:304:8 [INFO] [stdout] | [INFO] [stdout] 304 | fn List(type_of: Value) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 305 | | let type_of: RustType = serde_json::from_str(&type_of.to_json()?) [INFO] [stdout] 306 | | .map_err(|err| anyhow!("Failed to parse values: {}", err))?; [INFO] [stdout] 307 | | Ok(RustType::List(Box::new(type_of))) [INFO] [stdout] 308 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:320:8 [INFO] [stdout] | [INFO] [stdout] 320 | fn normal() -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 321 | | Ok(Operation::Normal) [INFO] [stdout] 322 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:331:8 [INFO] [stdout] | [INFO] [stdout] 331 | fn concat() -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 332 | | Ok(Operation::Concat) [INFO] [stdout] 333 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:342:8 [INFO] [stdout] | [INFO] [stdout] 342 | fn combine() -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 343 | | Ok(Operation::Combine) [INFO] [stdout] 344 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/starlark_modules.rs:357:8 [INFO] [stdout] | [INFO] [stdout] 357 | fn map(field: String) -> anyhow::Result { [INFO] [stdout] | ________^ [INFO] [stdout] 358 | | Ok(Operation::Map(field)) [INFO] [stdout] 359 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `echo-library` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "a82f1000b2c732e42dfcdc875b8994ad732ed4072f5c86c984ae4c4cab3b36e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a82f1000b2c732e42dfcdc875b8994ad732ed4072f5c86c984ae4c4cab3b36e3", kill_on_drop: false }` [INFO] [stdout] a82f1000b2c732e42dfcdc875b8994ad732ed4072f5c86c984ae4c4cab3b36e3