[INFO] fetching crate eccoxide 0.3.1... [INFO] checking eccoxide-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate eccoxide 0.3.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate eccoxide 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate eccoxide 0.3.1 [INFO] finished tweaking crates.io crate eccoxide 0.3.1 [INFO] tweaked toml for crates.io crate eccoxide 0.3.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding num-bigint v0.3.3 (latest: v0.4.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a48bcd331c1060f81bd1ff8bdb54fa0f838be86e131cbf5ade8b77d77c29266c [INFO] running `Command { std: "docker" "start" "-a" "a48bcd331c1060f81bd1ff8bdb54fa0f838be86e131cbf5ade8b77d77c29266c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a48bcd331c1060f81bd1ff8bdb54fa0f838be86e131cbf5ade8b77d77c29266c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a48bcd331c1060f81bd1ff8bdb54fa0f838be86e131cbf5ade8b77d77c29266c", kill_on_drop: false }` [INFO] [stdout] a48bcd331c1060f81bd1ff8bdb54fa0f838be86e131cbf5ade8b77d77c29266c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e1335fe2ee801e49e1d725f9359d297d0d0a24d5a282a7f2cb21647c2ac9fbf [INFO] running `Command { std: "docker" "start" "-a" "4e1335fe2ee801e49e1d725f9359d297d0d0a24d5a282a7f2cb21647c2ac9fbf", kill_on_drop: false }` [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking eccoxide v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `p112r1` [INFO] [stdout] --> src/curve/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | feature = "p112r1", [INFO] [stdout] | ^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"p192r1"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `num-bigint`, `num-traits`, `p112r2`, `p128r1`, `p128r2`, `p160k1`, `p160r1`, `p160r2`, `p192k1`, `p192r1`, `p224k1`, `p224r1`, `p256k1`, `p256r1`, `p384r1`, `p521r1`, `sec2`, and `sec2-small` [INFO] [stdout] = help: consider adding `p112r1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `p112r1` [INFO] [stdout] --> src/curve/sec2/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | feature = "p112r1", [INFO] [stdout] | ^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"p192r1"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `num-bigint`, `num-traits`, `p112r2`, `p128r1`, `p128r2`, `p160k1`, `p160r1`, `p160r2`, `p192k1`, `p192r1`, `p224k1`, `p224r1`, `p256k1`, `p256r1`, `p384r1`, `p521r1`, `sec2`, and `sec2-small` [INFO] [stdout] = help: consider adding `p112r1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `p112r1` [INFO] [stdout] --> src/curve/sec2/mod.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | feature = "p112r1", [INFO] [stdout] | ^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"p192r1"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `num-bigint`, `num-traits`, `p112r2`, `p128r1`, `p128r2`, `p160k1`, `p160r1`, `p160r2`, `p192k1`, `p192r1`, `p224k1`, `p224r1`, `p256k1`, `p256r1`, `p384r1`, `p521r1`, `sec2`, and `sec2-small` [INFO] [stdout] = help: consider adding `p112r1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `p112r1` [INFO] [stdout] --> src/curve/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | feature = "p112r1", [INFO] [stdout] | ^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"p192r1"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `num-bigint`, `num-traits`, `p112r2`, `p128r1`, `p128r2`, `p160k1`, `p160r1`, `p160r2`, `p192k1`, `p192r1`, `p224k1`, `p224r1`, `p256k1`, `p256r1`, `p384r1`, `p521r1`, `sec2`, and `sec2-small` [INFO] [stdout] = help: consider adding `p112r1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `p112r1` [INFO] [stdout] --> src/curve/sec2/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | feature = "p112r1", [INFO] [stdout] | ^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"p192r1"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `num-bigint`, `num-traits`, `p112r2`, `p128r1`, `p128r2`, `p160k1`, `p160r1`, `p160r2`, `p192k1`, `p192r1`, `p224k1`, `p224r1`, `p256k1`, `p256r1`, `p384r1`, `p521r1`, `sec2`, and `sec2-small` [INFO] [stdout] = help: consider adding `p112r1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `p112r1` [INFO] [stdout] --> src/curve/sec2/mod.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | feature = "p112r1", [INFO] [stdout] | ^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"p192r1"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `num-bigint`, `num-traits`, `p112r2`, `p128r1`, `p128r2`, `p160k1`, `p160r1`, `p160r2`, `p192k1`, `p192r1`, `p224k1`, `p224r1`, `p256k1`, `p256r1`, `p384r1`, `p521r1`, `sec2`, and `sec2-small` [INFO] [stdout] = help: consider adding `p112r1` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `ct_gt` and `ct_le` are never used [INFO] [stdout] --> src/mp/ct.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 104 | pub trait CtGreater: Sized { [INFO] [stdout] | --------- associated functions in this trait [INFO] [stdout] 105 | fn ct_gt(a: Self, b: Self) -> Choice; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 106 | fn ct_le(a: Self, b: Self) -> Choice { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `ct_ge` is never used [INFO] [stdout] --> src/mp/ct.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 114 | pub trait CtLesser: Sized { [INFO] [stdout] | -------- associated function in this trait [INFO] [stdout] 115 | fn ct_lt(a: Self, b: Self) -> Choice; [INFO] [stdout] 116 | fn ct_ge(a: Self, b: Self) -> Choice { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curve/affine.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 40 | let yy = x.square() * x + (curve.a() * &x) + curve.b(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | match yy.sqrt().into_option() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curve/projective.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 69 | fn try_from(p: Point) -> Result, Self::Error> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | p.to_affine().ok_or(AffineAtInfinity) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curve/projective.rs:512:16 [INFO] [stdout] | [INFO] [stdout] 509 | fn neg(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 512 | y: -self.y, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eccoxide` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated functions `ct_gt` and `ct_le` are never used [INFO] [stdout] --> src/mp/ct.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 104 | pub trait CtGreater: Sized { [INFO] [stdout] | --------- associated functions in this trait [INFO] [stdout] 105 | fn ct_gt(a: Self, b: Self) -> Choice; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 106 | fn ct_le(a: Self, b: Self) -> Choice { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `ct_ge` is never used [INFO] [stdout] --> src/mp/ct.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 114 | pub trait CtLesser: Sized { [INFO] [stdout] | -------- associated function in this trait [INFO] [stdout] 115 | fn ct_lt(a: Self, b: Self) -> Choice; [INFO] [stdout] 116 | fn ct_ge(a: Self, b: Self) -> Choice { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curve/affine.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 40 | let yy = x.square() * x + (curve.a() * &x) + curve.b(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | match yy.sqrt().into_option() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curve/projective.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 69 | fn try_from(p: Point) -> Result, Self::Error> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | p.to_affine().ok_or(AffineAtInfinity) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curve/projective.rs:512:16 [INFO] [stdout] | [INFO] [stdout] 509 | fn neg(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 512 | y: -self.y, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eccoxide` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4e1335fe2ee801e49e1d725f9359d297d0d0a24d5a282a7f2cb21647c2ac9fbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e1335fe2ee801e49e1d725f9359d297d0d0a24d5a282a7f2cb21647c2ac9fbf", kill_on_drop: false }` [INFO] [stdout] 4e1335fe2ee801e49e1d725f9359d297d0d0a24d5a282a7f2cb21647c2ac9fbf