[INFO] fetching crate easyfs 0.1.0... [INFO] checking easyfs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate easyfs 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate easyfs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate easyfs 0.1.0 [INFO] finished tweaking crates.io crate easyfs 0.1.0 [INFO] tweaked toml for crates.io crate easyfs 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding spin v0.7.1 (latest: v0.9.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 489932284a12f242967fd83c2fc6be5c12c29a0b9dfa3af9d857972fecfb36aa [INFO] running `Command { std: "docker" "start" "-a" "489932284a12f242967fd83c2fc6be5c12c29a0b9dfa3af9d857972fecfb36aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "489932284a12f242967fd83c2fc6be5c12c29a0b9dfa3af9d857972fecfb36aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "489932284a12f242967fd83c2fc6be5c12c29a0b9dfa3af9d857972fecfb36aa", kill_on_drop: false }` [INFO] [stdout] 489932284a12f242967fd83c2fc6be5c12c29a0b9dfa3af9d857972fecfb36aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37236c29ae4acb53bcc111e165ced442d7f276a3ad2222a2ab2f6e664f90a537 [INFO] running `Command { std: "docker" "start" "-a" "37236c29ae4acb53bcc111e165ced442d7f276a3ad2222a2ab2f6e664f90a537", kill_on_drop: false }` [INFO] [stderr] Checking spin v0.7.1 [INFO] [stderr] Checking easyfs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_cache.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 130 | block_device: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | ) -> Arc> { [INFO] [stdout] 132 | / BLOCK_CACHE_MANAGER [INFO] [stdout] 133 | | .lock() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 21 | block_device: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut efs = Self { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Arc::new(Mutex::new(efs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn open(block_device: Arc) -> Arc> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | // read SuperBlock [INFO] [stdout] 83 | / get_block_cache(0, Arc::clone(&block_device)) [INFO] [stdout] 84 | | .lock() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn open(block_device: Arc) -> Arc> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | .read(0, |super_block: &SuperBlock| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 86 | | assert!(super_block.is_valid(), "Error loading EFS!"); [INFO] [stdout] 87 | | let inode_total_blocks = [INFO] [stdout] 88 | | super_block.inode_bitmap_blocks + super_block.inode_area_blocks; [INFO] [stdout] ... | [INFO] [stdout] 99 | | Arc::new(Mutex::new(efs)) [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn open(block_device: Arc) -> Arc> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let efs = Self { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Arc::new(Mutex::new(efs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:109:44 [INFO] [stdout] | [INFO] [stdout] 105 | let block_device = Arc::clone(&efs.lock().block_device); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Inode::new(block_id, block_offset, Arc::clone(efs), block_device) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | fn read_disk_inode(&self, f: impl FnOnce(&DiskInode) -> V) -> V { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / get_block_cache(self.block_id, Arc::clone(&self.block_device)) [INFO] [stdout] 35 | | .lock() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 39 | fn modify_disk_inode(&self, f: impl FnOnce(&mut DiskInode) -> V) -> V { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / get_block_cache(self.block_id, Arc::clone(&self.block_device)) [INFO] [stdout] 41 | | .lock() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 95 | let mut fs = self.fs.lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Some(Arc::new(Self::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 134 | | block_id, [INFO] [stdout] 135 | | block_offset, [INFO] [stdout] 136 | | self.fs.clone(), [INFO] [stdout] 137 | | self.block_device.clone(), [INFO] [stdout] 138 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `easyfs` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_cache.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 130 | block_device: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | ) -> Arc> { [INFO] [stdout] 132 | / BLOCK_CACHE_MANAGER [INFO] [stdout] 133 | | .lock() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 21 | block_device: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut efs = Self { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Arc::new(Mutex::new(efs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn open(block_device: Arc) -> Arc> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | // read SuperBlock [INFO] [stdout] 83 | / get_block_cache(0, Arc::clone(&block_device)) [INFO] [stdout] 84 | | .lock() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn open(block_device: Arc) -> Arc> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | .read(0, |super_block: &SuperBlock| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 86 | | assert!(super_block.is_valid(), "Error loading EFS!"); [INFO] [stdout] 87 | | let inode_total_blocks = [INFO] [stdout] 88 | | super_block.inode_bitmap_blocks + super_block.inode_area_blocks; [INFO] [stdout] ... | [INFO] [stdout] 99 | | Arc::new(Mutex::new(efs)) [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn open(block_device: Arc) -> Arc> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let efs = Self { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Arc::new(Mutex::new(efs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/efs.rs:109:44 [INFO] [stdout] | [INFO] [stdout] 105 | let block_device = Arc::clone(&efs.lock().block_device); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Inode::new(block_id, block_offset, Arc::clone(efs), block_device) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | fn read_disk_inode(&self, f: impl FnOnce(&DiskInode) -> V) -> V { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / get_block_cache(self.block_id, Arc::clone(&self.block_device)) [INFO] [stdout] 35 | | .lock() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 39 | fn modify_disk_inode(&self, f: impl FnOnce(&mut DiskInode) -> V) -> V { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / get_block_cache(self.block_id, Arc::clone(&self.block_device)) [INFO] [stdout] 41 | | .lock() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 95 | let mut fs = self.fs.lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Some(Arc::new(Self::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 134 | | block_id, [INFO] [stdout] 135 | | block_offset, [INFO] [stdout] 136 | | self.fs.clone(), [INFO] [stdout] 137 | | self.block_device.clone(), [INFO] [stdout] 138 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `easyfs` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "37236c29ae4acb53bcc111e165ced442d7f276a3ad2222a2ab2f6e664f90a537", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37236c29ae4acb53bcc111e165ced442d7f276a3ad2222a2ab2f6e664f90a537", kill_on_drop: false }` [INFO] [stdout] 37236c29ae4acb53bcc111e165ced442d7f276a3ad2222a2ab2f6e664f90a537