[INFO] fetching crate easy_strings 0.2.0... [INFO] checking easy_strings-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate easy_strings 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate easy_strings 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate easy_strings 0.2.0 [INFO] finished tweaking crates.io crate easy_strings 0.2.0 [INFO] tweaked toml for crates.io crate easy_strings 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding owning_ref v0.3.3 (latest: v0.4.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abc1a036f1012e2bf022b61bb5f41de9e342c91aa083d34a8847378bb3dc5480 [INFO] running `Command { std: "docker" "start" "-a" "abc1a036f1012e2bf022b61bb5f41de9e342c91aa083d34a8847378bb3dc5480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abc1a036f1012e2bf022b61bb5f41de9e342c91aa083d34a8847378bb3dc5480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abc1a036f1012e2bf022b61bb5f41de9e342c91aa083d34a8847378bb3dc5480", kill_on_drop: false }` [INFO] [stdout] abc1a036f1012e2bf022b61bb5f41de9e342c91aa083d34a8847378bb3dc5480 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd361f362da0258e69bd62738bf1dc8de549ddb052772cb09818a16faf6990d7 [INFO] running `Command { std: "docker" "start" "-a" "cd361f362da0258e69bd62738bf1dc8de549ddb052772cb09818a16faf6990d7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking easy_strings v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/lib.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / lazy_static! { [INFO] [stdout] 20 | | static ref STATIC_STRINGS: Mutex> = Mutex::default(); [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/lib.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / lazy_static! { [INFO] [stdout] 20 | | static ref STATIC_STRINGS: Mutex> = Mutex::default(); [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left`: superseded by `trim_start` [INFO] [stdout] --> src/ezstring.rs:714:32 [INFO] [stdout] | [INFO] [stdout] 714 | self.from_slice(self.0.trim_left()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 714 | self.from_slice(self.0.trim_start()) [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/ezstring.rs:726:32 [INFO] [stdout] | [INFO] [stdout] 726 | self.from_slice(self.0.trim_right()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 726 | self.from_slice(self.0.trim_end()) [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/ezstring.rs:749:32 [INFO] [stdout] | [INFO] [stdout] 749 | self.from_slice(self.0.trim_left_matches(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 749 | self.from_slice(self.0.trim_start_matches(p)) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/ezstring.rs:762:32 [INFO] [stdout] | [INFO] [stdout] 762 | self.from_slice(self.0.trim_right_matches(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 762 | self.from_slice(self.0.trim_end_matches(p)) [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `easy_strings` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left`: superseded by `trim_start` [INFO] [stdout] --> src/ezstring.rs:714:32 [INFO] [stdout] | [INFO] [stdout] 714 | self.from_slice(self.0.trim_left()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 714 | self.from_slice(self.0.trim_start()) [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/ezstring.rs:726:32 [INFO] [stdout] | [INFO] [stdout] 726 | self.from_slice(self.0.trim_right()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 726 | self.from_slice(self.0.trim_end()) [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/ezstring.rs:749:32 [INFO] [stdout] | [INFO] [stdout] 749 | self.from_slice(self.0.trim_left_matches(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 749 | self.from_slice(self.0.trim_start_matches(p)) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/ezstring.rs:762:32 [INFO] [stdout] | [INFO] [stdout] 762 | self.from_slice(self.0.trim_right_matches(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 762 | self.from_slice(self.0.trim_end_matches(p)) [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 29 | pub unsafe fn new(o: S, f: F) -> Self [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | OwnedIter(OwningHandle::new_with_fn(o, |ptr| DerefNewtype(f(&*ptr)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters.rs:32:67 [INFO] [stdout] | [INFO] [stdout] 32 | OwnedIter(OwningHandle::new_with_fn(o, |ptr| DerefNewtype(f(&*ptr)))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezstring.rs:463:9 [INFO] [stdout] | [INFO] [stdout] 459 | fn wrapped_iter(&self, f: F) -> WrappedIter [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | unsafe { adapters::OwnedIter::new(self.0.clone(), f) }.wrapped() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 29 | pub unsafe fn new(o: S, f: F) -> Self [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | OwnedIter(OwningHandle::new_with_fn(o, |ptr| DerefNewtype(f(&*ptr)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters.rs:32:67 [INFO] [stdout] | [INFO] [stdout] 32 | OwnedIter(OwningHandle::new_with_fn(o, |ptr| DerefNewtype(f(&*ptr)))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezstring.rs:463:9 [INFO] [stdout] | [INFO] [stdout] 459 | fn wrapped_iter(&self, f: F) -> WrappedIter [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | unsafe { adapters::OwnedIter::new(self.0.clone(), f) }.wrapped() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `easy_strings` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cd361f362da0258e69bd62738bf1dc8de549ddb052772cb09818a16faf6990d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd361f362da0258e69bd62738bf1dc8de549ddb052772cb09818a16faf6990d7", kill_on_drop: false }` [INFO] [stdout] cd361f362da0258e69bd62738bf1dc8de549ddb052772cb09818a16faf6990d7