[INFO] fetching crate easy-repl 0.2.1... [INFO] checking easy-repl-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate easy-repl 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate easy-repl 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate easy-repl 0.2.1 [INFO] finished tweaking crates.io crate easy-repl 0.2.1 [INFO] tweaked toml for crates.io crate easy-repl 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate easy-repl 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9655031922b0758411a06f009b5dc53bb8a4fbdde750ea1f7dda5e352aff16b [INFO] running `Command { std: "docker" "start" "-a" "e9655031922b0758411a06f009b5dc53bb8a4fbdde750ea1f7dda5e352aff16b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9655031922b0758411a06f009b5dc53bb8a4fbdde750ea1f7dda5e352aff16b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9655031922b0758411a06f009b5dc53bb8a4fbdde750ea1f7dda5e352aff16b", kill_on_drop: false }` [INFO] [stdout] e9655031922b0758411a06f009b5dc53bb8a4fbdde750ea1f7dda5e352aff16b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff2bc74774ff7a76784a3decb801fb83e4b1206dd4e39191ce407847069a3a29 [INFO] running `Command { std: "docker" "start" "-a" "ff2bc74774ff7a76784a3decb801fb83e4b1206dd4e39191ce407847069a3a29", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling io-lifetimes v0.7.2 [INFO] [stderr] Compiling syn v1.0.71 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling rustix v0.35.7 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking smawk v0.3.1 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking shell-words v1.0.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling aho-corasick v0.7.15 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking fd-lock v3.0.6 [INFO] [stderr] Compiling regex v1.4.6 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling rustyline-derive v0.6.0 [INFO] [stderr] Compiling unicode-linebreak v0.1.2 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking fid-rs v0.1.1 [INFO] [stderr] Checking louds-rs v0.4.0 [INFO] [stderr] Checking trie-rs v0.1.1 [INFO] [stderr] Checking rustyline v9.1.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking easy-repl v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:76:50 [INFO] [stdout] | [INFO] [stdout] 76 | self.map_err(|e| CriticalError::Critical(e.into())) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repl.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn build(self) -> Result, BuilderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let mut commands: HashMap>> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let mut trie = TrieBuilder::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let mut editor = rustyline::Editor::with_config(self.editor_config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(Repl { [INFO] [stdout] | ____________^ [INFO] [stdout] 211 | | description: self.description, [INFO] [stdout] 212 | | prompt: self.prompt, [INFO] [stdout] 213 | | text_width: self.text_width, [INFO] [stdout] ... | [INFO] [stdout] 218 | | predict_commands: self.predict_commands, [INFO] [stdout] 219 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `easy-repl` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/command.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 151 | if let Err(err) = args[i].parse::<$type>() { [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] ... [INFO] [stdout] 277 | let validator = validator!(i32, f32, String); [INFO] [stdout] | ---------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `validator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/command.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 151 | if let Err(err) = args[i].parse::<$type>() { [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] ... [INFO] [stdout] 336 | let cmd = command!("Example cmd", (:i32, :String, :f32) => |_x, _s, _y| { Ok(CommandStatus::Done) }); [INFO] [stdout] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: this warning originates in the macro `$crate::validator` which comes from the expansion of the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/command.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 151 | if let Err(err) = args[i].parse::<$type>() { [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] ... [INFO] [stdout] 349 | let cmd = command! { [INFO] [stdout] | ___________________- [INFO] [stdout] 350 | | "Example cmd", [INFO] [stdout] 351 | | (number:i32, name : String, :f32) => |_x, _s, _y| Ok(CommandStatus::Done) [INFO] [stdout] 352 | | }; [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: this warning originates in the macro `$crate::validator` which comes from the expansion of the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/command.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 151 | if let Err(err) = args[i].parse::<$type>() { [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] ::: src/repl.rs:418:28 [INFO] [stdout] | [INFO] [stdout] 418 | .add("name_x", command!("", (a: String) => |_| Ok(CommandStatus::Done))) [INFO] [stdout] | -------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: this warning originates in the macro `$crate::validator` which comes from the expansion of the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:76:50 [INFO] [stdout] | [INFO] [stdout] 76 | self.map_err(|e| CriticalError::Critical(e.into())) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:321:21 [INFO] [stdout] | [INFO] [stdout] 320 | let err = std::io::Error::new(std::io::ErrorKind::InvalidData, "example error"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | Err(CriticalError::Critical(err.into()).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repl.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn build(self) -> Result, BuilderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let mut commands: HashMap>> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let mut trie = TrieBuilder::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let mut editor = rustyline::Editor::with_config(self.editor_config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(Repl { [INFO] [stdout] | ____________^ [INFO] [stdout] 211 | | description: self.description, [INFO] [stdout] 212 | | prompt: self.prompt, [INFO] [stdout] 213 | | text_width: self.text_width, [INFO] [stdout] ... | [INFO] [stdout] 218 | | predict_commands: self.predict_commands, [INFO] [stdout] 219 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `easy-repl` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ff2bc74774ff7a76784a3decb801fb83e4b1206dd4e39191ce407847069a3a29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff2bc74774ff7a76784a3decb801fb83e4b1206dd4e39191ce407847069a3a29", kill_on_drop: false }` [INFO] [stdout] ff2bc74774ff7a76784a3decb801fb83e4b1206dd4e39191ce407847069a3a29