[INFO] fetching crate e310x-hal 0.11.0... [INFO] checking e310x-hal-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate e310x-hal 0.11.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate e310x-hal 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate e310x-hal 0.11.0 [INFO] finished tweaking crates.io crate e310x-hal 0.11.0 [INFO] tweaked toml for crates.io crate e310x-hal 0.11.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding riscv v0.10.1 (latest: v0.11.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e346068ea21ace7a8cf4e0d2d78beb730e94a445ae78e74f56ffb1f35be51271 [INFO] running `Command { std: "docker" "start" "-a" "e346068ea21ace7a8cf4e0d2d78beb730e94a445ae78e74f56ffb1f35be51271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e346068ea21ace7a8cf4e0d2d78beb730e94a445ae78e74f56ffb1f35be51271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e346068ea21ace7a8cf4e0d2d78beb730e94a445ae78e74f56ffb1f35be51271", kill_on_drop: false }` [INFO] [stdout] e346068ea21ace7a8cf4e0d2d78beb730e94a445ae78e74f56ffb1f35be51271 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9aafc85e45a80095ba4fc390561d0843503d811a853cecf4d78b27330380602f [INFO] running `Command { std: "docker" "start" "-a" "9aafc85e45a80095ba4fc390561d0843503d811a853cecf4d78b27330380602f", kill_on_drop: false }` [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling e310x v0.11.0 [INFO] [stderr] Compiling riscv v0.10.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Checking vcell v0.1.3 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking e310x-hal v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `MODE_0`, `MODE_1`, `MODE_2`, `MODE_3`, `Mode`, `Phase`, and `Polarity` [INFO] [stdout] --> src/spi/shared_bus.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | pub use embedded_hal::spi::{Mode, Phase, Polarity, MODE_0, MODE_1, MODE_2, MODE_3}; [INFO] [stdout] | ^^^^ ^^^^^ ^^^^^^^^ ^^^^^^ ^^^^^^ ^^^^^^ ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MODE_0`, `MODE_1`, `MODE_2`, `MODE_3`, `Mode`, `Phase`, and `Polarity` [INFO] [stdout] --> src/spi/shared_bus.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | pub use embedded_hal::spi::{Mode, Phase, Polarity, MODE_0, MODE_1, MODE_2, MODE_3}; [INFO] [stdout] | ^^^^ ^^^^^ ^^^^^^^^ ^^^^^^ ^^^^^^ ^^^^^^ ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn split(self) -> (Tx, Rx) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | ( [INFO] [stdout] 104 | / Tx { [INFO] [stdout] 105 | | uart: unsafe { mem::zeroed() }, [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn split(self) -> (Tx, Rx) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Rx { uart: self.uart }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi/bus.rs:248:24 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn shared(spi: SPI, pins: PINS) -> SharedBus { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | SharedBus::new(Self::new(spi, pins)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi/shared_bus.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) fn new(bus: SpiBus) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self(RefCell::new(bus)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi/shared_device.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 126 | fn write_iter(&mut self, words: WI) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | interrupt::free(|| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 131 | | let mut bus = self.bus.borrow_mut(); [INFO] [stdout] 132 | | [INFO] [stdout] 133 | | bus.configure(&self.config, Some(CS::CS_INDEX)); [INFO] [stdout] ... | [INFO] [stdout] 139 | | result [INFO] [stdout] 140 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `e310x-hal` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn split(self) -> (Tx, Rx) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | ( [INFO] [stdout] 104 | / Tx { [INFO] [stdout] 105 | | uart: unsafe { mem::zeroed() }, [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn split(self) -> (Tx, Rx) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Rx { uart: self.uart }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi/bus.rs:248:24 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn shared(spi: SPI, pins: PINS) -> SharedBus { [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | SharedBus::new(Self::new(spi, pins)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi/shared_bus.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) fn new(bus: SpiBus) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self(RefCell::new(bus)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spi/shared_device.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 126 | fn write_iter(&mut self, words: WI) -> Result<(), Self::Error> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | interrupt::free(|| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 131 | | let mut bus = self.bus.borrow_mut(); [INFO] [stdout] 132 | | [INFO] [stdout] 133 | | bus.configure(&self.config, Some(CS::CS_INDEX)); [INFO] [stdout] ... | [INFO] [stdout] 139 | | result [INFO] [stdout] 140 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `e310x-hal` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9aafc85e45a80095ba4fc390561d0843503d811a853cecf4d78b27330380602f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9aafc85e45a80095ba4fc390561d0843503d811a853cecf4d78b27330380602f", kill_on_drop: false }` [INFO] [stdout] 9aafc85e45a80095ba4fc390561d0843503d811a853cecf4d78b27330380602f