[INFO] fetching crate dynstore 0.1.2... [INFO] checking dynstore-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dynstore 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dynstore 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dynstore 0.1.2 [INFO] finished tweaking crates.io crate dynstore 0.1.2 [INFO] tweaked toml for crates.io crate dynstore 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding inventory v0.2.3 (latest: v0.3.15) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 578c3665eec1a49dead9e220e91ae2f760c941b25485cc84efb845d0653ffeff [INFO] running `Command { std: "docker" "start" "-a" "578c3665eec1a49dead9e220e91ae2f760c941b25485cc84efb845d0653ffeff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "578c3665eec1a49dead9e220e91ae2f760c941b25485cc84efb845d0653ffeff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "578c3665eec1a49dead9e220e91ae2f760c941b25485cc84efb845d0653ffeff", kill_on_drop: false }` [INFO] [stdout] 578c3665eec1a49dead9e220e91ae2f760c941b25485cc84efb845d0653ffeff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fca8188aae720421b923a17ee547a5057e6143ceb4abdc4cb1d22f7d48561a30 [INFO] running `Command { std: "docker" "start" "-a" "fca8188aae720421b923a17ee547a5057e6143ceb4abdc4cb1d22f7d48561a30", kill_on_drop: false }` [INFO] [stderr] Checking dynstore v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:431:23 [INFO] [stdout] | [INFO] [stdout] 425 | pub fn try_write(&mut self, handle: Handle, value: T) -> bool [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | .and_then(|_| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 432 | | // SAFETY: [INFO] [stdout] 433 | | // a) the T: Sized bound ensures that T is in fact the concrete type of the data, [INFO] [stdout] 434 | | // or at least a type trivially transmutable to it [INFO] [stdout] ... | [INFO] [stdout] 440 | | Some(()) [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:591:9 [INFO] [stdout] | [INFO] [stdout] 591 | self.ptr == other.ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 591 | std::ptr::addr_eq(self.ptr, other.ptr) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 591 | std::ptr::eq(self.ptr, other.ptr) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:602:9 [INFO] [stdout] | [INFO] [stdout] 602 | self.ptr.partial_cmp(&other.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 602 | self.ptr.cast::<()>().partial_cmp(&other.ptr.cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:611:9 [INFO] [stdout] | [INFO] [stdout] 611 | self.ptr.cmp(&other.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 611 | self.ptr.cast::<()>().cmp(&other.ptr.cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dynstore` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:431:23 [INFO] [stdout] | [INFO] [stdout] 425 | pub fn try_write(&mut self, handle: Handle, value: T) -> bool [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | .and_then(|_| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 432 | | // SAFETY: [INFO] [stdout] 433 | | // a) the T: Sized bound ensures that T is in fact the concrete type of the data, [INFO] [stdout] 434 | | // or at least a type trivially transmutable to it [INFO] [stdout] ... | [INFO] [stdout] 440 | | Some(()) [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:591:9 [INFO] [stdout] | [INFO] [stdout] 591 | self.ptr == other.ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 591 | std::ptr::addr_eq(self.ptr, other.ptr) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 591 | std::ptr::eq(self.ptr, other.ptr) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:602:9 [INFO] [stdout] | [INFO] [stdout] 602 | self.ptr.partial_cmp(&other.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 602 | self.ptr.cast::<()>().partial_cmp(&other.ptr.cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/lib.rs:611:9 [INFO] [stdout] | [INFO] [stdout] 611 | self.ptr.cmp(&other.ptr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 611 | self.ptr.cast::<()>().cmp(&other.ptr.cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dynstore` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fca8188aae720421b923a17ee547a5057e6143ceb4abdc4cb1d22f7d48561a30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fca8188aae720421b923a17ee547a5057e6143ceb4abdc4cb1d22f7d48561a30", kill_on_drop: false }` [INFO] [stdout] fca8188aae720421b923a17ee547a5057e6143ceb4abdc4cb1d22f7d48561a30