[INFO] fetching crate dynamo-es 0.4.11... [INFO] checking dynamo-es-0.4.11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dynamo-es 0.4.11 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dynamo-es 0.4.11 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dynamo-es 0.4.11 [INFO] finished tweaking crates.io crate dynamo-es 0.4.11 [INFO] tweaked toml for crates.io crate dynamo-es 0.4.11 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 155 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c24c0506a67db410f7d7ba7c249265ce64fa378130224592068271ea309b4411 [INFO] running `Command { std: "docker" "start" "-a" "c24c0506a67db410f7d7ba7c249265ce64fa378130224592068271ea309b4411", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c24c0506a67db410f7d7ba7c249265ce64fa378130224592068271ea309b4411", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c24c0506a67db410f7d7ba7c249265ce64fa378130224592068271ea309b4411", kill_on_drop: false }` [INFO] [stdout] c24c0506a67db410f7d7ba7c249265ce64fa378130224592068271ea309b4411 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95c6f7cd17a4cc3b9b4a6fb811c13d26c27b9ffcdf3f3e21a71ff6da3c3b6814 [INFO] running `Command { std: "docker" "start" "-a" "95c6f7cd17a4cc3b9b4a6fb811c13d26c27b9ffcdf3f3e21a71ff6da3c3b6814", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking cqrs-es v0.4.11 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking aws-smithy-types v1.2.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.2 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-credential-types v1.2.1 [INFO] [stderr] Checking aws-smithy-http v0.60.10 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.7.1 [INFO] [stderr] Checking aws-runtime v1.4.2 [INFO] [stderr] Checking aws-sdk-sso v1.40.0 [INFO] [stderr] Checking aws-sdk-dynamodb v1.43.0 [INFO] [stderr] Checking aws-sdk-sts v1.40.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.41.0 [INFO] [stderr] Checking aws-config v1.5.5 [INFO] [stderr] Checking dynamo-es v0.4.11 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:59:44 [INFO] [stdout] | [INFO] [stdout] 58 | fn from(err: serde_json::Error) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | DynamoAggregateError::UnknownError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:74:44 [INFO] [stdout] | [INFO] [stdout] 64 | fn from(error: SdkError) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | DynamoAggregateError::UnknownError(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:86:44 [INFO] [stdout] | [INFO] [stdout] 85 | fn from(error: BuildError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | DynamoAggregateError::UnknownError(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:97:40 [INFO] [stdout] | [INFO] [stdout] 96 | fn unknown_error(error: SdkError) -> DynamoAggregateError { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | DynamoAggregateError::UnknownError(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view_repository.rs:92:96 [INFO] [stdout] | [INFO] [stdout] 92 | async fn update_view(&self, view: V, context: ViewContext) -> Result<(), PersistenceError> { [INFO] [stdout] | _________________________________-------________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | | let view_id = AttributeValue::S(String::from(&context.view_instance_id)); [INFO] [stdout] 94 | | let expected_view_version = AttributeValue::N(context.version.to_string()); [INFO] [stdout] 95 | | let view_version = AttributeValue::N((context.version + 1).to_string()); [INFO] [stdout] ... | [INFO] [stdout] 110 | | Ok(()) [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view_repository.rs:107:60 [INFO] [stdout] | [INFO] [stdout] 107 | .map_err(|e|PersistenceError::UnknownError(Box::new(e)))?) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dynamo-es` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:59:44 [INFO] [stdout] | [INFO] [stdout] 58 | fn from(err: serde_json::Error) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | DynamoAggregateError::UnknownError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:74:44 [INFO] [stdout] | [INFO] [stdout] 64 | fn from(error: SdkError) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | DynamoAggregateError::UnknownError(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:86:44 [INFO] [stdout] | [INFO] [stdout] 85 | fn from(error: BuildError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | DynamoAggregateError::UnknownError(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:97:40 [INFO] [stdout] | [INFO] [stdout] 96 | fn unknown_error(error: SdkError) -> DynamoAggregateError { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | DynamoAggregateError::UnknownError(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view_repository.rs:92:96 [INFO] [stdout] | [INFO] [stdout] 92 | async fn update_view(&self, view: V, context: ViewContext) -> Result<(), PersistenceError> { [INFO] [stdout] | _________________________________-------________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | | let view_id = AttributeValue::S(String::from(&context.view_instance_id)); [INFO] [stdout] 94 | | let expected_view_version = AttributeValue::N(context.version.to_string()); [INFO] [stdout] 95 | | let view_version = AttributeValue::N((context.version + 1).to_string()); [INFO] [stdout] ... | [INFO] [stdout] 110 | | Ok(()) [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view_repository.rs:107:60 [INFO] [stdout] | [INFO] [stdout] 107 | .map_err(|e|PersistenceError::UnknownError(Box::new(e)))?) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dynamo-es` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "95c6f7cd17a4cc3b9b4a6fb811c13d26c27b9ffcdf3f3e21a71ff6da3c3b6814", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95c6f7cd17a4cc3b9b4a6fb811c13d26c27b9ffcdf3f3e21a71ff6da3c3b6814", kill_on_drop: false }` [INFO] [stdout] 95c6f7cd17a4cc3b9b4a6fb811c13d26c27b9ffcdf3f3e21a71ff6da3c3b6814