[INFO] fetching crate dynamixel2 0.9.1... [INFO] checking dynamixel2-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dynamixel2 0.9.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate dynamixel2 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dynamixel2 0.9.1 [INFO] finished tweaking crates.io crate dynamixel2 0.9.1 [INFO] tweaked toml for crates.io crate dynamixel2 0.9.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e20287afbb76ff225654604fcf8c3f418d4edf7aaa0feda693924c6abbe459d5 [INFO] running `Command { std: "docker" "start" "-a" "e20287afbb76ff225654604fcf8c3f418d4edf7aaa0feda693924c6abbe459d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e20287afbb76ff225654604fcf8c3f418d4edf7aaa0feda693924c6abbe459d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e20287afbb76ff225654604fcf8c3f418d4edf7aaa0feda693924c6abbe459d5", kill_on_drop: false }` [INFO] [stdout] e20287afbb76ff225654604fcf8c3f418d4edf7aaa0feda693924c6abbe459d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 196866a04e5d942c9f8bfe7be5f1419336b54bba407f1542f3460e9ee4f02fbc [INFO] running `Command { std: "docker" "start" "-a" "196866a04e5d942c9f8bfe7be5f1419336b54bba407f1542f3460e9ee4f02fbc", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling assert2-macros v0.3.15 [INFO] [stderr] Checking serial2 v0.2.26 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking dynamixel2 v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instructions/bulk_write.rs:74:93 [INFO] [stdout] | [INFO] [stdout] 58 | let writes = writes.into_iter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | self.write_instruction(packet_id::BROADCAST, instruction_id::BULK_WRITE, parameter_count, |buffer| { [INFO] [stdout] | ___________________________________________________________________________________________________^ [INFO] [stdout] 75 | | let mut offset = 0; [INFO] [stdout] 76 | | for write in writes { [INFO] [stdout] 77 | | let write = write.borrow(); [INFO] [stdout] ... | [INFO] [stdout] 85 | | } [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instructions/ping.rs:56:38 [INFO] [stdout] | [INFO] [stdout] 56 | match self.scan_cb(|x| result.push(Ok(x))) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instructions/sync_write.rs:52:93 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn sync_write<'a, Iter, Data, Buf>(&mut self, address: u16, count: u16, data: Iter) -> Result<(), WriteError> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let data = data.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | self.write_instruction(packet_id::BROADCAST, instruction_id::SYNC_WRITE, parameter_count, |buffer| { [INFO] [stdout] | ___________________________________________________________________________________________________^ [INFO] [stdout] 53 | | write_u16_le(&mut buffer[0..], address); [INFO] [stdout] 54 | | write_u16_le(&mut buffer[2..], count); [INFO] [stdout] 55 | | for (i, command) in data.enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instructions/sync_write.rs:80:93 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn sync_write_u8(&mut self, address: u16, data: Iter) -> Result<(), WriteError> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let data = data.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | self.write_instruction(packet_id::BROADCAST, instruction_id::SYNC_WRITE, parameter_count, |buffer| { [INFO] [stdout] | ___________________________________________________________________________________________________^ [INFO] [stdout] 81 | | write_u16_le(&mut buffer[0..], address); [INFO] [stdout] 82 | | write_u16_le(&mut buffer[2..], count as u16); [INFO] [stdout] 83 | | for (i, command) in data.enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 88 | | } [INFO] [stdout] 89 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instructions/sync_write.rs:107:93 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn sync_write_u16(&mut self, address: u16, data: Iter) -> Result<(), WriteError> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let data = data.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | self.write_instruction(packet_id::BROADCAST, instruction_id::SYNC_WRITE, parameter_count, |buffer| { [INFO] [stdout] | ___________________________________________________________________________________________________^ [INFO] [stdout] 108 | | write_u16_le(&mut buffer[0..], address); [INFO] [stdout] 109 | | write_u16_le(&mut buffer[2..], count as u16); [INFO] [stdout] 110 | | for (i, command) in data.enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 115 | | } [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instructions/sync_write.rs:134:93 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn sync_write_u32(&mut self, address: u16, data: Iter) -> Result<(), WriteError> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let data = data.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | self.write_instruction(packet_id::BROADCAST, instruction_id::SYNC_WRITE, parameter_count, |buffer| { [INFO] [stdout] | ___________________________________________________________________________________________________^ [INFO] [stdout] 135 | | write_u16_le(&mut buffer[0..], address); [INFO] [stdout] 136 | | write_u16_le(&mut buffer[2..], count as u16); [INFO] [stdout] 137 | | for (i, command) in data.enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 142 | | } [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus.rs:71:6 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn open(path: impl AsRef, baud_rate: u32) -> std::io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let port = SerialPort::open(path, baud_rate)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(Self::with_buffers_and_baud_rate(port, vec![0; 128], vec![0; 128], baud_rate)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus.rs:101:6 [INFO] [stdout] | [INFO] [stdout] 95 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | baud_rate: u32, [INFO] [stdout] 97 | read_buffer: ReadBuffer, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | write_buffer: WriteBuffer, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | ) -> std::io::Result { [INFO] [stdout] 100 | let port = SerialPort::open(path, baud_rate)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Ok(Self::with_buffers_and_baud_rate(port, read_buffer, write_buffer, baud_rate)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus.rs:114:6 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn with_buffers(serial_port: SerialPort, read_buffer: ReadBuffer, write_buffer: WriteBuffer) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dynamixel2` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "196866a04e5d942c9f8bfe7be5f1419336b54bba407f1542f3460e9ee4f02fbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "196866a04e5d942c9f8bfe7be5f1419336b54bba407f1542f3460e9ee4f02fbc", kill_on_drop: false }` [INFO] [stdout] 196866a04e5d942c9f8bfe7be5f1419336b54bba407f1542f3460e9ee4f02fbc