[INFO] fetching crate dynamecs-analyze 0.0.2... [INFO] checking dynamecs-analyze-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dynamecs-analyze 0.0.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dynamecs-analyze 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dynamecs-analyze 0.0.2 [INFO] finished tweaking crates.io crate dynamecs-analyze 0.0.2 [INFO] tweaked toml for crates.io crate dynamecs-analyze 0.0.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 39272bcff5ae32a417094cf75d8364aeadd07afc5195d72cb35cf0c1363a6f97 [INFO] running `Command { std: "docker" "start" "-a" "39272bcff5ae32a417094cf75d8364aeadd07afc5195d72cb35cf0c1363a6f97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "39272bcff5ae32a417094cf75d8364aeadd07afc5195d72cb35cf0c1363a6f97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39272bcff5ae32a417094cf75d8364aeadd07afc5195d72cb35cf0c1363a6f97", kill_on_drop: false }` [INFO] [stdout] 39272bcff5ae32a417094cf75d8364aeadd07afc5195d72cb35cf0c1363a6f97 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d88b43cae65c02556fd644bbc91c9ba93435476e5eb304abe7341e2509aea13e [INFO] running `Command { std: "docker" "start" "-a" "d88b43cae65c02556fd644bbc91c9ba93435476e5eb304abe7341e2509aea13e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling escargot v0.5.12 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking dynamecs-analyze v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:400:34 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn iterate_records_from_reader<'a, R: Read + 'a>(reader: R) -> RecordIter<'a> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | iterate_records_from_reader_(BufReader::new(Box::new(reader))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:405:21 [INFO] [stdout] | [INFO] [stdout] 403 | fn iterate_records_from_reader_<'a>(reader: BufReader>) -> RecordIter<'a> { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 404 | RecordIter { [INFO] [stdout] 405 | lines_iter: reader.lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timing.rs:352:38 [INFO] [stdout] | [INFO] [stdout] 350 | pub fn extract_step_timings<'a>(records: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 351 | // TODO: Collect statistics from spans outside run as well [INFO] [stdout] 352 | find_and_visit_dynamecs_run_span(records.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:400:34 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn iterate_records_from_reader<'a, R: Read + 'a>(reader: R) -> RecordIter<'a> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | iterate_records_from_reader_(BufReader::new(Box::new(reader))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:405:21 [INFO] [stdout] | [INFO] [stdout] 403 | fn iterate_records_from_reader_<'a>(reader: BufReader>) -> RecordIter<'a> { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 404 | RecordIter { [INFO] [stdout] 405 | lines_iter: reader.lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timing.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn extract_timing_summary<'a>(records: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | extract_step_timings(records).map(|series| series.summarize()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_tree.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn try_from_depth_first_ordering(paths: Vec, payloads: Vec) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | tree_depth_first: paths, [INFO] [stdout] 82 | | payloads, [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timing.rs:352:38 [INFO] [stdout] | [INFO] [stdout] 350 | pub fn extract_step_timings<'a>(records: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 351 | // TODO: Collect statistics from spans outside run as well [INFO] [stdout] 352 | find_and_visit_dynamecs_run_span(records.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timing.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn extract_timing_summary<'a>(records: impl IntoIterator) -> eyre::Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | extract_step_timings(records).map(|series| series.summarize()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_tree.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn try_from_depth_first_ordering(paths: Vec, payloads: Vec) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | tree_depth_first: paths, [INFO] [stdout] 82 | | payloads, [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dynamecs-analyze` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `dynamecs-analyze` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "d88b43cae65c02556fd644bbc91c9ba93435476e5eb304abe7341e2509aea13e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d88b43cae65c02556fd644bbc91c9ba93435476e5eb304abe7341e2509aea13e", kill_on_drop: false }` [INFO] [stdout] d88b43cae65c02556fd644bbc91c9ba93435476e5eb304abe7341e2509aea13e