[INFO] fetching crate dyn_derive 0.3.4... [INFO] checking dyn_derive-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dyn_derive 0.3.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dyn_derive 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dyn_derive 0.3.4 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate dyn_derive 0.3.4 [INFO] tweaked toml for crates.io crate dyn_derive 0.3.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6bdaaf5f424fccbdcf4d1ca61f93432688e2e922887d8b0d387305379650aa1a [INFO] running `Command { std: "docker" "start" "-a" "6bdaaf5f424fccbdcf4d1ca61f93432688e2e922887d8b0d387305379650aa1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6bdaaf5f424fccbdcf4d1ca61f93432688e2e922887d8b0d387305379650aa1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6bdaaf5f424fccbdcf4d1ca61f93432688e2e922887d8b0d387305379650aa1a", kill_on_drop: false }` [INFO] [stdout] 6bdaaf5f424fccbdcf4d1ca61f93432688e2e922887d8b0d387305379650aa1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] faf311eaf094c600597f03dd7170c325e59a8e4d46e6727c44fd0a5897572792 [INFO] running `Command { std: "docker" "start" "-a" "faf311eaf094c600597f03dd7170c325e59a8e4d46e6727c44fd0a5897572792", kill_on_drop: false }` [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Checking dyn_std v0.3.3 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking dyn_derive v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn dyn_trait(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let item = syn::parse2(input.into()).expect("expect trait"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | dyn_trait::transform(attr.into(), item).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dyn_trait.rs:117:14 [INFO] [stdout] | [INFO] [stdout] 16 | let mut inst_bound = fact_bound.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Some(syn::TypeParamBound::Trait(inst_bound)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dyn_trait.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 129 | let mut generic_params = vec![]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let mut instance_params = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / match generic_params.len() { [INFO] [stdout] 149 | | 0 => quote! { #ident }, [INFO] [stdout] 150 | | _ => quote! { #ident<#(#generic_params),*> }, [INFO] [stdout] 151 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dyn_trait.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 129 | let mut generic_params = vec![]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let mut instance_params = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | / match instance_params.len() { [INFO] [stdout] 153 | | 0 => quote! { () }, [INFO] [stdout] 154 | | _ => quote! { (#(#instance_params),*,) }, [INFO] [stdout] 155 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subst.rs:126:18 [INFO] [stdout] | [INFO] [stdout] 116 | let mut ty_cons = ty_inst.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let (expr, stmts, destruct, has_inner) = ctx.subst(ty_inst, "e! { x }, &mut 0); [INFO] [stdout] | ---- ----- -------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let pat = match destruct { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Destruct::Preserve(modifier) => quote! { #modifier x }, [INFO] [stdout] | -------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Destruct::Tuple(pat) => pat, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Some(match has_inner { [INFO] [stdout] | __________________^ [INFO] [stdout] 127 | | true => match self.polarity { [INFO] [stdout] 128 | | true => quote! { |#pat: #ty_inst| -> #ty_cons { #stmts #expr } }, [INFO] [stdout] 129 | | false => quote! { |#pat: #ty_cons| -> #ty_inst { #stmts #expr } }, [INFO] [stdout] ... | [INFO] [stdout] 135 | | }, [INFO] [stdout] 136 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dyn_derive` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "faf311eaf094c600597f03dd7170c325e59a8e4d46e6727c44fd0a5897572792", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "faf311eaf094c600597f03dd7170c325e59a8e4d46e6727c44fd0a5897572792", kill_on_drop: false }` [INFO] [stdout] faf311eaf094c600597f03dd7170c325e59a8e4d46e6727c44fd0a5897572792