[INFO] fetching crate dvb-gse 0.6.2... [INFO] checking dvb-gse-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dvb-gse 0.6.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dvb-gse 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dvb-gse 0.6.2 [INFO] finished tweaking crates.io crate dvb-gse 0.6.2 [INFO] tweaked toml for crates.io crate dvb-gse 0.6.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate dvb-gse 0.6.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77fa12d22af666a692b5c39942de48f8e2b4a17344b71412c3f011a8102c3817 [INFO] running `Command { std: "docker" "start" "-a" "77fa12d22af666a692b5c39942de48f8e2b4a17344b71412c3f011a8102c3817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77fa12d22af666a692b5c39942de48f8e2b4a17344b71412c3f011a8102c3817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77fa12d22af666a692b5c39942de48f8e2b4a17344b71412c3f011a8102c3817", kill_on_drop: false }` [INFO] [stdout] 77fa12d22af666a692b5c39942de48f8e2b4a17344b71412c3f011a8102c3817 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd760d31a0f2d17b3bb760c75259e3df4affff40980eb8091d3d445e0dcbed9f [INFO] running `Command { std: "docker" "start" "-a" "dd760d31a0f2d17b3bb760c75259e3df4affff40980eb8091d3d445e0dcbed9f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling serde v1.0.199 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Compiling tun-tap v0.1.4 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking dvb-gse v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bbframe.rs:314:21 [INFO] [stdout] | [INFO] [stdout] 311 | pub fn new(recv_fragment: R) -> BBFrameDefrag { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | buffer: Box::new([0; BBFRAME_MAX_LEN]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bbframe.rs:404:21 [INFO] [stdout] | [INFO] [stdout] 401 | pub fn new(recv_bbframe: R) -> BBFrameRecv { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | buffer: Box::new([0; BBFRAME_MAX_LEN]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bbframe.rs:492:21 [INFO] [stdout] | [INFO] [stdout] 489 | pub fn new(recv_stream: R) -> BBFrameStream { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | buffer: Box::new([0; BBFRAME_MAX_LEN]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsepacket.rs:60:14 [INFO] [stdout] | [INFO] [stdout] 59 | let data = bytes.slice(header_len..total_len); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Some(GSEPacket { header, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsepacket.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 75 | let mut remain = bbframe.slice(BBHeader::LEN..); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut label = None; [INFO] [stdout] 77 | Ok(std::iter::from_fn(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | if let Some(packet) = GSEPacket::from_bytes(&remain, label.as_ref()) { [INFO] [stdout] 79 | | log::debug!("extracted GSE Packet with header {}", packet.header()); [INFO] [stdout] 80 | | log::trace!( [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsepacket.rs:312:14 [INFO] [stdout] | [INFO] [stdout] 290 | fn reconstruct(self, frag_id: u8) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | let data = self.fragments.iter().flatten().copied().collect::(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Some(PDU { [INFO] [stdout] | ______________^ [INFO] [stdout] 313 | | data: data.slice(..data.len() - crc_size), [INFO] [stdout] 314 | | protocol_type: self.protocol_type, [INFO] [stdout] 315 | | label: self.label, [INFO] [stdout] 316 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dvb-gse` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bbframe.rs:314:21 [INFO] [stdout] | [INFO] [stdout] 311 | pub fn new(recv_fragment: R) -> BBFrameDefrag { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | buffer: Box::new([0; BBFRAME_MAX_LEN]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bbframe.rs:404:21 [INFO] [stdout] | [INFO] [stdout] 401 | pub fn new(recv_bbframe: R) -> BBFrameRecv { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | buffer: Box::new([0; BBFRAME_MAX_LEN]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bbframe.rs:492:21 [INFO] [stdout] | [INFO] [stdout] 489 | pub fn new(recv_stream: R) -> BBFrameStream { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | buffer: Box::new([0; BBFRAME_MAX_LEN]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::hint::must_use` that must be used [INFO] [stdout] --> src/bbheader.rs:322:13 [INFO] [stdout] | [INFO] [stdout] 322 | format!("{header}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `format` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::hint::must_use` that must be used [INFO] [stdout] --> src/gseheader.rs:531:17 [INFO] [stdout] | [INFO] [stdout] 531 | format!("{}", header); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `format` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsepacket.rs:60:14 [INFO] [stdout] | [INFO] [stdout] 59 | let data = bytes.slice(header_len..total_len); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Some(GSEPacket { header, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsepacket.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 75 | let mut remain = bbframe.slice(BBHeader::LEN..); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut label = None; [INFO] [stdout] 77 | Ok(std::iter::from_fn(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | if let Some(packet) = GSEPacket::from_bytes(&remain, label.as_ref()) { [INFO] [stdout] 79 | | log::debug!("extracted GSE Packet with header {}", packet.header()); [INFO] [stdout] 80 | | log::trace!( [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsepacket.rs:312:14 [INFO] [stdout] | [INFO] [stdout] 290 | fn reconstruct(self, frag_id: u8) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | let data = self.fragments.iter().flatten().copied().collect::(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Some(PDU { [INFO] [stdout] | ______________^ [INFO] [stdout] 313 | | data: data.slice(..data.len() - crc_size), [INFO] [stdout] 314 | | protocol_type: self.protocol_type, [INFO] [stdout] 315 | | label: self.label, [INFO] [stdout] 316 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dvb-gse` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dd760d31a0f2d17b3bb760c75259e3df4affff40980eb8091d3d445e0dcbed9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd760d31a0f2d17b3bb760c75259e3df4affff40980eb8091d3d445e0dcbed9f", kill_on_drop: false }` [INFO] [stdout] dd760d31a0f2d17b3bb760c75259e3df4affff40980eb8091d3d445e0dcbed9f