[INFO] fetching crate dust-devil-sandstorm 1.1.0... [INFO] checking dust-devil-sandstorm-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dust-devil-sandstorm 1.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dust-devil-sandstorm 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dust-devil-sandstorm 1.1.0 [INFO] finished tweaking crates.io crate dust-devil-sandstorm 1.1.0 [INFO] tweaked toml for crates.io crate dust-devil-sandstorm 1.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate dust-devil-sandstorm 1.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f56dabe859decfe864adb52d16f50f49ab8a8b8101689b1b8b5772141560705 [INFO] running `Command { std: "docker" "start" "-a" "5f56dabe859decfe864adb52d16f50f49ab8a8b8101689b1b8b5772141560705", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f56dabe859decfe864adb52d16f50f49ab8a8b8101689b1b8b5772141560705", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f56dabe859decfe864adb52d16f50f49ab8a8b8101689b1b8b5772141560705", kill_on_drop: false }` [INFO] [stdout] 5f56dabe859decfe864adb52d16f50f49ab8a8b8101689b1b8b5772141560705 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fd8a41978e0d775fb84fd58eb35ed92730b09fd01d98409aa75eeaa4cd2cb9b [INFO] running `Command { std: "docker" "start" "-a" "5fd8a41978e0d775fb84fd58eb35ed92730b09fd01d98409aa75eeaa4cd2cb9b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling ahash v0.8.9 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking lru v0.12.2 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking ratatui v0.26.1 [INFO] [stderr] Checking dust-devil-core v1.1.0 [INFO] [stderr] Checking dust-devil-sandstorm v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `set_is_loading` is never used [INFO] [stdout] --> src/tui/popups/loading_popup.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub trait LoadingPopupController: PopupBaseController { [INFO] [stdout] | ---------------------- method in this trait [INFO] [stdout] 24 | fn set_is_loading(&self, loading: bool); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `redraw_notify` and `request_resize` are never used [INFO] [stdout] --> src/tui/popups/popup_base.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub trait PopupBaseController { [INFO] [stdout] | ------------------- methods in this trait [INFO] [stdout] 25 | fn redraw_notify(&self); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 26 | fn request_resize(&self); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sandstorm.rs:636:49 [INFO] [stdout] | [INFO] [stdout] 635 | pub fn into_mutexed(self) -> MutexedSandstormRequestManager { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 636 | MutexedSandstormRequestManager { inner: Mutex::new(self) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/main_view/log_block.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 80 | let handler = LogListHandler { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | list: LongList::new(redraw_notify, TITLE.into(), 0, true, false, handler), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/menu_bar.rs:597:30 [INFO] [stdout] | [INFO] [stdout] 588 | buffer_size_sender: broadcast::Sender, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | let manager = Weak::clone(manager); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | tokio::task::spawn_local(async move { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 598 | | join!( [INFO] [stdout] 599 | | buffer_frame_background_task(&manager, &state, &redraw_notify, buffer_size_sender), [INFO] [stdout] 600 | | ping_frame_background_task(&manager, &state, &redraw_notify), [INFO] [stdout] 601 | | ); [INFO] [stdout] 602 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/add_socket_popup.rs:177:74 [INFO] [stdout] | [INFO] [stdout] 177 | let (manager_rc, socket_type) = match controller.upgrade().map(|rc| (rc.manager.upgrade(), rc)) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/auth_methods_popup.rs:409:19 [INFO] [stdout] | [INFO] [stdout] 399 | fn new(redraw_notify: Rc, controller: Rc>) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let list = LongList::new(redraw_notify, "".into(), 0, false, true, AuthListHandler { controller }); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | [INFO] [stdout] 406 | let lower_split = VerticalSplit::new(list, bottom_text, 0, 0); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | base: VerticalSplit::new(top_text, lower_split, 0, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/close_socket_popup.rs:141:95 [INFO] [stdout] | [INFO] [stdout] 141 | let (manager_rc, socket_type, socket_address) = match controller_weak.upgrade().map(|rc| (rc.manager.upgrade(), rc)) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/popup_base.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 144 | controller: Rc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | content: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | content: ConstrainedPopupContent::new(size_constraint, FocusCell::new(content)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/sockets_popup.rs:763:79 [INFO] [stdout] | [INFO] [stdout] 763 | let (manager_rc, socket_type) = match controller_weak.upgrade().map(|rc| (rc.manager.upgrade(), rc)) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/update_user_popup.rs:307:55 [INFO] [stdout] | [INFO] [stdout] 307 | let current_role = role.unwrap_or_else(|| rc.inner.borrow().user_role); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/ui_manager.rs:59:22 [INFO] [stdout] | [INFO] [stdout] 57 | fn from(value: (T, oneshot::Receiver<()>)) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Popup { [INFO] [stdout] 59 | element: Box::new(value.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/ui_manager.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 72 | manager: Weak>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let (socks5_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let (sandstorm_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let (users_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let (auth_methods_watch, _) = broadcast::channel(32); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (buffer_size_watch, _) = broadcast::channel(1); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (popup_sender, popup_receiver) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let menu_bar = MenuBar::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let main_view = MainView::new(Rc::clone(&redraw_notify), metrics); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | root: FocusCell::new(VerticalSplit::new(menu_bar, main_view, 2, 0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/ui_manager.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 72 | manager: Weak>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let (socks5_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let (sandstorm_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let (users_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let (auth_methods_watch, _) = broadcast::channel(32); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (buffer_size_watch, _) = broadcast::channel(1); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (popup_sender, popup_receiver) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let menu_bar = MenuBar::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let main_view = MainView::new(Rc::clone(&redraw_notify), metrics); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | popups: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/setnext_iter.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(inner: I) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Self { inner, next: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_is_loading` is never used [INFO] [stdout] --> src/tui/popups/loading_popup.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub trait LoadingPopupController: PopupBaseController { [INFO] [stdout] | ---------------------- method in this trait [INFO] [stdout] 24 | fn set_is_loading(&self, loading: bool); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `redraw_notify` and `request_resize` are never used [INFO] [stdout] --> src/tui/popups/popup_base.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub trait PopupBaseController { [INFO] [stdout] | ------------------- methods in this trait [INFO] [stdout] 25 | fn redraw_notify(&self); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 26 | fn request_resize(&self); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sandstorm.rs:636:49 [INFO] [stdout] | [INFO] [stdout] 635 | pub fn into_mutexed(self) -> MutexedSandstormRequestManager { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 636 | MutexedSandstormRequestManager { inner: Mutex::new(self) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/main_view/log_block.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 80 | let handler = LogListHandler { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | list: LongList::new(redraw_notify, TITLE.into(), 0, true, false, handler), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/menu_bar.rs:597:30 [INFO] [stdout] | [INFO] [stdout] 588 | buffer_size_sender: broadcast::Sender, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | let manager = Weak::clone(manager); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | tokio::task::spawn_local(async move { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 598 | | join!( [INFO] [stdout] 599 | | buffer_frame_background_task(&manager, &state, &redraw_notify, buffer_size_sender), [INFO] [stdout] 600 | | ping_frame_background_task(&manager, &state, &redraw_notify), [INFO] [stdout] 601 | | ); [INFO] [stdout] 602 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/add_socket_popup.rs:177:74 [INFO] [stdout] | [INFO] [stdout] 177 | let (manager_rc, socket_type) = match controller.upgrade().map(|rc| (rc.manager.upgrade(), rc)) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/auth_methods_popup.rs:409:19 [INFO] [stdout] | [INFO] [stdout] 399 | fn new(redraw_notify: Rc, controller: Rc>) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let list = LongList::new(redraw_notify, "".into(), 0, false, true, AuthListHandler { controller }); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | [INFO] [stdout] 406 | let lower_split = VerticalSplit::new(list, bottom_text, 0, 0); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | base: VerticalSplit::new(top_text, lower_split, 0, 0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/close_socket_popup.rs:141:95 [INFO] [stdout] | [INFO] [stdout] 141 | let (manager_rc, socket_type, socket_address) = match controller_weak.upgrade().map(|rc| (rc.manager.upgrade(), rc)) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/popup_base.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 144 | controller: Rc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | content: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | content: ConstrainedPopupContent::new(size_constraint, FocusCell::new(content)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/sockets_popup.rs:763:79 [INFO] [stdout] | [INFO] [stdout] 763 | let (manager_rc, socket_type) = match controller_weak.upgrade().map(|rc| (rc.manager.upgrade(), rc)) { [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/popups/update_user_popup.rs:307:55 [INFO] [stdout] | [INFO] [stdout] 307 | let current_role = role.unwrap_or_else(|| rc.inner.borrow().user_role); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/ui_manager.rs:59:22 [INFO] [stdout] | [INFO] [stdout] 57 | fn from(value: (T, oneshot::Receiver<()>)) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Popup { [INFO] [stdout] 59 | element: Box::new(value.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/ui_manager.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 72 | manager: Weak>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let (socks5_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let (sandstorm_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let (users_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let (auth_methods_watch, _) = broadcast::channel(32); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (buffer_size_watch, _) = broadcast::channel(1); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (popup_sender, popup_receiver) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let menu_bar = MenuBar::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let main_view = MainView::new(Rc::clone(&redraw_notify), metrics); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | root: FocusCell::new(VerticalSplit::new(menu_bar, main_view, 2, 0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui/ui_manager.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 72 | manager: Weak>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let (socks5_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let (sandstorm_sockets_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let (users_watch, _) = broadcast::channel(32); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let (auth_methods_watch, _) = broadcast::channel(32); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (buffer_size_watch, _) = broadcast::channel(1); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (popup_sender, popup_receiver) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let menu_bar = MenuBar::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let main_view = MainView::new(Rc::clone(&redraw_notify), metrics); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | popups: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/setnext_iter.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(inner: I) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Self { inner, next: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dust-devil-sandstorm` (bin "sandstorm" test) due to 14 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dust-devil-sandstorm` (bin "sandstorm") due to 14 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5fd8a41978e0d775fb84fd58eb35ed92730b09fd01d98409aa75eeaa4cd2cb9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fd8a41978e0d775fb84fd58eb35ed92730b09fd01d98409aa75eeaa4cd2cb9b", kill_on_drop: false }` [INFO] [stdout] 5fd8a41978e0d775fb84fd58eb35ed92730b09fd01d98409aa75eeaa4cd2cb9b