[INFO] fetching crate dusk-hamt 0.11.0-rkyv.1... [INFO] checking dusk-hamt-0.11.0-rkyv.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dusk-hamt 0.11.0-rkyv.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dusk-hamt 0.11.0-rkyv.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate dusk-hamt 0.11.0-rkyv.1 [INFO] finished tweaking crates.io crate dusk-hamt 0.11.0-rkyv.1 [INFO] tweaked toml for crates.io crate dusk-hamt 0.11.0-rkyv.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding microkelvin v0.16.0-rkyv.3 (latest: v0.17.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding rend v0.3.6 (latest: v0.4.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a950cff85aca88741bd4088ec1b6e6de27c5fad0cc06a070992212529811f08 [INFO] running `Command { std: "docker" "start" "-a" "0a950cff85aca88741bd4088ec1b6e6de27c5fad0cc06a070992212529811f08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a950cff85aca88741bd4088ec1b6e6de27c5fad0cc06a070992212529811f08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a950cff85aca88741bd4088ec1b6e6de27c5fad0cc06a070992212529811f08", kill_on_drop: false }` [INFO] [stdout] 0a950cff85aca88741bd4088ec1b6e6de27c5fad0cc06a070992212529811f08 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a0e04ccc5f3f99740e172fabe558d669e61b276ff8d4162d388f8ab011af642 [INFO] running `Command { std: "docker" "start" "-a" "2a0e04ccc5f3f99740e172fabe558d669e61b276ff8d4162d388f8ab011af642", kill_on_drop: false }` [INFO] [stderr] Compiling bytecheck v0.6.12 [INFO] [stderr] Compiling rend v0.4.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling rkyv v0.7.45 [INFO] [stderr] Compiling rend v0.3.6 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Compiling bytecheck_derive v0.6.12 [INFO] [stderr] Compiling rkyv_derive v0.7.45 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking ahash v0.7.8 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Checking microkelvin v0.16.0-rkyv.3 [INFO] [stderr] Checking dusk-hamt v0.11.0-rkyv.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:15 [INFO] [stdout] | [INFO] [stdout] 197 | fn walk(&mut self, level: impl Walkable) -> Step { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | match level.probe(slot) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:15 [INFO] [stdout] | [INFO] [stdout] 197 | fn walk(&mut self, level: impl Walkable) -> Step { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | match level.probe(slot) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:15 [INFO] [stdout] | [INFO] [stdout] 237 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | val: V, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | match bucket.take() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:15 [INFO] [stdout] | [INFO] [stdout] 237 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | val: V, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | match bucket.take() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:327:21 [INFO] [stdout] | [INFO] [stdout] 327 | drop(node); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Hamt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 327 - drop(node); [INFO] [stdout] 327 + let _ = node; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:340:32 [INFO] [stdout] | [INFO] [stdout] 340 | .and_then(|mut b| (b.leaf_mut().key == *key).then(|| b)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:327:21 [INFO] [stdout] | [INFO] [stdout] 327 | drop(node); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Hamt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 327 - drop(node); [INFO] [stdout] 327 + let _ = node; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:340:32 [INFO] [stdout] | [INFO] [stdout] 340 | .and_then(|mut b| (b.leaf_mut().key == *key).then(|| b)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dusk-hamt` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `dusk-hamt` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2a0e04ccc5f3f99740e172fabe558d669e61b276ff8d4162d388f8ab011af642", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a0e04ccc5f3f99740e172fabe558d669e61b276ff8d4162d388f8ab011af642", kill_on_drop: false }` [INFO] [stdout] 2a0e04ccc5f3f99740e172fabe558d669e61b276ff8d4162d388f8ab011af642