[INFO] fetching crate duplicate_destroyer 0.0.8... [INFO] checking duplicate_destroyer-0.0.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate duplicate_destroyer 0.0.8 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate duplicate_destroyer 0.0.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate duplicate_destroyer 0.0.8 [INFO] finished tweaking crates.io crate duplicate_destroyer 0.0.8 [INFO] tweaked toml for crates.io crate duplicate_destroyer 0.0.8 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate duplicate_destroyer 0.0.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2512cfded29df09f65941140216d5f207b60820ee5b86b19e3a28c0281bf046 [INFO] running `Command { std: "docker" "start" "-a" "b2512cfded29df09f65941140216d5f207b60820ee5b86b19e3a28c0281bf046", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2512cfded29df09f65941140216d5f207b60820ee5b86b19e3a28c0281bf046", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2512cfded29df09f65941140216d5f207b60820ee5b86b19e3a28c0281bf046", kill_on_drop: false }` [INFO] [stdout] b2512cfded29df09f65941140216d5f207b60820ee5b86b19e3a28c0281bf046 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9fffa2dae6c8398c33754a75b92db0c73ae8019c9f3ed3b27ab805177c38118b [INFO] running `Command { std: "docker" "start" "-a" "9fffa2dae6c8398c33754a75b92db0c73ae8019c9f3ed3b27ab805177c38118b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking keccak v0.1.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking id_tree v1.8.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking duplicate_destroyer v0.0.8 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir_tree.rs:186:30 [INFO] [stdout] | [INFO] [stdout] 168 | multiline_indicator: Rc>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | progress_indicator: Rc>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let mut dir_tree = Tree::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let root_node = NodeType::Dir { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | duplicate_table: DuplicateTable::new(num_threads, hash_algorithm), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir_tree.rs:722:21 [INFO] [stdout] | [INFO] [stdout] 720 | fn insert_node(&mut self, node: NodeType, parent_node: &NodeId) -> NodeId { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 721 | self.dir_tree [INFO] [stdout] 722 | .insert(Node::new(RefCell::new(node)), UnderNode(parent_node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_table.rs:81:26 [INFO] [stdout] | [INFO] [stdout] 58 | let mut threadpool = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let (checksum_tx, checksum_rx) = channel::<(PartialChecksum, Checksum, TableData)>(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | checksum_fn: Arc::new(checksum_fn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_table.rs:198:51 [INFO] [stdout] | [INFO] [stdout] 196 | let checksum_tx = self.checksum_tx.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | let checksum_fn = self.checksum_fn.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | self.threadpool.as_ref().unwrap().execute(move || { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 199 | | let checksum = checksum_fn(entry.path()).expect("Could not calculate checksum"); [INFO] [stdout] 200 | | checksum_tx.send((part_checksum, checksum, entry)).expect("Could not send data."); [INFO] [stdout] 201 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duplicate_destroyer` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9fffa2dae6c8398c33754a75b92db0c73ae8019c9f3ed3b27ab805177c38118b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fffa2dae6c8398c33754a75b92db0c73ae8019c9f3ed3b27ab805177c38118b", kill_on_drop: false }` [INFO] [stdout] 9fffa2dae6c8398c33754a75b92db0c73ae8019c9f3ed3b27ab805177c38118b